From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 681C4C48BC3 for ; Mon, 19 Feb 2024 15:07:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ECF4F6B0071; Mon, 19 Feb 2024 10:07:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E7FA16B0074; Mon, 19 Feb 2024 10:07:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D47FA6B0078; Mon, 19 Feb 2024 10:07:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C5E5E6B0071 for ; Mon, 19 Feb 2024 10:07:55 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9B1D91C0456 for ; Mon, 19 Feb 2024 15:07:55 +0000 (UTC) X-FDA: 81808883310.04.E742E9F Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf22.hostedemail.com (Postfix) with ESMTP id 1953BC0022 for ; Mon, 19 Feb 2024 15:07:52 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=SunLaCRo; spf=pass (imf22.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708355273; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rkndU+NnuO7/1RDNdFrkuk4Jm0zJ0XhgNoPsGshVc0I=; b=roKGKsOrD1lJLIgeic5vFnZPBdvf0VTRgBUxNcYdb6XIUp1+2OyOupIOL/RIfQANJnFaW5 HrVrWVSZQACJyj8VtzkAyM3uRntBbeAtda7pgaye/8lUi+LdE/816AZkfrD1JTgsi76pCL q8a3AmLuo2iUIrI3QIkbGTK/ABLFf+k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708355273; a=rsa-sha256; cv=none; b=HxbMJMNWosx4poD1Yz+a+QkUiVVwAGLo5bHLz8JE/Vd1+pIDjt0D5sNWv/n6hxgwQLFxTO AvhZNsDT0l9DbWqE3JWZwGPRRa2HOA6vuacnzLIgmBwaH4z1Rk7wstTmBICMXSz1FJgIc1 6FStBZ2Tlp5XMchtIKSorRjK6rr5eRE= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=SunLaCRo; spf=pass (imf22.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 41JF36oZ014146; Mon, 19 Feb 2024 15:07:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=rkndU+NnuO7/1RDNdFrkuk4Jm0zJ0XhgNoPsGshVc0I=; b=SunLaCRoRblZgR7uTkjILl7gig+35o40zlY1Q0cpz9nRclgNgBY4KSSbQ0yT6u95ffGm fHbFI/UBsy5cAXhKkkbqayqDh1/S7gYy+Vvyx8CMO6miZFdMNfFpvnYGMmB0EYBf3Ptp rJpFjVmKOaNX95WVwF3diq0LM7oX58sNA39y6rnPmHw+p95WUp5scJa7WxNfCw699XBW 67kDaByH2lz8cO1Mtc1SuR6efgens6qNKM3Qxw5zgSgL8QZe8KthrH8fIRsBaWKBtfvP fQoMlnetW1x6bkcINhWai6Ovf4mJU7lB6QnPPwbkEEInMz9fqupxXSAwOdhi94NZGvSP Iw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3wc99h85k6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 19 Feb 2024 15:07:32 +0000 Received: from m0356517.ppops.net (m0356517.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 41JF55ZG021278; Mon, 19 Feb 2024 15:07:31 GMT Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3wc99h85jc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 19 Feb 2024 15:07:31 +0000 Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 41JDBrsc003606; Mon, 19 Feb 2024 15:07:30 GMT Received: from smtprelay04.wdc07v.mail.ibm.com ([172.16.1.71]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 3wb74ta7uu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 19 Feb 2024 15:07:30 +0000 Received: from smtpav05.dal12v.mail.ibm.com (smtpav05.dal12v.mail.ibm.com [10.241.53.104]) by smtprelay04.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 41JF7R0X44434016 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 19 Feb 2024 15:07:29 GMT Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1496658067; Mon, 19 Feb 2024 15:07:27 +0000 (GMT) Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4835E5805D; Mon, 19 Feb 2024 15:07:19 +0000 (GMT) Received: from [9.109.245.191] (unknown [9.109.245.191]) by smtpav05.dal12v.mail.ibm.com (Postfix) with ESMTP; Mon, 19 Feb 2024 15:07:18 +0000 (GMT) Message-ID: <25b420aa-3fe6-40a4-8d60-a46ab61ee7b7@linux.ibm.com> Date: Mon, 19 Feb 2024 20:37:17 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] mm/numa_balancing:Allow migrate on protnone reference with MPOL_PREFERRED_MANY policy Content-Language: en-US To: Michal Hocko Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Aneesh Kumar , Huang Ying , Dave Hansen , Mel Gorman , Ben Widawsky , Feng Tang , Andrea Arcangeli , Peter Zijlstra , Ingo Molnar , Rik van Riel , Johannes Weiner , Matthew Wilcox , Mike Kravetz , Vlastimil Babka , Dan Williams , Hugh Dickins , Kefeng Wang , Suren Baghdasaryan References: <9c3f7b743477560d1c5b12b8c111a584a2cc92ee.1708097962.git.donettom@linux.ibm.com> <8d7737208bd24e754dc7a538a3f7f02de84f1f72.1708097962.git.donettom@linux.ibm.com> From: Donet Tom In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: axymrxJYgqQiIZPCDql1czZk-MR6X7tU X-Proofpoint-ORIG-GUID: SeGuMQBK-_3pEtMiggIDmQMp_pydrOJv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-19_11,2024-02-19_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 mlxlogscore=889 clxscore=1015 suspectscore=0 phishscore=0 impostorscore=0 bulkscore=0 adultscore=0 spamscore=0 malwarescore=0 lowpriorityscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2402190113 X-Stat-Signature: 5an8qribi6h584a6dxbzcy5gcgksebzt X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 1953BC0022 X-Rspam-User: X-HE-Tag: 1708355272-697013 X-HE-Meta: U2FsdGVkX196eq7zJR7bpBapxywXNCVXxWxPDkpihET8NLL5CqD9/AfvBmy64NOFAzu71LbLx+0daWFntLdAzrizWTcJ3VcXDkj7Zw3LWH9Ncjyo6yqPg688N5Iy8yZxRHvf56FYEmh/6SdJk2g5OUT8ZhNHabJ6dmG3Eyf1GlP79QX2c7Hyy8eNgez3vTzDEmIJrCadIZlZQXFmc7D+H0JXteP5HLioLcqMG4cJGZuNTIEDWvl5L0wf/Qk60BWZTF4Md3sS8ud/2OrvVEbF8+OMNENtNhwzhPv2cWxl96VhCTtRD0WwMT/G52pRxYAspI5iDkzqtSA2UN1MU8qa4gG649BUiW2mLdRc+3BuEz9S7dP5MlmF5QQOqMw3FGTlSUCmgtw90w0Sgf6qMphEaIfOgGgbhc2f7lHWbg3XiNMvMmK+2i3Yn9gIkK7Nuu8dFcLO4Vb59fq4O+M1mQtSfc9WRZcrw2SQVB/cVXK0Zl1vu0iW4WbU6KXKl+aiuQ2mzk2dJVgerzfbUEjBEj2O3c8E9ayKlJmMmr5KNTLPidtIXgcblJr/0jQvq6roA4UhK/ky9pt7eNAxL0MA8aReRoO41Qh7EdwWaJCvvCOKsQModPcoTT+913++wtMmLUVibzbqs8EcLJhItQsDK/v779UNIDaUSdp/jv64jzDfF1ljmPpuqA7QFJIp4UZ3ExZ6ZXFlPF2XJqba1W9gFXp1IoEkidXqu9Nvy+s1zJQ/YMlgssKSLUqwqkhZnYozqpX6FApwYwoqkfXs3P8FdGQrDlg4t75J+IpLJJs3f7bHU2EY+Npa+k3TJ1BpIEG4JMSaLSLOgp3Y0rCFJBSYXVHj2fcHUm4S27fj7Yek9ktaHb51Wh6mVzXzYngYhmm+rI3kThEe6JGIjLnEXc2ph98f9C45HKX5fwNEEHZmT1uEBE0a8s1Ib5l+B80rT7A87o2IXEX7bcZe+c93517AQC5 F51IXA3K U51PDNEEUhsSaTjggWXrAwRWIKtqObeU6krYaHMB+EeS/q/mj/04crxGY0wh9icMq9KR6m7nRZlsFztVaDSyhnHv6qUfElHHS+8vDdzPCnIiAT9N3tU5ln4SR49ezln5yCk6rA5utDgddeJmYKjGI8aJM7Vjc7dCFfoipUIddTrSV+mHQPl1CKStlI6hdAQ/se5iOARN0zaq9jnTmUKbfX/v1M2sVumsgrsTmfb7HsaMYo+dgY37uiQuQTnn2GXSI1veEu3HV1eNRt9/wiWwuXBy8uLArAyk3LMc0Xs7sYzpgRloXZnyzUnJsxrTNkPNytCSQVzKVWioWzOeDIhIDUo1/Xg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/19/24 19:50, Michal Hocko wrote: > On Sat 17-02-24 01:31:35, Donet Tom wrote: > [...] >> +static inline bool mpol_preferred_should_numa_migrate(int exec_node, int folio_node, >> + struct mempolicy *pol) >> +{ >> + /* if the executing node is in the policy node mask, migrate */ >> + if (node_isset(exec_node, pol->nodes)) >> + return true; >> + >> + /* If the folio node is in policy node mask, don't migrate */ >> + if (node_isset(folio_node, pol->nodes)) >> + return false; >> + /* >> + * both the folio node and executing node are outside the policy nodemask, >> + * migrate as normal numa fault migration. >> + */ >> + return true; >> +} > I have looked at this again and only now noticed that this doesn't > really work as one would expected. > > case MPOL_PREFERRED_MANY: > /* > * use current page if in policy nodemask, > * else select nearest allowed node, if any. > * If no allowed nodes, use current [!misplaced]. > */ > if (node_isset(curnid, pol->nodes)) > goto out; > z = first_zones_zonelist( > node_zonelist(numa_node_id(), GFP_HIGHUSER), > gfp_zone(GFP_HIGHUSER), > &pol->nodes); > polnid = zone_to_nid(z->zone); > break; > > Will collapse the whole MPOL_PREFERRED_MANY nodemask into the first > notde into that mask. Is that really what we want here? Shouldn't we use > the full nodemask as the migration target? With this patch it will take full nodemask and find out the correct migration target. It will not collapse into first node. For example if we have 5 NUMA nodes in our system N1 to N5, all five are in nodemask and the execution node is N3. with this fix mpol_preferred_should_numa_migrate() will return true because the execution node is there in the nodemask. So mpol_misplaced() will select N3 as the migration target since MPOL_F_MORON is set and migrate the pages to N3.     /* Migrate the folio towards the node whose CPU is referencing it */     if (pol->flags & MPOL_F_MORON) {         polnid = thisnid; So with this patch pages will get migrated to the correct migration target. >