From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83055C4345F for ; Thu, 25 Apr 2024 09:33:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 203836B009A; Thu, 25 Apr 2024 05:33:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B1E86B009D; Thu, 25 Apr 2024 05:33:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 02CB16B009E; Thu, 25 Apr 2024 05:33:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D607E6B009A for ; Thu, 25 Apr 2024 05:33:06 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6D050A1FEA for ; Thu, 25 Apr 2024 09:33:06 +0000 (UTC) X-FDA: 82047540372.17.FFD8572 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 26B1F10001D for ; Thu, 25 Apr 2024 09:33:04 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YM56stPv; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714037584; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JNu0aoq/zWgG/Nd9zb1Z/YS3olMi1mIzV+mqsXaWuOs=; b=omiiQZ98Fq30LuV++M3oPFyJO6cVr7UtLrNAc8STSb8MAwHiJJJ0ZuwfB3n+7+PJ2W2Nqy Bk3s3l37kEhPdea6Ph13Z0nbkuIG4qacTIIntilCiB38ktT8Baah8MWoBUVn3mDwd+nW/O GrFyeJxIOnsfIhR5NgBPap4aWjcdNec= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714037584; a=rsa-sha256; cv=none; b=AXvZttuABQsipT9tbwPBLg5Ft/aTR5PMR4pLJdnomC5MbbvSaARVOhvkmMWmOHkZGXOjKJ oe/jfd5yyYiYy0PGIACN0UEbbYCuurPFpUq7cPUuznI4T1NpzM2QiTIdMtDQ7UeXiXfVZt 2eTA5RqicR4+P+gw6XlWHIjnPyu2PYM= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YM56stPv; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714037583; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JNu0aoq/zWgG/Nd9zb1Z/YS3olMi1mIzV+mqsXaWuOs=; b=YM56stPvv1wNfqyjes7Qngi+YOOcUg4txoSDdbDfw/sBqDF6FE8Fe6oSq+x3zoI6hr70ZF UE+YUWFzfSypE7DzhT9g8XdoflZzuLG/xiPkV8EUfHNNIBabWy8EWpC743dcjqG5JQTOPI a45KTlUQZ9mFdLI1jNcO0U2XWLgIx88= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-691-2fLZFIfQPRS3l9-MoLqNhw-1; Thu, 25 Apr 2024 05:33:01 -0400 X-MC-Unique: 2fLZFIfQPRS3l9-MoLqNhw-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-347f92ab882so553264f8f.0 for ; Thu, 25 Apr 2024 02:33:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714037580; x=1714642380; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=JNu0aoq/zWgG/Nd9zb1Z/YS3olMi1mIzV+mqsXaWuOs=; b=pylqHjwF2UeAurBHBwP4RHGY0Xa9REMEZdhtzGsTrGQt18h8NJVSJ7GEbSeNqfcHln OwreaNd8R9tyYEQaN71+rHuEgIVp88lTX8kklBWeXykmYHEICC0LS/RkDssLeYLHlpff nmhP0WPMI98QfoZ4+fwodWKeP9Cpit80SLl5+gka8bGrNGfo2bVqGu6HYqU0UpJVfdbI qO3VwuA1Nt+OkaV9lt+eisoJAEcZsdrFSEWiEg7938MHy7rz/jieh1WS6k7S5OGAiM3B +UnOTivZvhGbW7t+oDIoSX0QYaXITzYUhQJc0zPA5SyrHJW+dwEFlaMR3m1zhgh41CmL 14aA== X-Forwarded-Encrypted: i=1; AJvYcCU/UK5IhxuTL3g+jFWdrRubZjpoE1tKHbjJ5/012kcelcUVgt+BgW8ldHX7F4mZqH7sUTUovYvlZazPfnwKrD38HDs= X-Gm-Message-State: AOJu0Yxvlc0aukI8b9jG4NWEZfjVZrrvvM44zOqCxeXikiGMPj7sGFsp iJKtBkE75MRzZ6LTfrj5koTSeB9QK1FdsX58OFYaYXtdT8VTzGpjm52xHd1tTKMo1osuvISWTQw 4p6Uehs/T+tRqU7JNX5bYfy/b1RF6eq610WeSJpjW27x+jKqV X-Received: by 2002:adf:db46:0:b0:346:92d2:a496 with SMTP id f6-20020adfdb46000000b0034692d2a496mr3442149wrj.29.1714037580040; Thu, 25 Apr 2024 02:33:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFwZKD6miOpRBTRPsR5WLOeXZHItfAY+i4hAcIpYKsY+rhvr2bsn65j/ZoCxkm7hJ2s78TkPA== X-Received: by 2002:adf:db46:0:b0:346:92d2:a496 with SMTP id f6-20020adfdb46000000b0034692d2a496mr3442128wrj.29.1714037579667; Thu, 25 Apr 2024 02:32:59 -0700 (PDT) Received: from ?IPV6:2003:cb:c719:8200:487a:3426:a17e:d7b7? (p200300cbc7198200487a3426a17ed7b7.dip0.t-ipconnect.de. [2003:cb:c719:8200:487a:3426:a17e:d7b7]) by smtp.gmail.com with ESMTPSA id c10-20020adfc04a000000b00343f2cca88dsm19584158wrf.76.2024.04.25.02.32.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Apr 2024 02:32:59 -0700 (PDT) Message-ID: <25b39ce9-9631-45fd-a067-d806ff64e640@redhat.com> Date: Thu, 25 Apr 2024 11:32:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: BUG_ON() in pfn_swap_entry_to_page() To: Felix Kuehling , Alistair Popple , Matthew Wilcox Cc: Sebastian Andrzej Siewior , linux-mm@kvack.org, Andrew Morton , Thomas Gleixner References: <871qyt4g4a.fsf@nvdebian.thelocal> <87fsn8hugi.fsf@nvdebian.thelocal> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 26B1F10001D X-Rspam-User: X-Stat-Signature: gdhiwazfssynqrmki9emxmzykc8hc8as X-HE-Tag: 1714037584-667290 X-HE-Meta: U2FsdGVkX18TXt8uspzNtfXWOE7WIwDij9SyGXan5BRLCINUXj254LyPhFMePwqa9nEZ0ggJN66GG0wiAuEewiK3rqQ/AOygmDw+1BzqM/Ly2LtlCErfII7yMWMiJ0gV2WcX2w4LG5E1v6LeFr1YC4G/p0Ymz+UJzqPEVefWcKIECxmp/KbSS179FUBwtmfGG/7n6wD/t/DTm26Dp1WE9bxRReoD5eIhGzdqViXUdnWxQbpKfCENXQrdeguh8esn7eXjF//KbEjQASlb9VSSl0WXVxFKAsN5JPKxtH3MzLhw+nf8QGaBJeZlOd0tQT8og1rSGdCIcbTLrGqbXUY/7qXzL8ujmMwYVLx6HqOuZ+SWAlYWE50T7jIquAFH4tIboBxrJFdhmrBgjSlQFd+0j844HWSA4bKGvuXJ+bhpmsB7Wd3jbshTKYNvGWYcoQL1mRjGl5WOcAQ+AfmYZReA4Tqz+8E+XCaSKIPI4Xhs138RCvRYQfgCIpJB1zPpwP0qNcnwO693Nwyq32uQ+mQF9BBAwDhV2MYFOHEcvg2d86M1vZLjnEUcdeIwFqpJIYbPo92kWnhoha0kkLsux4s2TNbWsm5aonPCXH4XNTAIXpBZ8dzFj7NVmdfqqj0AsaN5HtWVr9C4EOjW5Bxj30ysbQNpR497DPuXSvQ9jNgrELlN2QWpBYdwyEX2DPvWvey1z9XZNuzpxgbV46WL2ZRIlbXxxN178i8y/4cOhsva6M4Z4XShkTFDfBQP+nVCPilNg/HyPyNWEg0lKZAJveACTXaJP5a4XQ2hOJXnEhZi/ESAFyfMPlFRJjui2gDfjV4uWmr8RhibhMqpjCHCwr/JLHzUG+KCydFsSpHoB/CXVt9vkFa4cLuYKnMWP++HDDmehO97TJaR63N2qpLa5PKcDCoTSq+NZ25sR0tyBfXCcfugK7E6QxDcuLSBl75Q74xNQl0yoLjO59KVCjm8w3j 2jTCaxaV uP5hhuNaYGy2bUPFAhpHJraSWE595Qe/2UmaVr9ZgOR1jUiCVhuo3tYigUXcb26cuY4JOyRWpOt2TebRdot9Fb43coK2qiByCgkzODAe5I/JCbJ6/aLTSWfr96AMtg+hjK2yivNz5htAExQWkJz9GufJSB5rEcCqd2nrBB1Mg3CTwq4CGEkiaNqtMrSh2rYQXsuw3Y0UviZ+C/3ToUWHZrzPhXQvfYlewSE7Q+o3ojgCWby5/GGZ8hAOSbzUL/32Cnm0W7be8myagp8oS2WahGIs5NhvbHgYWfi4FwDH4OWn12UGUXp+m6gwSeGDfoJAd0r1IAYu6Dr3bTdGEJV8Cr6HJYy5SRoA8PQk6qZFVG9+G4I9lphU4DnhZjTPGu6RLz7BUUzqo3Nbawp3DqfRWmrzQHu6KNxdfYy/eNvxDAFRBKEfEYZiH1EkJuolzL1QTkZZso1Kf1wiGXpPTwFFTbdWoPXqeuTVfme4y8yYzF4/06kM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24.04.24 21:45, Felix Kuehling wrote: > Sorry for top-posting. I'm resurrecting an old thread here because I > think I ran into the same problem with this assertion failing on Linux 6.7: > > static inline struct page *pfn_swap_entry_to_page(swp_entry_t entry) > { > struct page *p = pfn_to_page(swp_offset_pfn(entry)); > > /* > * Any use of migration entries may only occur while the > * corresponding page is locked > */ > --> BUG_ON(is_migration_entry(entry) && !PageLocked(p)); > > return p; > } > > It looks like this thread just fizzled two years ago. Did anything ever > come of this? > > Maybe I should add that I saw this in a pre-silicon test environment. > I've never seen this on real hardware. Maybe something timing-sensitive. In the past, it indicated a swp pte corruption, that would e.g., mess up the stored PFN ot the swap entry type. On which call chain do you see that? -- Cheers, David / dhildenb