linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Felix Kuehling <felix.kuehling@amd.com>,
	Alistair Popple <apopple@nvidia.com>,
	Matthew Wilcox <willy@infradead.org>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: BUG_ON() in pfn_swap_entry_to_page()
Date: Thu, 25 Apr 2024 11:32:58 +0200	[thread overview]
Message-ID: <25b39ce9-9631-45fd-a067-d806ff64e640@redhat.com> (raw)
In-Reply-To: <fcb5465f-072c-496a-b470-33d29cf44c52@amd.com>

On 24.04.24 21:45, Felix Kuehling wrote:
> Sorry for top-posting. I'm resurrecting an old thread here because I 
> think I ran into the same problem with this assertion failing on Linux 6.7:
> 
> static inline struct page *pfn_swap_entry_to_page(swp_entry_t entry)
> {
>          struct page *p = pfn_to_page(swp_offset_pfn(entry));
> 
>          /*
>           * Any use of migration entries may only occur while the
>           * corresponding page is locked
>           */
> -->     BUG_ON(is_migration_entry(entry) && !PageLocked(p));
> 
>          return p;
> }
> 
> It looks like this thread just fizzled two years ago. Did anything ever 
> come of this?
> 
> Maybe I should add that I saw this in a pre-silicon test environment. 
> I've never seen this on real hardware. Maybe something timing-sensitive.

In the past, it indicated a swp pte corruption, that would e.g., mess up 
the stored PFN ot the swap entry type.

On which call chain do you see that?

-- 
Cheers,

David / dhildenb



  reply	other threads:[~2024-04-25  9:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-22 17:25 Sebastian Andrzej Siewior
2022-03-22 17:41 ` Matthew Wilcox
2022-03-23  0:29   ` Alistair Popple
2022-03-24  3:24     ` Matthew Wilcox
2022-03-24  3:51       ` Alistair Popple
2024-04-24 19:45         ` Felix Kuehling
2024-04-25  9:32           ` David Hildenbrand [this message]
2024-04-25 14:33             ` Felix Kuehling
2024-04-26  8:49               ` David Hildenbrand
2024-04-26 14:56                 ` Felix Kuehling
2022-03-22 18:53 ` Ritesh Harjani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25b39ce9-9631-45fd-a067-d806ff64e640@redhat.com \
    --to=david@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=apopple@nvidia.com \
    --cc=bigeasy@linutronix.de \
    --cc=felix.kuehling@amd.com \
    --cc=linux-mm@kvack.org \
    --cc=tglx@linutronix.de \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox