From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4378EC3DA42 for ; Wed, 10 Jul 2024 17:29:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D814F6B009C; Wed, 10 Jul 2024 13:29:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D30AC6B009E; Wed, 10 Jul 2024 13:29:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C1F416B009F; Wed, 10 Jul 2024 13:29:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A44276B009C for ; Wed, 10 Jul 2024 13:29:44 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 49B6F401A9 for ; Wed, 10 Jul 2024 17:29:44 +0000 (UTC) X-FDA: 82324530288.18.43B52B2 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by imf12.hostedemail.com (Postfix) with ESMTP id CE38B40018 for ; Wed, 10 Jul 2024 17:29:41 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=Bj2G0UK9; spf=pass (imf12.hostedemail.com: domain of quic_jjohnson@quicinc.com designates 205.220.168.131 as permitted sender) smtp.mailfrom=quic_jjohnson@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720632565; a=rsa-sha256; cv=none; b=2aV4TLOjVR+SwfqJ3NhZTYZeOXvu/OYz+uLmzY0Fk+rcT0wisXIPM5XyFXxx3PecXDDyB0 WzBjEPAaR6skS3AkwbV1GEpmpBWxtLM2vGdH2VcGL2Lc4lS7HmfCOmd+5GmuH3Y8J6KDuV 72oPJ3SI2eHILnpvuKRVGSwwOTJXDho= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=Bj2G0UK9; spf=pass (imf12.hostedemail.com: domain of quic_jjohnson@quicinc.com designates 205.220.168.131 as permitted sender) smtp.mailfrom=quic_jjohnson@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720632565; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6Mw/t8xLpptDWSgL1nDLhnAFYxFHqHSyHbIPdNWVA84=; b=VcPd+z88youyfe0Vc/Ut8DUw38u3RTlWLJDlaTZkvHPMBqkiStk5xeB5OljNO9JxZVwWfx QWSgdJIp0P5GCvuA582QRERu+s44X2EHxXLnnpNwvq7LHQkmH9l/Ucfjmu5ifwz+jOqWB/ twgySlD7zU2YTY9FbDfly0Mfqi5q1TI= Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 46AD5ZT2022205; Wed, 10 Jul 2024 17:29:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6Mw/t8xLpptDWSgL1nDLhnAFYxFHqHSyHbIPdNWVA84=; b=Bj2G0UK9pgTKCDAQ BNaJ4RXTG2/0ISwzrTg3RJp1bNutxQAoUhQxCUOOMOXAMGDqZQq3qwWAFU9amZp7 HjGCuJxJV4mkvWl8VYXtjw/owyMsb6g5qVnSKsRTbMmXdmlVwTE2idg2L9b8ApZ9 NiILelIm1mkbITxskIeiLQNBxAp8/7lJrVnlR/nKy4CwKrpCduobZlmRqyIsmFJz /uV+sCot9P0B5nymFxvPt5HEByCUE7iNnWFhXf1dH3C3DQKYgU/WyDm3E3i8yGJ8 M02tjulIaDuL0JWqJBuLoFcIrtb9f0uMd83BpxYykWTUAYSTPinuvwkPMEHRzfsg r/eN1g== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 406y3hhn5e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 Jul 2024 17:29:37 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.17.1.19/8.17.1.19) with ESMTPS id 46AHTafI006932 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 Jul 2024 17:29:36 GMT Received: from [10.48.245.228] (10.49.16.6) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Wed, 10 Jul 2024 10:29:36 -0700 Message-ID: <2594acbf-f2d5-43fc-9967-f3660a9c2c54@quicinc.com> Date: Wed, 10 Jul 2024 10:29:35 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/page_counter: Move calculating protection values to page_counter To: Maarten Lankhorst , , , Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song CC: References: <20240703112510.36424-1-maarten.lankhorst@linux.intel.com> Content-Language: en-US From: Jeff Johnson In-Reply-To: <20240703112510.36424-1-maarten.lankhorst@linux.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.49.16.6] X-ClientProxiedBy: nalasex01c.na.qualcomm.com (10.47.97.35) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: huDRjL5LilBcFuYCdTi9px4eNmYgRlZv X-Proofpoint-GUID: huDRjL5LilBcFuYCdTi9px4eNmYgRlZv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-07-10_12,2024-07-10_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 spamscore=0 adultscore=0 mlxscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1011 mlxlogscore=999 impostorscore=0 phishscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2406140001 definitions=main-2407100122 X-Stat-Signature: e9xgfo7iaupapa7gukrkbt1tqpbiighx X-Rspamd-Queue-Id: CE38B40018 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1720632581-382537 X-HE-Meta: U2FsdGVkX1/nbAgh5jQRIBdlz/zxm+8ChhJmRj8VI1vs6fozBr9pWMXDvKF8JaMNa6eV0diloOesTBnWddJxiqpJve5SeBTQ4akTBJWVoND9S/uPbH5LmaUha0GRegfe3qG+F5AdBG4saO3/ef1aemT4bqoqzqOuahL9j6T0P0GvgIzclGIX2scQkJESTOJ5TwFhZQtC+QCmNvmzLf6xyMHAJSj+dXrfGUdDogtvluev5eNoH0EXwcEkAFT4asuVMxtiiA0tT20mCOz5+DuwRp6+Brpp7QBeOfPZHwRekSxoOGayHAG1c78gpL4NxJNncSCmiOwroCMqgfsuVcY+12Q9+80lASc8j6YxhiDQfmvgb67azD2j5UAVzu15GccsNWFUJ/hBw5Mwph4OmrDsYsRv95cjk3MHBsxsnKY8+TTeIb+CGN06ZFYfTOJ8WI/OwOw+Ubs7/alA7H78ZMzV8EWujOpv0bE6r4a5m+KuV12iXRLvcluoTgjYcc3HLTmnTh1E5Y/tUqsvg+fWyXlz9hK2ci9Ruv8B5mBfI+VN/4yVaQnHP1y5XhZeRKgiOwt7gpXL9R4eKqWYuj4rC36xQX4fzquYFfzEK05BOxFS9hlRb6WbgWhQqN89MCXKoOPGQFXruDE8Po4DOYB01TMqMcoA7pHuo2QZ06LLWShE9l/ZFkYLxlARQkmVehPcC6yLqL+BXBsQags/PJ4zzXkIbv5X9JvdxEbXoTuavpmIRKoKP547STVDmoJDDFU3A6QUVFZNSH8chVT8DAa9q9UeSb6KYrcQIwicZaaRkrFCIIOxH57WPAgt4KdgbamukTKEUYJDvYZQjwLaYL82L7cuBWxjC4EBXTkbV6I2mnjquDeaO6G3So+awPAisSZARAAZyBMzwG9z97E7Xt18MT+Ap7rA2Bd/Ekaa/meCMWbrsIAd8D9OmcuFQgojGiQYetENQ2m/DMcYKVD0eKBMWZv /Ii1bBCe 6kpaiLF4aYQmpuS0cZVSA/Af3or9bOz83nROOZsXJmvJZeHa/J/gnF2cQibv6sSCzZddkCy+0UPJ2wJ2/YNySzKpGh768IMO8Vyv/8XxsVHdZyNMyTkVLgEaHhKJDvQWX8veDyfJrHxsv5QDmDqf2bXT17qa2NKC4Q/+glLbxRszf5UBxmMTzAvw8xtagE0quaL+MdF16ApHYVuIJa7xymGbhRJVW1zVSyPkiL4XCj4kljAuiesS0SU2gY6KOa778SX6Kln5LFnSIaPfWU18cVQSwbYGFwa5Eka3d/Ey91zvzOfs46RNA9b7iS9L6CuwK1me+yNTPgCMTyQl4gYhLr6qfELhwe6C/TccycOmO39yA6kNOOK6ltBOzwRNBuhIgq9pd X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/3/2024 4:25 AM, Maarten Lankhorst wrote: > It's a lot of math, and there is nothing memcontrol specific about it. > This makes it easier to use inside of the drm cgroup controller. > > Signed-off-by: Maarten Lankhorst > Acked-by: Roman Gushchin > Acked-by: Shakeel Butt > --- ... > +/** > + * page_counter_calculate_protection - check if memory consumption is in the normal range > + * @root: the top ancestor of the sub-tree being checked > + * @memcg: the memory cgroup to check need to document @counter instead mm/page_counter.c:400: warning: Function parameter or struct member 'counter' not described in 'page_counter_calculate_protection' mm/page_counter.c:400: warning: Excess function parameter 'memcg' description in 'page_counter_calculate_protection' > + * @recursive_protection: Whether to use memory_recursiveprot behavior. > + * > + * Calculates elow/emin thresholds for given page_counter. > + * > + * WARNING: This function is not stateless! It can only be used as part > + * of a top-down tree iteration, not for isolated queries. > + */ > +void page_counter_calculate_protection(struct page_counter *root, > + struct page_counter *counter, > + bool recursive_protection) > +{