From: David Hildenbrand <david@redhat.com>
To: Hillf Danton <hdanton@sina.com>, Michal Hocko <mhocko@kernel.org>
Cc: linux-mm <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Matthew Wilcox <willy@infradead.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Shakeel Butt <shakeelb@google.com>,
Minchan Kim <minchan@kernel.org>, Mel Gorman <mgorman@suse.de>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Jan Kara <jack@suse.cz>
Subject: Re: [RFC v2] mm: add page preemption
Date: Tue, 29 Oct 2019 14:26:36 +0100 [thread overview]
Message-ID: <2586aa78-9120-cd33-7f02-2542b74a64a4@redhat.com> (raw)
In-Reply-To: <20191029123058.19060-1-hdanton@sina.com>
On 29.10.19 13:30, Hillf Danton wrote:
>
> Date: Tue, 29 Oct 2019 09:41:53 +0100 Michal Hocko wrote:
>>
>> As already raised in the review of v1. There is no real life usecase
>> described in the changelog.
>
> No feature, no user; no user, no workloads.
> No linux-6.x released, no 6.x users.
> Are you going to be one of the users of linux-6.0?
>
> Even though, I see a use case over there at
> https://lore.kernel.org/lkml/20191023120452.GN754@dhcp22.suse.cz/
>
> That thread terminated because of preemption, showing us how useful
> preemption might be in real life.
>
>> I have also expressed concerns about how
>> such a reclaim would work in the first place
>
> Based on what?
>
>> (priority inversion,
>
> No prio inversion will happen after introducing prio to global reclaim.
>
>> expensive reclaim etc.).
>
> No cost, no earn.
>
>
Side note: You should really have a look what your mail client is
messing up here. E.g., the reply from Michal correctly had
Message-ID: <20191029084153.GD31513@dhcp22.suse.cz>
References: <20191026112808.14268-1-hdanton@sina.com>
In-Reply-To: <20191026112808.14268-1-hdanton@sina.com>
Once you reply to that, you have
Message-Id: <20191029123058.19060-1-hdanton@sina.com>
In-Reply-To: <20191026112808.14268-1-hdanton@sina.com>
References:
Instead of
Message-Id: <20191029123058.19060-1-hdanton@sina.com>
In-Reply-To: <20191029084153.GD31513@dhcp22.suse.cz>
References: <20191029084153.GD31513@dhcp22.suse.cz>
Which flattens the whole thread hierarchy. Nasty. Please fix that.
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2019-10-29 13:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-26 11:28 Hillf Danton
2019-10-28 12:26 ` Kirill A. Shutemov
2019-10-28 13:55 ` Hillf Danton
2019-10-28 15:56 ` Johannes Weiner
2019-10-29 3:04 ` Hillf Danton
2019-10-29 8:41 ` Michal Hocko
2019-10-29 15:27 ` Johannes Weiner
2019-10-29 12:30 ` Hillf Danton
2019-10-29 13:26 ` David Hildenbrand [this message]
2019-10-29 13:41 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2586aa78-9120-cd33-7f02-2542b74a64a4@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=hdanton@sina.com \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@kernel.org \
--cc=minchan@kernel.org \
--cc=shakeelb@google.com \
--cc=vdavydov.dev@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox