From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E31CAC54E68 for ; Thu, 21 Mar 2024 05:40:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 510E26B0096; Thu, 21 Mar 2024 01:40:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 497196B0093; Thu, 21 Mar 2024 01:40:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3378F6B0096; Thu, 21 Mar 2024 01:40:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 133E16B008C for ; Thu, 21 Mar 2024 01:40:38 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B1D2DC1537 for ; Thu, 21 Mar 2024 05:40:37 +0000 (UTC) X-FDA: 81919946514.04.79F9357 Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by imf01.hostedemail.com (Postfix) with ESMTP id 2454F40009; Thu, 21 Mar 2024 05:40:33 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710999635; a=rsa-sha256; cv=none; b=6LbwkPD1HZZCi/nQp82FShApsk5OfQySkf7xPm+wxBlSKahLvuF0Qlv/tNf8uXgTyJw22W GIMYFDdsB5A6Ds45vLJOkVnvwDQfyXzz+0sLQpFpyC0rsyK18RnXqUGsjdF/CSRdtB3ivS SlXUVsuIQWL+4ZNE1NZ4hxmELyy6eW8= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710999635; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fiEe79ug5dt75UC2XANk2p1FKFRqoHKRlDZYnql34MI=; b=I4/TkYyJvYtOC2TXHOR+M/yzHPXy9RXiSPVy4WZa7Q9TPTo1g5oEIQDTQgwFVcDpng61xX IZmRoaTMdKUTGCJHl+5nkbrAyYsoAVruZu2Cd/kUnu4rSGsz9cITHiFYKBsV19qwjeQuM0 MSydtfEnud8TuskgS89ECkTu4Wn/jnc= Received: from mail.maildlp.com (unknown [172.19.163.44]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4V0Z405m1Lz1h2bC; Thu, 21 Mar 2024 13:37:52 +0800 (CST) Received: from dggpemm100001.china.huawei.com (unknown [7.185.36.93]) by mail.maildlp.com (Postfix) with ESMTPS id B521014013B; Thu, 21 Mar 2024 13:40:26 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 21 Mar 2024 13:40:25 +0800 Message-ID: <2584271f-a939-4929-970e-daf0ac1ca409@huawei.com> Date: Thu, 21 Mar 2024 13:40:25 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 11/11] fs: aio: add explicit check for large folio in aio_migrate_folio() Content-Language: en-US To: Matthew Wilcox CC: Andrew Morton , , Tony Luck , Naoya Horiguchi , Miaohe Lin , David Hildenbrand , Muchun Song , Benjamin LaHaise , , , , Zi Yan , Jiaqi Yan , Hugh Dickins References: <20240321032747.87694-1-wangkefeng.wang@huawei.com> <20240321032747.87694-12-wangkefeng.wang@huawei.com> From: Kefeng Wang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm100001.china.huawei.com (7.185.36.93) X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 2454F40009 X-Stat-Signature: uhtc3a33wotdsujgsbj3yrou5pybzazf X-HE-Tag: 1710999633-206731 X-HE-Meta: U2FsdGVkX1/+iVE+k/UIFSzt60gzjgw3m/KNwoFMHTvlmRx+mke+sz9UwjdF9apwinbU66QpD+nAyGKNBnJbJuhtQWKyuWsKWk650Q3OhTr9NWFLymAg5VhHOfArbqX6Up16P8jjt8btXOZpa5EegAAD8SAR1BhhZl9Aqusf+GIIs2cESDqh6xzp/qWg0NikYzqG+0SHUMvbYufRZOK/GUhDSGdVjhxg3ondjyow9NvzpgVsw7n7S4aJ+cF6Y+pRIwbjbANTJgbzxh4mHghpoeePDbHO/vdG5Pb8trSodLIEbF63Do1B2Weh3gWz1PO+ohBPaxxhrv0+U2g/U9IVwItpxeJxmhUs7w2b3KlNao9mAkupAtYJMD67pyAFsF1m51QcnVKH6N2T7NdCdsamZkTEDx8kyqW4c6ft3QA3hevxo9pZlEuhssM2ZY3HEWBbLxyW5Q7tHJRqEzuffmuHqv2Eam2q9EIKQ2VFqEjtlftYoVXCSCT8H+jtibRrJ0mJtsgMULGLcnn4XEA4u1lbUNnAFy61VQ8juo6dksvHsfGSQ94gazT/Ei16THQxL6Hq4gVGSLxXt4c+PqiURE2/KbDWA4QVYdwJn4VNwzhtgr3DrZ789+37Sz2ZMa8h8MVhkb7Xo15LGOgUkhrJ16emPCK8uUkMo6wDij4YWNvExF5LqyZJ7mUeDFOgW8GWHOMKbVVlFEJ94659o5Hrr8DZ1AOrMvYR6u+pBCg4UnknnVap0bW/Z44RPJdQgaG0CCdtAC1cgKZYeWPElmlx98a5ZkdGo/2MSPDbBTkFo6F3zt2FooV+BDjlS0+zs1sfmAYzWcCnSRW022E5dFGMd7zqBpfpuOED8EHU5E2P12kEj2YOpBtuSDqZ/QBX9XWKCfZFndmmyv4/n7g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/3/21 11:35, Matthew Wilcox wrote: > On Thu, Mar 21, 2024 at 11:27:47AM +0800, Kefeng Wang wrote: >> Since large folio copy could spend lots of time and it is involved with >> a cond_resched(), the aio couldn't support migrate large folio as it takes >> a spin lock when folio copy, add explicit check for large folio and return >> err directly. > > This is unnecessary. aio only allocates order-0 folios (it uses > find_or_create_page() to do it). Yes, only order-0 now, I will drop it. > > If you want to take on converting aio to use folios instead of pages, > that'd be a worthwhile project. OK, will try, thanks for your review. >