From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1430ECAAA1 for ; Mon, 31 Oct 2022 15:11:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F3A86B0078; Mon, 31 Oct 2022 11:11:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A36D6B007B; Mon, 31 Oct 2022 11:11:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26C236B007D; Mon, 31 Oct 2022 11:11:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 022596B0078 for ; Mon, 31 Oct 2022 11:11:44 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A50D51A085B for ; Mon, 31 Oct 2022 15:11:44 +0000 (UTC) X-FDA: 80081584128.09.FBE4264 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 3CA9940048 for ; Mon, 31 Oct 2022 15:11:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667229102; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3i4O1OOlu+3cslGOPuuct7EW6mOAN9LMnhUF+hNbZg0=; b=MwJYxe/7qYLkD6VZhtAoI4NQkebeBuOPiFmdC0BiZnStPNL452kt9ILJMnDOfRCIx+Kj8r BP+v+wU4o1RqbgE2EJ1Z7uiu8eIgJQ88t+1Z6MeMi2M49qcNGHo8XiJexEil6YHXV2iod9 Mj120b4rg15uqKFJKaYAF6vGV9aJSlI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-137-lN4A6MP6PUuHc3ZDlu-yIg-1; Mon, 31 Oct 2022 11:11:41 -0400 X-MC-Unique: lN4A6MP6PUuHc3ZDlu-yIg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 76FDA101A528; Mon, 31 Oct 2022 15:11:40 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.73]) by smtp.corp.redhat.com (Postfix) with ESMTP id 46119C15BA4; Mon, 31 Oct 2022 15:11:39 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20221028151526.319681-2-willy@infradead.org> References: <20221028151526.319681-2-willy@infradead.org> <20221028151526.319681-1-willy@infradead.org> To: "Matthew Wilcox (Oracle)" Cc: dhowells@redhat.com, linux-mm@kvack.org, Uladzislau Rezki , Dave Chinner , linux-fsdevel@vger.kernel.org, Thomas Gleixner , Ira Weiny , "Fabio M. De Francesco" , Luis Chamberlain Subject: Re: [PATCH 1/1] mm: Add folio_map_local() MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2557441.1667229098.1@warthog.procyon.org.uk> Date: Mon, 31 Oct 2022 15:11:38 +0000 Message-ID: <2557442.1667229098@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667229103; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3i4O1OOlu+3cslGOPuuct7EW6mOAN9LMnhUF+hNbZg0=; b=ihGVgxgMTeCkTKuR5Ym4nEPpwyJotrNp7eLjcBkJMrqC89gcAU9Gm8qpaNEnk7kXWEmR3x 9LHb5PT04aq3guVwWXgFx3yIyNIhsHPgLH+vHzXqHx7EKrdyokH298RL73oIP/751lQwZE pCEFSBZjALtQ2W76X8IMoYBWXzlB9nY= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="MwJYxe/7"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667229103; a=rsa-sha256; cv=none; b=PRQrdK9Nl5oMcOS7JTo/X4gzfvWxJwn2gYOauz//6nseBUF4di0wTNtiKa8/BtiuZHIYV2 GVPdHK0LiFWiyKwIolgisatZOVa40KY273NcaZ0H2fRUU8J4ywCW/BObmPZQYAaVrrDqEc v9d9cKZhyXZkh1g5B2Deudm5fLtYIYE= X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 3CA9940048 X-Rspam-User: Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="MwJYxe/7"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com X-Stat-Signature: go9g7d4f6qgrwaer8y3975498tjc4r8n X-HE-Tag: 1667229103-489293 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Matthew Wilcox (Oracle) wrote: > +static inline __must_check void *folio_map_local(struct folio *folio) > +{ > + might_alloc(GFP_KERNEL); > + > + if (!IS_ENABLED(CONFIG_HIGHMEM)) > + return folio_address(folio); Can you make the might_alloc() contingent on CONFIG_HIGHMEM=y? David