From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 711A1C27C79 for ; Thu, 20 Jun 2024 19:38:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D50458D00DC; Thu, 20 Jun 2024 15:38:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CDB378D00DB; Thu, 20 Jun 2024 15:38:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB53B8D00DC; Thu, 20 Jun 2024 15:38:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7D58C8D00DB for ; Thu, 20 Jun 2024 15:38:31 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1A48E1C058C for ; Thu, 20 Jun 2024 19:38:31 +0000 (UTC) X-FDA: 82252278822.11.569C3DF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf11.hostedemail.com (Postfix) with ESMTP id B9FC940021 for ; Thu, 20 Jun 2024 19:38:27 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IhMR0crw; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718912298; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yulzMQq1lZ5m4LlymPpkGq4mPTsA6DoLYfWOW3AvV8k=; b=aYhlFBjoIyhL3zg0XVAJ2NOUztUcuMRRtKrhsVDNrTKOXIMaaPReqFBzRCnlmyuuT7bsWv wgft1a6mzIFe/TSGARiYB4tyUtI8nvBvAZm9bI0GV/5Hawu2k/9fVrVacnHf/G/iLT9F0H nWK8GfM3RYqN9xZgSyAcQAFHpD3kgp8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718912298; a=rsa-sha256; cv=none; b=02YAJDmSuRkBFJnIpCezKKjWG29Slr++pJccnEaR+pKJOwD2cbrLhYSUyqol3GJV48wtA8 RGH2peGCdJnE8tnIrXgEG6e14U4ZU/PYX6Xpy+NpHLzQnjri6211b0RJRYEcXYH/gtB+qv cTxVJLgibp8NpuKaAhCtcXqiXt16AC8= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IhMR0crw; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718912307; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=yulzMQq1lZ5m4LlymPpkGq4mPTsA6DoLYfWOW3AvV8k=; b=IhMR0crwC5KJPgmZB6KPe+9uy8tUyVpykv7aQCROaGn+XWb/D/stv4H12CLT2sBTMkS9lh sp8a0ftG9S4Pin2fkps809kVO0mbTI31lnd6YHxZ+BwcGza1vR2CwXyfzLyGV9L8HiEsD9 ns2iH8HFYsk6j9igmwVNBMR8ZbQdGF8= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-160-HMavsFtGPU-243i7mmF00Q-1; Thu, 20 Jun 2024 15:38:24 -0400 X-MC-Unique: HMavsFtGPU-243i7mmF00Q-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3644be85453so656315f8f.0 for ; Thu, 20 Jun 2024 12:38:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718912303; x=1719517103; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=yulzMQq1lZ5m4LlymPpkGq4mPTsA6DoLYfWOW3AvV8k=; b=jAHM9UpDVH7wWhENwGJkAX2TtmTQewtCiB0G8mhvK8UAn+P1exVRbySO+oScjFmbAH pKbQU/XlAns+Qt/jtrVC0ejsZMaw1q1BV/zsWnXSyWbBJXgLFe5oVbZk8V4Jhh3B56dL JySEq0sJTn5mpKYpVnfmBEVTca1GhXazE6C5C+D/QOY0FtjnuKg7e7sGNcYd7itDtwFa 26bb4r4HwC75H81EEdeV29K81QAs4BIl3GbqE4+lAqo5Y6NHB3Ao8/UpVZjN1JXYRghK G4tAGNWHWXowESXO9HGfI88KXczyAyaLJkQ545YTsAAo5f5XOvUU42z1xKEgGf/tMKHp zN4g== X-Forwarded-Encrypted: i=1; AJvYcCVSFg36VqW/hy0lABjxVqf7D0V5/9D1ggGNG3hy4ZSGD70+nr8strcfXcN+VQUqnZEVgZ3sis+hk4LobrBw81GV8Lw= X-Gm-Message-State: AOJu0YyHcPULUH5HJ3QR/GUeCqU3w3tH+sR4cQMrneJHjox2XvBcXXbf F35ntLtxzj5n+MLttA2GV+i8cIIqoTzUoaTIbloD5EGbHi8j/fFhrUxr8TeGc/cwcb8AJ3aMBxg mIYXKz52HCKmsPh+ny0+2qPDbkv+GQTeOm1pnK5jBRfHCT6G+vCtJIUIh X-Received: by 2002:a05:6000:d88:b0:360:79a2:af1 with SMTP id ffacd0b85a97d-363175b83abmr4779337f8f.25.1718912303681; Thu, 20 Jun 2024 12:38:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHq2lFU7gEnrSryIJeHRcJMEWNbQLOju8ydZA8LFbhDlTy47dnkho8Dbc3uZjqCn50RbS9/Sw== X-Received: by 2002:a05:6000:d88:b0:360:79a2:af1 with SMTP id ffacd0b85a97d-363175b83abmr4779329f8f.25.1718912303266; Thu, 20 Jun 2024 12:38:23 -0700 (PDT) Received: from ?IPV6:2003:cb:c719:5b00:61af:900f:3aef:3af3? (p200300cbc7195b0061af900f3aef3af3.dip0.t-ipconnect.de. [2003:cb:c719:5b00:61af:900f:3aef:3af3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-362cd0d79fdsm6690117f8f.77.2024.06.20.12.38.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Jun 2024 12:38:22 -0700 (PDT) Message-ID: <254bf3e0-0056-4593-94ee-8431a1bfc430@redhat.com> Date: Thu, 20 Jun 2024 21:38:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm: ksm: Consider the number of ksm_mm_slot in the general_profit calculation To: Sung-hun Kim , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: sungguk.na@samsung.com, sw0312.kim@samsung.com, sebuns@gmail.com References: <20240620043914.249768-1-sfoon.kim@samsung.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240620043914.249768-1-sfoon.kim@samsung.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: o3n6t8fy81tzj9gd55po9uy7ibec7jpf X-Rspamd-Queue-Id: B9FC940021 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1718912307-397755 X-HE-Meta: U2FsdGVkX1/AOLUGNFpns5ZnFIAoIMQDopWAeJyPLbkzfgaXIEhHkutGMntoQ13vClgECVUR6R7QT610VByl9Zrteb3vGtbf1PWLL1L4a9cSpvWv0vNUcycEcT0++RIMtiMHPs0wi2N60KWpP3HpuxOMy6GHyB2itgE0J5JOjvyzciq4ew0qluesTOyiQR/xOy4PtdK5p3Dtm8zz62BfMCA+vhnr1WSsVL8uVy7n+cGYHXNo2/4YSuQ64DmxU6YVAdrTjpOe5kuxDsivt5c1EnnQVG4rV0IAoSrdXuKHlcCdzTm9DqX6TWetiIMhYxmoTIFjsT7IKnz2bv9T9hMoQo0KZqhtdJcOq6HH05F1O8DZliXG8ieZz0d38yKxMCw7eLjFIm28ELHNMzstG+CGV4+kfEIf7xK3YjrL5ofeo81Ub07g7f1pF19tHrBbf5PCwrDskuku08JN2htCMepBeOos9mMrmtxXjdvCjNXXv4+O6VDKxGBuQyVs8VG/zsCTi+Oq4HeZymwvsQAl+b4LVs7ftoFjbEsQq5kYXA1b3sw93QXjxhk8jeO2i+Bbim1Yya3wdeC6Kh/TENzqpofJcl4T7fDNZr4B5YQh3GoNFO18dJlRI6fzTO4r2+y69VpWYlWK/kPPSKrTVYwDju0Am1VFeQ89qvEoT6DHPk/I6rtFfW879jzktQfphcYBDotd2vpMajeDU3PLvvDIJGkHdtiwpzlGEpoGjkC4RVFb4TJcJeAOsyxazahbK1JSovc7uoEaWQ/3MKNUM6sd3CtX2LdzhpdeY2GYrXNJDApvcuZdO58H59B20V8NXyCMMBVaHLM6EH6HnMGvLHQRq42DeJQ9gB1braSEOJDw6RY1YdNly2msxLmEyI7Kym/cmZ7oGdER6ON4g3SOr2HXnz2dZ1hgNjRWlMcdKdRQe+tMEWwKKKCM+cneufZB1GPCfQxE1BPu/Aae27zGB7i2oO1 JHoYpCzT cgE0TJ7TBP9oPaWt2+Tyq1c+EtFhIK/ejxZWjppYLwioHZIwb5hmhq0OWK6nxiWuaBEn4mwgxiLWNFH/RfDcLNTTdKDAA9ZWwx0GDajfm7FyYS9iUswhJ6++lDyoZa+UUyuAsxzT3VXZpw2CYWaGkSQ9mjggHpVowZSylJyV+g0uMwbgT3JPLXDgdpg47CFVEF1Q/mpfWoo5uN2EX5bdFZ5KW2+OA5BN6/K9qL9GER165z/zbKuhTlAzyczdNU/zN1r6p7RgT7MMjsMzAfeOsyYFINbo+ujDU9t771xdQEsYTXz1d2Ptc7o6uUxhNfinRMGbMB5mZCfh6zK/pcrYJ7bPNZhQOV+TY3wrhZNjtJHp7WgSzg8z8jBqDp8g+QlhHcP2f/ytyG1quUTaXX+ptBJacgYsBIkB6uqV1bh2Sk8Ipdj+REaJDZPfqSb/c9Gb7MLf5CzvcNwLQuxKl45q+L11TNquV1guih7N0kvELVHUoBWxrhOPCougxZvjy/RW/Gbhl9MHxTvSjsTAJhvUdgYIbkOvnAkJu/jGZ09hb56q1HlmeYwqUqBLzO8AYV1H7aL9t0Neoo6W07p83HcSKZEQXAw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20.06.24 06:39, Sung-hun Kim wrote: > The current version of KSM does not take into account the number of > used ksm_mm_slot. Therefore, when users want to obtain profits of > KSM, KSM omits the memory used for allocating ksm_mm_slots. > > This patch introduces a new variable to keep track of the number of > allocated ksm_mm_slots. By doing so, KSM will be able to provide a > more accurate number of the gains made. If you take a look at the calculation explained in Documentation/admin-guide/mm/ksm.rst, we only care about rmap_items, which can grow rather substantially in size. We also don't consider other metadata, such as the size of the stable nodes etc. So why should the ksm_mm_slots matter that much that we should track them and account them? Any real life examples where this is relevant / a problem. > > Signed-off-by: Sung-hun Kim > --- > Changelog in V2: > - Add an MMF_VM_MERGEABLE flag check in ksm_process_profit for > untracked processes > --- > mm/ksm.c | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git a/mm/ksm.c b/mm/ksm.c > index 34c4820e0d3d..c8ced991ccda 100644 > --- a/mm/ksm.c > +++ b/mm/ksm.c > @@ -267,6 +267,9 @@ static unsigned long ksm_pages_unshared; > /* The number of rmap_items in use: to calculate pages_volatile */ > static unsigned long ksm_rmap_items; > > +/* The number of ksm_mm_slot in use */ > +static atomic_long_t ksm_mm_slots = ATOMIC_LONG_INIT(0); > + > /* The number of stable_node chains */ > static unsigned long ksm_stable_node_chains; > > @@ -1245,6 +1248,7 @@ static int unmerge_and_remove_all_rmap_items(void) > spin_unlock(&ksm_mmlist_lock); > > mm_slot_free(mm_slot_cache, mm_slot); > + atomic_long_dec(&ksm_mm_slots); > clear_bit(MMF_VM_MERGEABLE, &mm->flags); > clear_bit(MMF_VM_MERGE_ANY, &mm->flags); > mmdrop(mm); > @@ -2717,6 +2721,7 @@ static struct ksm_rmap_item *scan_get_next_rmap_item(struct page **page) > spin_unlock(&ksm_mmlist_lock); > > mm_slot_free(mm_slot_cache, mm_slot); > + atomic_long_dec(&ksm_mm_slots); > clear_bit(MMF_VM_MERGEABLE, &mm->flags); > clear_bit(MMF_VM_MERGE_ANY, &mm->flags); > mmap_read_unlock(mm); > @@ -3000,6 +3005,7 @@ int __ksm_enter(struct mm_struct *mm) > list_add_tail(&slot->mm_node, &ksm_scan.mm_slot->slot.mm_node); > spin_unlock(&ksm_mmlist_lock); > > + atomic_long_inc(&ksm_mm_slots); > set_bit(MMF_VM_MERGEABLE, &mm->flags); > mmgrab(mm); > > @@ -3042,6 +3048,7 @@ void __ksm_exit(struct mm_struct *mm) > > if (easy_to_free) { > mm_slot_free(mm_slot_cache, mm_slot); > + atomic_long_dec(&ksm_mm_slots); > clear_bit(MMF_VM_MERGE_ANY, &mm->flags); > clear_bit(MMF_VM_MERGEABLE, &mm->flags); > mmdrop(mm); > @@ -3374,7 +3381,8 @@ static void wait_while_offlining(void) > long ksm_process_profit(struct mm_struct *mm) > { > return (long)(mm->ksm_merging_pages + mm_ksm_zero_pages(mm)) * PAGE_SIZE - > - mm->ksm_rmap_items * sizeof(struct ksm_rmap_item); > + mm->ksm_rmap_items * sizeof(struct ksm_rmap_item) - > + (test_bit(MMF_VM_MERGEABLE, &mm->flags) ? sizeof(struct ksm_mm_slot) : 0); > } > #endif /* CONFIG_PROC_FS */ > > @@ -3672,7 +3680,8 @@ static ssize_t general_profit_show(struct kobject *kobj, > long general_profit; > > general_profit = (ksm_pages_sharing + atomic_long_read(&ksm_zero_pages)) * PAGE_SIZE - > - ksm_rmap_items * sizeof(struct ksm_rmap_item); > + ksm_rmap_items * sizeof(struct ksm_rmap_item) - > + atomic_long_read(&ksm_mm_slots) * sizeof(struct ksm_mm_slot); > > return sysfs_emit(buf, "%ld\n", general_profit); > } -- Cheers, David / dhildenb