From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3D9EC77B61 for ; Sun, 16 Apr 2023 15:31:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 471286B0075; Sun, 16 Apr 2023 11:31:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F9BC6B0078; Sun, 16 Apr 2023 11:31:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 299EB6B007B; Sun, 16 Apr 2023 11:31:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1646C6B0075 for ; Sun, 16 Apr 2023 11:31:39 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D59091A0179 for ; Sun, 16 Apr 2023 15:31:38 +0000 (UTC) X-FDA: 80687643876.27.25AF03A Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf09.hostedemail.com (Postfix) with ESMTP id BEA10140014 for ; Sun, 16 Apr 2023 15:31:36 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=n+as61N+; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="QIK/QEtI"; spf=pass (imf09.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681659097; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+ZJdDeYoccvK0HkfZcO7TKPtQnPVDW+juR9W+3yn6l0=; b=fjO7s9DWiiXuFUTnKoFcMLd9FaYKELa2MCosd9PcEXGKLu8D91CIx+SMh/uzIyR8/ysFv+ MHLEL4upH1RcLfb67IyTZqnpi1sBkshIelt644HSb7Vhzf0xYtji1NbnuMc2oRsKn//gLt vQnGLCNMz5aeDIQEi7vRreSjMoaMc1U= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=n+as61N+; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="QIK/QEtI"; spf=pass (imf09.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681659097; a=rsa-sha256; cv=none; b=gyeTpL2zqIpZLE4NNIinK4hYHsr9J0920AD2LJ3sPMxNXKlRpgiNAcn8o72YKAwIe8+wqS nw6IBpZArZVG8V4k98v4RIZlSoANzlxdWY2bmT9Tr96qTUKzKPJIC/8io7YMFInY7xOMC2 ePreriVLf1HkqKgCj+nwS7rI2XgeoJM= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id F354421A46; Sun, 16 Apr 2023 15:31:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1681659095; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+ZJdDeYoccvK0HkfZcO7TKPtQnPVDW+juR9W+3yn6l0=; b=n+as61N+wacLx7P05kktsBpbfDQKvK0c2YJIa4e7efa5bhuUcuNv2Eck0e1JSvbyBmST6+ X5ABuiopqzgXJFG0y4FU4VX7va6HyqbaZrZlbqx/EBn+v8yWZgOq4wsyEp63AknzstmGFQ Gcq1c131g9PYxmdHk3j1udUYR6x8thk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1681659095; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+ZJdDeYoccvK0HkfZcO7TKPtQnPVDW+juR9W+3yn6l0=; b=QIK/QEtIhWQYMGksEFEEVH7IUrM7gvsqnBDzRxMb07FBHfDCF5iAGWb738lJ/gi6wKClqr /8W7zMaQMQepQ0CA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E3DF713498; Sun, 16 Apr 2023 15:31:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id nCJgN9YUPGTtbAAAMHmgww (envelope-from ); Sun, 16 Apr 2023 15:31:34 +0000 MIME-Version: 1.0 Date: Sun, 16 Apr 2023 17:31:34 +0200 From: Oscar Salvador To: Mel Gorman Cc: Andrew Morton , Vlastimil Babka , Michal Hocko , Oscar Salvador , Yuanxi Liu , David Hildenbrand , Matthew Wilcox , Linux-MM , LKML Subject: Re: [PATCH] mm: page_alloc: Skip regions with hugetlbfs pages when allocating 1G pages In-Reply-To: <20230414141429.pwgieuwluxwez3rj@techsingularity.net> References: <20230414141429.pwgieuwluxwez3rj@techsingularity.net> User-Agent: Roundcube Webmail Message-ID: <253c6362834bf3c9deea94cfc7741920@suse.de> X-Sender: osalvador@suse.de Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: BEA10140014 X-Rspam-User: X-Stat-Signature: 7h83bq7arythawzdtjgfd55hdnpkwguh X-HE-Tag: 1681659096-317943 X-HE-Meta: U2FsdGVkX19GCUYlenjqFr6cRMSOVgO0qLEibkMcoYJa0zpsultBCZU2cdnMkdGfavYzRmhwqnsvuneh3rH07e0bQjUs1uLwGvMw/v9QyEwmKp/4yyViF70E7Rs6nsOLYG0m4YAHy9LpPOoZ48mDYsFszgp+gWuoXBeg1dv6LyNfKHBmqgyYCvnWv95AnGitI0xH+cKBy10d02WsE65NkeVdAsIah5s4wd90WW7bvDnFfxNS50yUenZ9/r/KDN8x9G6pbveS1wS1xe2atj2TWd06YpWVsOFrhSnDai4ZlMWPgTfoyMCufeksa1qnohN3Eci81lQlQ4I54T2DWV2p6YC6AkRTuGp0DKii36VNobauPb5kQtvodcUGuha/tW7YDY6dfi+8+btGPFOEc4KYcnsdufAWjjQGLhMxvMdVqfqpel7lOY5ny6gkMyM3nhoBT96aCtmFtcxzKahqIEJeSYtEX8WXsJMS7SyuQqTFOhZfWiA4y+rCmdwuyArz4Rism5r0yC9uLvHkQBCZmm0RmwUp6PPVm6+jlJ3EPYabky9Cd1IJo1yLoDZmlxZJqcVNAa9fHH58BHam5hJnbkWWfGcQCErI1VHm9qYIEBZV5094JXLfBJJrKg1Hh3Zl1AVg6yE7pz8ipcs2eDhu3yQRVUfZ4Fqa/R6ZjNyeMwbiAOjPydOUUWWgbBs12w4Tr0/ucd/169N3bIWtWQa8PgAx1WBHmagM9RVeoVBh/62cVjVosynLdXPNN41ZmetdMNELO0Yt5E767LyoFENB1NZC+LuY7vd4c/ZVKsxmB6r6bl/MNBbw2Z2KXbqjwjESBmYKBdvi9KQKKM+9ZTjgvIwDNn5NWI+Nxkggzwh8ebN8dcGxdLFh5nrrNulyIMYQv/PRSlDRrPceHPYd0DgjBbjAY8jw6VSf86Ro02Sy3pK2HhJz9s1kt4SM1OUWG16cIHWnzSb1HXhC+WbAj3BKm24 2EdtWL1y uEvZjy44ezVax+S9U3liYRk5aeKRZA+XABeKuXMGX3SaKKY0taRdmjtEOriuHEf8vmg8kE38iFs+wQasjvpF0/eg2p1Vt5J0IELJOM5a9UcxXo0PETXHNQPr5NgvocuiGf6KG1G6/wmDBAyjfyyv9xyVgD47vK3FpZxFP5HoFyOdQaRu+Kir84RFFGhWAWo7QinYx32osRUrEfgdOVaFe8U8+058ArOZ5V34BvhyIQbPDoSI2WO6AQJp0S6XpJaXRz9PTPppdmsl6RXteQxsRc1BCmBDSYGAHbfI21pYsEjHE9dWvdUzE4BhkInCEIYr5JDeYgKtB8M9MUaHXfJpYeZ3urGLMvQmb6qabosDTtH+702DVUSNQO6WYyv2Y8eNsNsnCr3mbl2t7DYqvgXqTmLseZOF6BjiJQ6QSUgD0DCdRWXwpS8ybomoEVXIt036dh7U75laUqAf6Rm8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023-04-14 16:14, Mel Gorman wrote: > A bug was reported by Yuanxi Liu where allocating 1G pages at runtime > is > taking an excessive amount of time for large amounts of memory. Further > testing allocating huge pages that the cost is linear i.e. if > allocating > 1G pages in batches of 10 then the time to allocate nr_hugepages from > 10->20->30->etc increases linearly even though 10 pages are allocated > at > each step. Profiles indicated that much of the time is spent checking > the > validity within already existing huge pages and then attempting a > migration > that fails after isolating the range, draining pages and a whole lot of > other useless work. > > Commit eb14d4eefdc4 ("mm,page_alloc: drop unnecessary checks from > pfn_range_valid_contig") removed two checks, one which ignored huge > pages > for contiguous allocations as huge pages can sometimes migrate. While > there may be value on migrating a 2M page to satisfy a 1G allocation, > it's > potentially expensive if the 1G allocation fails and it's pointless to > try moving a 1G page for a new 1G allocation or scan the tail pages for > valid PFNs. > > Reintroduce the PageHuge check and assume any contiguous region with > hugetlbfs pages is unsuitable for a new 1G allocation. > > The hpagealloc test allocates huge pages in batches and reports the > average latency per page over time. This test happens just after boot > when > fragmentation is not an issue. Units are in milliseconds. > ... > > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=217022 > Fixes: eb14d4eefdc4 ("mm,page_alloc: drop unnecessary checks from > pfn_range_valid_contig") > Reported-by: Yuanxi Liu > Signed-off-by: Mel Gorman Reviewed-by: Oscar Salvador Thanks Mel! -- Oscar Salvador SUSE Labs