From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50DD4CDB474 for ; Tue, 17 Oct 2023 07:35:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E63DA8D00F5; Tue, 17 Oct 2023 03:35:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E10E78D0038; Tue, 17 Oct 2023 03:35:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CB22C8D00F5; Tue, 17 Oct 2023 03:35:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BBFB58D0038 for ; Tue, 17 Oct 2023 03:35:49 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8806340F14 for ; Tue, 17 Oct 2023 07:35:49 +0000 (UTC) X-FDA: 81354144018.25.A0F7C2D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 4411D20016 for ; Tue, 17 Oct 2023 07:35:47 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aWnlBKV0; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697528147; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=H7VgbdqZ288kTx23taqTaH4Txq6j7T4nZ8BSevvLZl4=; b=vfGXQpIMeCKwLymHStof8FeOBwrGeRA/9KpKK7bbvpTTKfkzNOZw1HoV1Csfb0otMztItL VPXdy7e0RloIZarK73dcofhZRMTEWxTsES/CLYXpN2t+ak0ov3WEH28uRCH62VIsSxOWUG 10W2vOoIoN2hrDejDZJvlz6ygP/HRtY= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aWnlBKV0; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697528147; a=rsa-sha256; cv=none; b=78ZU5WYSezqLFwQY3BTfpoxz/lePCr3FOyRHS6X2OBBJR9xhRuPnrkW3bBYpCVbP+tgH+W WSXH/uzSBiVm0JQwtepf0kYBJwkabJ6KAWysqSSFVvEniq6eDU8qWFnIB/280Ocxx0fbDg Vk9+vBohTRl0Vb88Xab9fqdWcXCWCII= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697528146; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=H7VgbdqZ288kTx23taqTaH4Txq6j7T4nZ8BSevvLZl4=; b=aWnlBKV0LY5W1Iv5kuygdFyXB/rL7mVXSayUiVB2r48euNRIDXTInE4qqPHRHKgRryu4Ae tpjE++UyHk+L5YnB45YMwJKdHgU7HxPOmHtNfh7xm4VXcV4AiJ8iE7b0zZvw1luGvOv/VX 0TNegGSNiGt1Oa3jc23xoqggdAhx+K0= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-651-pg54OYLRO1aDWdvSTubuDQ-1; Tue, 17 Oct 2023 03:35:43 -0400 X-MC-Unique: pg54OYLRO1aDWdvSTubuDQ-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-406de77fb85so35580945e9.0 for ; Tue, 17 Oct 2023 00:35:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697528142; x=1698132942; h=content-transfer-encoding:in-reply-to:organization:autocrypt :references:cc:to:from:content-language:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=H7VgbdqZ288kTx23taqTaH4Txq6j7T4nZ8BSevvLZl4=; b=Iw1BNPnWz4KVJ//BeXbquZICjW/nwJtzueGoBQKWxbkLMY0cgPBcPPWtJdqHqEbqv7 zJ7wRrnSk2PJ7x3//RqJO3j8MOncK4GcRQBEMS5gZ9bxxna0iYEM6kvCScX0hydR2gPs acP7geCXIzKO2K2uLwapFjtfSgrHbyiIYxTW4Jh435g74dP6W9EnIULEhj4G6pvB6MKb ySBStpNFXXuqchtF5FWZikqTLRhCrI5yY+0Xm3FRJCsqtq9iBnTrWHADhjHw7BxUgKBr zupoHEzjO5nEWI8K7KVbcvU4IDi2UrdnO4/NmBEB2L5v1MiIbDjHwTz/CJaLN4+5m7vZ 1nLg== X-Gm-Message-State: AOJu0Yx6sfQel4OQyacnTTSGTPZ7QhMjMJtmi8AQ2y+v+z/8kcEj79Wq xSBAL5GmXY5Go/amhTo6f65Gdeboe3K7ZzY6waqmy6f5F8gAI9eVs5acWeekctReU8ZM3lWsrGq 1JIhigWvFhAY= X-Received: by 2002:a5d:4c51:0:b0:32d:885f:3f8d with SMTP id n17-20020a5d4c51000000b0032d885f3f8dmr1236768wrt.52.1697528142074; Tue, 17 Oct 2023 00:35:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHXEXN+fqF5yoyXpeaHaRZq1k0boWH0eWo/ahLiDlslAr2mtSjBgzk1PZ2/031EddJIipjMIg== X-Received: by 2002:a5d:4c51:0:b0:32d:885f:3f8d with SMTP id n17-20020a5d4c51000000b0032d885f3f8dmr1236753wrt.52.1697528141669; Tue, 17 Oct 2023 00:35:41 -0700 (PDT) Received: from ?IPV6:2003:cb:c743:5100:93b1:f654:ad11:cd81? (p200300cbc743510093b1f654ad11cd81.dip0.t-ipconnect.de. [2003:cb:c743:5100:93b1:f654:ad11:cd81]) by smtp.gmail.com with ESMTPSA id g15-20020adff3cf000000b003296b488961sm1030327wrp.31.2023.10.17.00.35.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Oct 2023 00:35:40 -0700 (PDT) Message-ID: <251f7bdd-f431-4006-a560-3e208cd6f1d5@redhat.com> Date: Tue, 17 Oct 2023 09:35:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86/mm: drop 4MB restriction on minimal NUMA node size From: David Hildenbrand To: Mike Rapoport , x86@kernel.org Cc: Andrew Morton , Andy Lutomirski , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Ingo Molnar , Michal Hocko , Peter Zijlstra , Qi Zheng , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20231017062215.171670-1-rppt@kernel.org> <4207feb8-be8c-4d49-b880-31366c0414cb@redhat.com> Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <4207feb8-be8c-4d49-b880-31366c0414cb@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: esn9ono153b9zws6sghchc8zr8hyxkhc X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 4411D20016 X-HE-Tag: 1697528147-514828 X-HE-Meta: U2FsdGVkX1+igyIeeixULQMd1D81w/i0K7rAH2nK7bEaiHHoTi4U0xiBL9TeMD5wtscaIqwfQ+3r3no/YbPzoXUiIdlSpr06oh84U9HyO5B3Ec94xNKAnmNNxfWgxXwTI2d+hqMrdTJ3CUlvfNj3F6GTD+pxqt5tn9l8MMM4zJGv5lBZFq6DXNGd4YaycJO9kCT3KzigXix140ASn/ltzOgN+QL1H9SEIn5ZdhmSY3jqnP1sBj+DFUyE0ayhMnoSb2Aj0q4vCi/o9lwVHMu5HHIG/m3ly7gCYTYuJ6gO6kAC06uvBXlILrnv5qn5U9NyfxngOZW5MmzFrR6jVENxIhUYNAKU45Q9kZm+4aWlzYC3NMC8fYZZLBNKfKTlkg05ctuWDD2ArcB9ns4BY0xwp2m11fEjpoETXWaUitMSjxM2f+GWBAIyeJzoIO0Z6icfrehrJKRqH2cuJJquuTUoREJyH2rn37O5syqXwj+IjR1Ux7WkcQ2TnQjieS5SJvZ3HTEKz60/YZLbQ8SC8YgjVAi8ywZyuzzEQIzlxWQfVPonzqcLz6naxYHghzYQNoht0sB5bvCCvNpk8fYwbQr+AE6bKkvHaAHxWVA8822jke2PDI+CuL30CzgmDXVx2QutrPLnJ3pEjkolVoYd2i3M2Tf/oX5TTuWieB7aw0afTQW7mnzcEw/bltzQfk9eWYFIN3Km4xEGM5oRLkXFUEhnMH71LEI1jvZ4pyUbx3xAZGk4mo7641qI8lDsP+gcQpsG95XUQvHxtrBtzakHCsBtx6nn4hvfjQ6hZE7+Xob//OzXt2P+45v2p6MPve6rdJX0ONuxuiXiZ37SJAYNKulepz/2DsAeU+lL7qIfG/buOzPf8LYdqyCXM4rPNuICsYDLUah7dr1+HX2GGYL+X7FPY8Jcb8h1l+yYOfHO3Jl1Z9e9h4iAlkyZbkU7ORrvfCf7wsm9343IQYvoW/e6Nh2 ZBXWVvxi 9vgjewWui4Z5fj3aI5fhAdMM6H82zmvO1KpMoFaOWXfUI3+YAk2Q3p9/N7jHuLx7E77pEOLRPSWLyRvEJdM26dkPxOYK9CEql9m8NgvigWlOyaXP9gsWT9MsaH3nkOb9XntH2WfxvbpdrWVTTaK/2IgfchWvLZNotx7m7/SXC81rymv21vYAm+VGEfVJofSXlJWQBBNoaX6LFAqZk6Xe6AqlUAwjKnrpIiUka7S3jFTOwYLtD55Rv82DVCKhQfIgaAPqgD2mGs9Ymfl/U4vLXMOV/9lJsvGDeESZG0MWO9yn+YlYS6/rQ6Y0Hb7bOGXKPdxzNGhI0r5nMkpKO8qmdM95f0V2um6mBwM8JOqwdtTlTZfKGmScx67yhXibd71IkOaPCxswUeUL7X4H3yHx4L7U9vX+qCoQNTb0Jq2OOIY3k4JiUqwZzGDXubtKdmSbHzYZSoMLXu5tKwZnm6oCKMNVa3mN6urjH/UOJl28bioxF3ZEsY/qc6QWgKCZZzZLExhNnokOCvBJpk17Rbkl9QlIPwEzX+NoTO3zcQF28hV/HufPz35jtQ4ZloMtWyujwiIhCXWlfPsN3MNCL3f/9jlMHP6kRHMfFgsqzdsCoVFILyYNuA6Bzn0QjbQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 17.10.23 09:28, David Hildenbrand wrote: > On 17.10.23 08:22, Mike Rapoport wrote: >> From: "Mike Rapoport (IBM)" >> >> Qi Zheng reports crashes in a production environment and provides a >> simplified example as a reproducer: >> >> For example, if we use qemu to start a two NUMA node kernel, >> one of the nodes has 2M memory (less than NODE_MIN_SIZE), >> and the other node has 2G, then we will encounter the >> following panic: >> >> [ 0.149844] BUG: kernel NULL pointer dereference, address: 0000000000000000 >> [ 0.150783] #PF: supervisor write access in kernel mode >> [ 0.151488] #PF: error_code(0x0002) - not-present page >> <...> >> [ 0.156056] RIP: 0010:_raw_spin_lock_irqsave+0x22/0x40 >> <...> >> [ 0.169781] Call Trace: >> [ 0.170159] >> [ 0.170448] deactivate_slab+0x187/0x3c0 >> [ 0.171031] ? bootstrap+0x1b/0x10e >> [ 0.171559] ? preempt_count_sub+0x9/0xa0 >> [ 0.172145] ? kmem_cache_alloc+0x12c/0x440 >> [ 0.172735] ? bootstrap+0x1b/0x10e >> [ 0.173236] bootstrap+0x6b/0x10e >> [ 0.173720] kmem_cache_init+0x10a/0x188 >> [ 0.174240] start_kernel+0x415/0x6ac >> [ 0.174738] secondary_startup_64_no_verify+0xe0/0xeb >> [ 0.175417] >> [ 0.175713] Modules linked in: >> [ 0.176117] CR2: 0000000000000000 >> >> The crashes happen because of inconsistency between nodemask that has >> nodes with less than 4MB as memoryless and the actual memory fed into >> core mm. >> >> The commit 9391a3f9c7f1 ("[PATCH] x86_64: Clear more state when ignoring >> empty node in SRAT parsing") that introduced minimal size of a NUMA node >> does not explain why a node size cannot be less than 4MB and what boot >> failures this restriction might fix. >> >> Since then a lot has changed and core mm won't confuse badly about small >> node sizes. >> >> Drop the limitation for the minimal node size. >> >> Reported-by: Qi Zheng >> Signed-off-by: Mike Rapoport (IBM) >> Acked-by: David Hildenbrand >> Acked-by: Michal Hocko >> Link: https://lore.kernel.org/all/20230212110305.93670-1-zhengqi.arch@bytedance.com/ > > That's just a resend I assume? Or has anything changed? Saw the other mail now, so just a resend. -- Cheers, David / dhildenb