From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BF78C001DE for ; Wed, 19 Jul 2023 08:19:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 068C38D0051; Wed, 19 Jul 2023 04:19:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 018978D004B; Wed, 19 Jul 2023 04:19:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD4D78D0051; Wed, 19 Jul 2023 04:19:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C7F958D004B for ; Wed, 19 Jul 2023 04:19:05 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A29D11201E2 for ; Wed, 19 Jul 2023 08:19:05 +0000 (UTC) X-FDA: 81027661050.15.D77DD3F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf10.hostedemail.com (Postfix) with ESMTP id EFA71C0018 for ; Wed, 19 Jul 2023 08:19:01 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HbL+PnSY; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689754742; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=A3PRF01yQKk/5cZ5BWUeGIVek1A+ZScaFRNRxy8v7WU=; b=b4TW6F3MMJMoYLuOYpxIsUePlikqlW3UTrOWeELGOjkrGvv4zB4XGjE47FFmx0dHuYWoW4 2PnlESQV5rijPQ5IGM3f8qSU7D1pkARDYJwarAJMm8G81gxnnNwgv+w4kJSKGTnx+TgTem DzL9fQPbOYdv2vMbr/AAOeF44O6i67Y= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HbL+PnSY; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689754742; a=rsa-sha256; cv=none; b=jlu1kKo90shsREDawQI+ggR0ww58F/8sHPAy51pRWWvFz8f05mpEFFigA2pRVYozTtByiK ImVZe+dSF4Z4VHChepx2SoYwuDQq84RaWR0EaWsbLNkBSGlBwY9/6NFIaUDXZmuBLek4ZX 9PAm26iiuKeQe7E8dEAkIIxVDQTTfsU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689754741; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A3PRF01yQKk/5cZ5BWUeGIVek1A+ZScaFRNRxy8v7WU=; b=HbL+PnSYQMWXQyxZK69h8iU3a4RSI0ZacPI8dKea9r8/CtqTK1yd4cMEsrKzOe1oVeI6us jQ6w7Rwidq7zR9Pws2bP+O0NHf5QjJy+8/pIfCnBZM1pyBgyYXEOCvxDGh7tQ3Fj1aWTFC 8FtON6xNDn4uyM/nn+iNNHBXKU+67OY= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-154-zHBAHDQzPX-1mpUkke31xg-1; Wed, 19 Jul 2023 04:18:59 -0400 X-MC-Unique: zHBAHDQzPX-1mpUkke31xg-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-4fbcdca8fcbso5518429e87.1 for ; Wed, 19 Jul 2023 01:18:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689754738; x=1692346738; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=A3PRF01yQKk/5cZ5BWUeGIVek1A+ZScaFRNRxy8v7WU=; b=XCaSB1vG3R7JK5HDReFwnBhp2mb7Ko8Vu3AZCJrysomwX/fXR4fLcISntQdAdiAhKS zZoRS3h5y8Wvh0ThKtA+6OSQP3A9dPWGjK29YP0yt/rL8szsPd/B5FNVRN1FetzxmkRx 7XgcFXNGciLz3ysBRHyYpJaZxerAAu7I31xmiMbn9uxpX71OxTfxTelNsH7CLpUalRx7 /8haj3VJQfKHhaG8IuC5C193IBWG+9cdONO2x//CW7RjXkaVVjWaDc02bCcZDmTY/bun Iv+UJKsiZYCOjVqjLzz8cdeXHVS/erFbJmXiPmg8jguI/u9U/RqZm+COSjT0y4Z75+mD pAKA== X-Gm-Message-State: ABy/qLZ/FFRW0AkMC1JiXrTFUGhz137MFcNikrBpientrzrS//bye/KT G53tsF5yC1IH69OUK39+e0tuHWGfPo3A/rCIJpoRdVubVRzEsXq91PKSnzlAl8m5JkKYXwsJrL6 p0DyUr3D7XSg= X-Received: by 2002:a05:6512:5c1:b0:4f8:83f:babe with SMTP id o1-20020a05651205c100b004f8083fbabemr11169517lfo.62.1689754737883; Wed, 19 Jul 2023 01:18:57 -0700 (PDT) X-Google-Smtp-Source: APBJJlElWbEEQS6wB/sXWEw3o9coLgNkRyP67VSBFnN2SP6jtQCcIg6AEec+Q116/3HBCGy4e/xB8A== X-Received: by 2002:a05:6512:5c1:b0:4f8:83f:babe with SMTP id o1-20020a05651205c100b004f8083fbabemr11169502lfo.62.1689754737550; Wed, 19 Jul 2023 01:18:57 -0700 (PDT) Received: from ?IPV6:2003:cb:c74b:4f00:b030:1632:49f2:63? (p200300cbc74b4f00b030163249f20063.dip0.t-ipconnect.de. [2003:cb:c74b:4f00:b030:1632:49f2:63]) by smtp.gmail.com with ESMTPSA id u6-20020a05600c00c600b003fbb5142c4bsm1075458wmm.18.2023.07.19.01.18.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Jul 2023 01:18:57 -0700 (PDT) Message-ID: <251edad7-e169-2118-e8e0-e8d4781d5a9c@redhat.com> Date: Wed, 19 Jul 2023 10:18:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2 3/4] selinux: use vma_is_initial_stack() and vma_is_initial_heap() To: Kefeng Wang , Andrew Morton Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, selinux@vger.kernel.org, Paul Moore , Stephen Smalley , Eric Paris References: <20230719075127.47736-1-wangkefeng.wang@huawei.com> <20230719075127.47736-4-wangkefeng.wang@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230719075127.47736-4-wangkefeng.wang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: EFA71C0018 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: bwxtkbajniowbkpeamb7w5hqc8js1eew X-HE-Tag: 1689754741-939368 X-HE-Meta: U2FsdGVkX18KfAChLcYlPWa8vtM9SR5mrojsBSaefUylukTGZ93U2OA64n6oA0pbQNX2tenUr8MOj4b6gJAa3Zl1mEhh3Y0vvYPh8MkneS1jGnKAweazPk+MGqum+w5HnIg+FPpHDX1N0h13VfB6tdhbvVghEt2P5cuFAdi1Jq0HGNgOi0muJ11dsawvp8mzlIILoweK+G2mfRSmj9hd1L1bBh3l9R+j2YJQ7R8NdIszGH44kmvQoA3SkeJWO0M9nyvyeO7HMJGVOrnELZbMTqdpCe1QsJ9uoWoV08DkP1C98eRHVsxZRKp4uvX0wgvuVNS/G1V40wicDWmWawa/SigF2fRfWniTYiFXIs6vhrB15IMaG9OcEmNNmfd8hunesvIudoIAe7GFIordOY1SifVMrpEmQ5TVZNm54+WYwKVbe+5LpNjnlPiTFgacyVicAHMYFbFH0FG1mQl5R65ovXnFFZ8IrUkcy0z78uy3Ewc92lkGWYpDnIGJWEHiaekwOjtQmSOhh1kcY821vKBJAAnKhwehYm0r1PA5ZLq2fpO8lAo+8O4flXDOrqMfVMOsxSqUzvLOS88RDCAu9j2ioq4pNcha5ub0EeJiwzm1wWyPAmYR33et2MHulxJlbs0qVCusLoOBZ+m0oUUQZ43RcsCzFtHosv4HTa1panHXdFHbvrf/h9kScWPSRTjwIGQuwte6YDw6w1XY431G7dLlDEhx8vav+QSGPvUmTVNZds3Y/HKUhB3spFCFm1kJTJM1/KtDFAe09r6w+i1CuqxUwrP7TMkVWEaTyImIzxp9LK5h9NV67MqpnxnRRajAZuQtfLmeo/kGxxCGl3IZe+7i9+NTLnIiptJ/yDGdATt8E/zP34EVfNRLfwFK4NeueJnn+EuszzYmZXQW6gakf56Q4tr+3SP6pIe48OXZ62MJe765muwuMS6V2KQENUbgKpIJlJKTmRNSjXInosZ67hf mLCLuctn mcg99cdB+f//U1Y10JtctxWsjFqeIdng9ZnwQPGC75KowXDsr4MG1B8EsKphExMckJ0Y+SL1yoI8kISLnFJxxyuVJrptlg4KhILKjyMPicb4afpIbCaEYHMbWZNozv5ehoKae3zUpOxeI48ycUAoPJv+k6r7bjpah23zIcXc6FiV24ln/O5qozXiG0Wojq4ZSgiUPMJMUlj+pYOftcwdFw04rOUYW5JARCDRMBX3WSDfDSC1CqR0CYoqtJ1YQw65xN0K6Vfq9ZlQXpD/4yZzl4ImHzj/UBsc0jWQqCQHRXpPw72IYVmIVKTC+4EbJxQEvh6U8gd1TM7NbvLMxc/sI7Yb4NOD32GHSAXPhPux4mh9wgvGekZs0HMaDFkQRepW0n8LccRS7c1tWoFuMu8bzX6ekQC2kkHZTV5qPbD1IPH16RILLvCwJpE1eqZ72fnzmnlsnnQMAEwYZC2VUP1iqraNb7Z7q9LRgcPirJ4EROTZvHyZUwXV02ZCeuD3siHV4SKhoC0HtYx5tcl7hTds7f75TdRDCzTGymiZM5hcTN57cPkF5WVJqtao4d7/OOnEvYxvzAKtwlrXmmFOkNA7Bb1wwa9rkYWUBUl349LA5c0rgjwW7/ZomjVV8tF16d1XtepUDaf3rBKt5NPxYZwdI8HW5ibiEpadXhY4EGDCU/FWdA2QjATi6TUZUKQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 19.07.23 09:51, Kefeng Wang wrote: > Use the helpers to simplify code. > > Cc: Paul Moore > Cc: Stephen Smalley > Cc: Eric Paris > Acked-by: Paul Moore > Signed-off-by: Kefeng Wang > --- > security/selinux/hooks.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c > index d06e350fedee..ee8575540a8e 100644 > --- a/security/selinux/hooks.c > +++ b/security/selinux/hooks.c > @@ -3762,13 +3762,10 @@ static int selinux_file_mprotect(struct vm_area_struct *vma, > if (default_noexec && > (prot & PROT_EXEC) && !(vma->vm_flags & VM_EXEC)) { > int rc = 0; > - if (vma->vm_start >= vma->vm_mm->start_brk && > - vma->vm_end <= vma->vm_mm->brk) { > + if (vma_is_initial_heap(vma)) { > rc = avc_has_perm(sid, sid, SECCLASS_PROCESS, > PROCESS__EXECHEAP, NULL); > - } else if (!vma->vm_file && > - ((vma->vm_start <= vma->vm_mm->start_stack && > - vma->vm_end >= vma->vm_mm->start_stack) || > + } else if (!vma->vm_file && (vma_is_initial_stack(vma) || > vma_is_stack_for_current(vma))) { > rc = avc_has_perm(sid, sid, SECCLASS_PROCESS, > PROCESS__EXECSTACK, NULL); Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb