From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CE51EB64DB for ; Tue, 20 Jun 2023 07:01:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C94B98D0002; Tue, 20 Jun 2023 03:01:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C43CB8D0001; Tue, 20 Jun 2023 03:01:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B0B688D0002; Tue, 20 Jun 2023 03:01:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9D3878D0001 for ; Tue, 20 Jun 2023 03:01:33 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 62184AFDC8 for ; Tue, 20 Jun 2023 07:01:33 +0000 (UTC) X-FDA: 80922230466.20.579ED79 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id BD0198000A for ; Tue, 20 Jun 2023 07:01:30 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PQup8D7h; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687244490; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4nP6ZoAOV09d+oi+b7tvDAzdD2oINBI0GeeIWlxKJYo=; b=SIsf9Lo7y0mA/HDgcVbvBq4Ags2nJIOXz34eXCG4/jnNZWSju+aiR4J6SZ8y1ZBIHvrMAQ /Zd2r+b0v2m6Mkec8KPpneIdCRCd+igIE6aQsRIOacPrcBuahFz45Q0nIEyaD0PDPkwLBb +oJYQYiPQhTXMvnrZMOCkgteZR/azLo= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PQup8D7h; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687244490; a=rsa-sha256; cv=none; b=XBr7WnxTpWq/EwLulp/cq5zyhVaUvtiOcX8Tz2pBvksPKw115u2QATOop89KhiRC7l7I36 Rar2A/eTg16uUL+/bzyqxmbYz8ZZYR3fIRKSKGqoqBxu2znQm0e+uJKMVXNrmOamnYtE5I XyTcB5iQNyfFxcF1pLRPiLxse/pEYOU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687244489; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4nP6ZoAOV09d+oi+b7tvDAzdD2oINBI0GeeIWlxKJYo=; b=PQup8D7hyDsed2sSw7Ja21ztom4P6bm1gpYa4sc6nxrjeUNdyjUMoUURVYHA8y0zCzQQM9 9ln9PQ4l4ivWDimLoZZOPgRIO5+JHLaSb5zTeLYECzst77uaWF1W/0EWmJPXr8Z3ibCLEQ tNg5lvQ4XsptzjJLQFjwWF+Ll3r7XKM= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-396-jDIOMfK-Orycgjj3N-VeFQ-1; Tue, 20 Jun 2023 03:01:28 -0400 X-MC-Unique: jDIOMfK-Orycgjj3N-VeFQ-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-3f814f78af2so19706105e9.0 for ; Tue, 20 Jun 2023 00:01:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687244486; x=1689836486; h=content-transfer-encoding:in-reply-to:subject:organization:from :content-language:references:cc:to:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4nP6ZoAOV09d+oi+b7tvDAzdD2oINBI0GeeIWlxKJYo=; b=RekrIrGnCRWsOm3/4Shsa/1KvV7o7P1EuqxT3fblbh0R4x4Q6/VFWF1oKlNOfCqe77 M+F4gvLmQdQjWl9btQP0+B/DDMVQDIAhoB3PNkPiRvtRnm7OosiWfQNW8ppdz8HN3shU NDx9O/lLhVD5+3Erzn2r0Kwg0mEs14f/tABji+tea4vp4siQ7aodae4yW9J2+JJxG8L7 WpZVoKctRZsAbP7mcgeNTdBnVNHBSfzXPzN+IIh94atUbk/rIRZUlcvH49hibYUdKst2 jBVCVq1/BCXqA7QFVch7/azslC5NM3TKbj3Rw+Z8bBkJO2/oBMpqZ4bkDUK2UDj9Fr45 pHBQ== X-Gm-Message-State: AC+VfDw7mZPAg1EHvOek2S9bhc/U99W4LfmGo/to9EnUF0/Ezu087k4q GNQlFtUsoX0wpQQuM040RvhN+XVVluYhLRM3FVCgS7gwfgxpfBpUrHmy2JQQo/iYc2c13N8a4md g76VKaAO7NbA= X-Received: by 2002:a05:600c:b4d:b0:3f8:fbb6:c17e with SMTP id k13-20020a05600c0b4d00b003f8fbb6c17emr6977640wmr.20.1687244486327; Tue, 20 Jun 2023 00:01:26 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4Z02pit2Yxc/YAdscK4ehXZIK4w4/7to93F0O2TrhC1WoDCfwsI+GEqSHr4XjUrJ63GgfUlQ== X-Received: by 2002:a05:600c:b4d:b0:3f8:fbb6:c17e with SMTP id k13-20020a05600c0b4d00b003f8fbb6c17emr6977622wmr.20.1687244485963; Tue, 20 Jun 2023 00:01:25 -0700 (PDT) Received: from ?IPV6:2003:cb:c739:d200:8745:c520:8bf6:b587? (p200300cbc739d2008745c5208bf6b587.dip0.t-ipconnect.de. [2003:cb:c739:d200:8745:c520:8bf6:b587]) by smtp.gmail.com with ESMTPSA id q4-20020adff784000000b0030aec5e020fsm1241014wrp.86.2023.06.20.00.01.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Jun 2023 00:01:24 -0700 (PDT) Message-ID: <24f4a22e-7d3b-544b-320f-bba5abb92285@redhat.com> Date: Tue, 20 Jun 2023 09:01:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 To: Peter Xu , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: Matthew Wilcox , Andrea Arcangeli , John Hubbard , Mike Rapoport , Vlastimil Babka , "Kirill A . Shutemov" , Andrew Morton , Mike Kravetz , James Houghton , Hugh Dickins References: <20230613215346.1022773-1-peterx@redhat.com> <20230613215346.1022773-4-peterx@redhat.com> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH 3/7] mm/hugetlb: Add page_mask for hugetlb_follow_page_mask() In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: BD0198000A X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: qg4hb5wbpz1reagetecgzcbha74howgg X-HE-Tag: 1687244490-193782 X-HE-Meta: U2FsdGVkX19wF1aH2XrnznLmRij4KxSv5p9Tb3KxnMw7Lf+5Cbjqk7UGZ0SeoZzQXRNHGUSexMj8H6Ei7toruk07XzrfB3px9YSWLKRMavEvfUEN45b0tZ8mZMDEsaGwO/O4IGquRx8uVlfR1NsSh7d2rb2LLnmFEht5I3Sl6Lk8rmASmYGhn/SY0D6dYfbdWkvFav4AgtInlKOR3AdoRgnCDsRP3JiEg3yFHq6OUfRXJMRiDfhIiVT3NgHuQjEs2V44i5ckIc/UPsJrHFi039uvhLei3Niv5I+V8jMYuDS/IZ1WmvtteI53j5/cxNTX6pX1/J1h5wsVJvHGKAJy5N2xXesr/XcziWBbVxOiJRFu0i41LH11DB3T6keSI/YQmTbVih63JlkHx8XGyq3rG8eaRGpM4X/KQgWeBzWNLx+3KmT6mu3wjeIIGhL4cz+/375kR8lngLVcjynUMoLmdWVAvdb87tK49ssEvGuh6nf7wlCGV7GqsQTob+o5u7VAZ9Tg/hmmR52jrfF514ooM8iUwzKtb5v0QO/4jzE+0WF27jIeVMkQlMDK0hu0ZXViBAZrGqItFxoRhkhg3ZduqRrhPNRZnKVpn/hR6FP7gRpFrPQ9xztDkw4lVFXvnBLhAy0O0Qa7dX0a9So74iUk2Et64HDPEnhdflWLSNn5owmRbkoaPrLTtOTZlUV2yAHJ0rkOb7PvOtUFSEV9RbbgxyQgwy2fKFWa5VCkmSUSH80KYFxXf1RBn6hx3AnLtHXdghi+mgMp/Ng/4oiUTYu+j26SQyKSFpv7EpeDPkvn8FL6Hka5KiDhF3mAA7Uy3DhN0sPS/pHG0BCXK/13A21y/Zg38w2uVcdCu9RnwugU4F6cI/0IWi3x2F/HzR/IW+hFdFl7KdeXTWrPWi/fHQW61QXtK5Y2WgZNqukdIPkeg20xgBGjUEMtZ85Cxvzf4oXOzWDxmUWJm7Q2OQD65Zw Ye2HSHb3 L3LKQmz62mAhuLWtmb1RYwulSKVz+0ddG2KJUP+2bkk4+Fg96D5CQD8IJVv1eLWTppyk4Rh9d8ybNoy6h6V58lP2C+RDY7aEnRlhYCUcTWi2WgoNC/3VrT52JH0pIqazRDi7NQ0Uoj0AXZl0W9R0DLV9rvpX1O7TlZQXNEZRiFUV7NoRhgmukwVwTxUnxVshNOW607kpC0ylt9c87MZpeRhagLb6lBBHBmhSRpXnZq5coe09cK/OVQpHeFcStj7EhInrmDxbP+dMvP0AVDiePyjYOlZZm3XbHug9u6fsvv701t4QK1E9RZxN0d7aHlTlh4aGSlf9NsGPmNic0Bw6jtOAB0rdLLGhHdpCiCz+O6PXKXyz8AKAwHUvn9Gn0jYKvWSrxnYWWWA+yr0vlP/MXcxlU0Un59tvVpIdqphiy3HpoKQjDgDl8qwm7mo/pUFpQKpznk18f8YHIYgs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 19.06.23 23:43, Peter Xu wrote: > On Tue, Jun 13, 2023 at 05:53:42PM -0400, Peter Xu wrote: >> @@ -6506,6 +6507,7 @@ struct page *hugetlb_follow_page_mask(struct vm_area_struct *vma, >> * because we hold the ptl lock and have verified pte_present(). >> */ >> WARN_ON_ONCE(try_grab_page(page, flags)); >> + *page_mask = huge_page_mask(h); > > Sorry, I was wrong this line. It should be: > > *page_mask = ~huge_page_mask(h) >> PAGE_SHIFT; > That's ... surprising. It feels like either page_mask or huge_page_mask() has a misleading name .... h->mask = ~(huge_page_size(h) - 1); For PMDs, we do ctx->page_mask = HPAGE_PMD_NR - 1; Maybe *page_mask = PHYS_PFN(huge_page_size(h)) - 1; Would be clearer. I guess "page_mask" should actually be "pfn_mask" ... but the meaning regarding PAGE_MASK are still inverted ... -- Cheers, David / dhildenb