From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7457AC433EF for ; Wed, 4 May 2022 11:23:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C2BF36B0071; Wed, 4 May 2022 07:23:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BDB206B0073; Wed, 4 May 2022 07:23:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AA2766B0074; Wed, 4 May 2022 07:23:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9A83A6B0071 for ; Wed, 4 May 2022 07:23:45 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 67FA3120F8D for ; Wed, 4 May 2022 11:23:45 +0000 (UTC) X-FDA: 79427825610.23.6157643 Received: from mxout03.lancloud.ru (mxout03.lancloud.ru [45.84.86.113]) by imf10.hostedemail.com (Postfix) with ESMTP id 8EC6FC0084 for ; Wed, 4 May 2022 11:23:28 +0000 (UTC) Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout03.lancloud.ru 2D48820DE95C Received: from LanCloud Received: from LanCloud Received: from LanCloud Subject: Re: [PATCH RFC v6 16/21] dept: Distinguish each work from another To: Byungchul Park , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , <42.hyeyoo@gmail.com> References: <1651652269-15342-1-git-send-email-byungchul.park@lge.com> <1651652269-15342-17-git-send-email-byungchul.park@lge.com> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: <24e4d6db-9dc9-f113-f655-9af3a51723d4@omp.ru> Date: Wed, 4 May 2022 14:23:39 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <1651652269-15342-17-git-send-email-byungchul.park@lge.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.11.198] X-ClientProxiedBy: LFEXT01.lancloud.ru (fd00:f066::141) To LFEX1907.lancloud.ru (fd00:f066::207) X-Stat-Signature: uds38qyhr665t7xrxw41xdbnxxqa1izn X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8EC6FC0084 X-Rspam-User: Authentication-Results: imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of s.shtylyov@omp.ru designates 45.84.86.113 as permitted sender) smtp.mailfrom=s.shtylyov@omp.ru; dmarc=none X-HE-Tag: 1651663408-58492 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello! On 5/4/22 11:17 AM, Byungchul Park wrote: > Workqueue already provides concurrency control. By that, any wait in a > work doesn't prevents events in other works with the control enabled. > Thus, each work would better be considered a different context. > > So let Dept assign a different context id to each work. > > Signed-off-by: Byungchul Park [...] > diff --git a/kernel/dependency/dept.c b/kernel/dependency/dept.c > index 18e5951..6707313 100644 > --- a/kernel/dependency/dept.c > +++ b/kernel/dependency/dept.c > @@ -1844,6 +1844,16 @@ void dept_enirq_transition(unsigned long ip) > dept_exit(flags); > } > > +/* > + * Assign a different context id to each work. > + */ > +void dept_work_enter(void) > +{ > + struct dept_task *dt = dept_task(); > + > + dt->cxt_id[DEPT_CXT_PROCESS] += (1UL << DEPT_CXTS_NR); Parens around << unnecessary... [...] MBR, Sergey