From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97C34C02198 for ; Tue, 11 Feb 2025 02:02:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0BD0F28000B; Mon, 10 Feb 2025 21:02:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 06CDD28000A; Mon, 10 Feb 2025 21:02:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E763628000B; Mon, 10 Feb 2025 21:02:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id CB96728000A for ; Mon, 10 Feb 2025 21:02:56 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7D75FB15D1 for ; Tue, 11 Feb 2025 02:02:56 +0000 (UTC) X-FDA: 83106015552.01.E2D7FA4 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf03.hostedemail.com (Postfix) with ESMTP id D01F120008 for ; Tue, 11 Feb 2025 02:02:54 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf03.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739239374; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BWZcR6xncAXhNatZF73iqd2VwOt7UMWFCk3fGt5qHYg=; b=Knx4iN695fJcwgIKU3JImJlkBENuI9S98bnvVBmKPRxe3MN9rASWy1gXdZbMIa6zokar3G OBZQ27KUI5Z1R0kM6txeGhwmWEdTVQIJe0bSLNVobD6yuqZOiLVU9ImZR1l82aTbZmz6/V 195vXOY55uMrn22+DOkA29Dw/IvklWw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739239374; a=rsa-sha256; cv=none; b=GtwO7c6Tp00Y+72Ht+j1RI2biQbkeCzMrcDJOIopsec0L+ZZqR0xmisY6XJXWzYMOusbCq AfqadLvC5WV0U1tkXXK6I9suMQ8be+PFdLYCtcP9zPzdPl5bH9q8nRiL2eXwXYA5IV89cr 4nEnQxXYXvOyCVTK2ZHY41AhGUqOvzI= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf03.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1thfaK-000000000T0-0OkG; Mon, 10 Feb 2025 21:01:12 -0500 Message-ID: <24daac05a52fbd62a98eaad2ff689a89615a8287.camel@surriel.com> Subject: Re: [PATCH v9 06/12] x86/mm: use INVLPGB for kernel TLB flushes From: Rik van Riel To: Brendan Jackman Cc: x86@kernel.org, linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali Shukla Date: Mon, 10 Feb 2025 21:01:12 -0500 In-Reply-To: References: <20250206044346.3810242-1-riel@surriel.com> <20250206044346.3810242-7-riel@surriel.com> Autocrypt: addr=riel@surriel.com; prefer-encrypt=mutual; keydata=mQENBFIt3aUBCADCK0LicyCYyMa0E1lodCDUBf6G+6C5UXKG1jEYwQu49cc/gUBTTk33A eo2hjn4JinVaPF3zfZprnKMEGGv4dHvEOCPWiNhlz5RtqH3SKJllq2dpeMS9RqbMvDA36rlJIIo47 Z/nl6IA8MDhSqyqdnTY8z7LnQHqq16jAqwo7Ll9qALXz4yG1ZdSCmo80VPetBZZPw7WMjo+1hByv/ lvdFnLfiQ52tayuuC1r9x2qZ/SYWd2M4p/f5CLmvG9UcnkbYFsKWz8bwOBWKg1PQcaYHLx06sHGdY dIDaeVvkIfMFwAprSo5EFU+aes2VB2ZjugOTbkkW2aPSWTRsBhPHhV6dABEBAAG0HlJpayB2YW4gU mllbCA8cmllbEByZWRoYXQuY29tPokBHwQwAQIACQUCW5LcVgIdIAAKCRDOed6ShMTeg05SB/986o gEgdq4byrtaBQKFg5LWfd8e+h+QzLOg/T8mSS3dJzFXe5JBOfvYg7Bj47xXi9I5sM+I9Lu9+1XVb/ r2rGJrU1DwA09TnmyFtK76bgMF0sBEh1ECILYNQTEIemzNFwOWLZZlEhZFRJsZyX+mtEp/WQIygHV WjwuP69VJw+fPQvLOGn4j8W9QXuvhha7u1QJ7mYx4dLGHrZlHdwDsqpvWsW+3rsIqs1BBe5/Itz9o 6y9gLNtQzwmSDioV8KhF85VmYInslhv5tUtMEppfdTLyX4SUKh8ftNIVmH9mXyRCZclSoa6IMd635 Jq1Pj2/Lp64tOzSvN5Y9zaiCc5FucXtB9SaWsgdmFuIFJpZWwgPHJpZWxAc3VycmllbC5jb20+iQE +BBMBAgAoBQJSLd2lAhsjBQkSzAMABgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRDOed6ShMTe g4PpB/0ZivKYFt0LaB22ssWUrBoeNWCP1NY/lkq2QbPhR3agLB7ZXI97PF2z/5QD9Fuy/FD/jddPx KRTvFCtHcEzTOcFjBmf52uqgt3U40H9GM++0IM0yHusd9EzlaWsbp09vsAV2DwdqS69x9RPbvE/Ne fO5subhocH76okcF/aQiQ+oj2j6LJZGBJBVigOHg+4zyzdDgKM+jp0bvDI51KQ4XfxV593OhvkS3z 3FPx0CE7l62WhWrieHyBblqvkTYgJ6dq4bsYpqxxGJOkQ47WpEUx6onH+rImWmPJbSYGhwBzTo0Mm G1Nb1qGPG+mTrSmJjDRxrwf1zjmYqQreWVSFEt26tBpSaWsgdmFuIFJpZWwgPHJpZWxAZmIuY29tP okBPgQTAQIAKAUCW5LbiAIbIwUJEswDAAYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQznneko TE3oOUEQgAsrGxjTC1bGtZyuvyQPcXclap11Ogib6rQywGYu6/Mnkbd6hbyY3wpdyQii/cas2S44N cQj8HkGv91JLVE24/Wt0gITPCH3rLVJJDGQxprHTVDs1t1RAbsbp0XTksZPCNWDGYIBo2aHDwErhI omYQ0Xluo1WBtH/UmHgirHvclsou1Ks9jyTxiPyUKRfae7GNOFiX99+ZlB27P3t8CjtSO831Ij0Ip QrfooZ21YVlUKw0Wy6Ll8EyefyrEYSh8KTm8dQj4O7xxvdg865TLeLpho5PwDRF+/mR3qi8CdGbkE c4pYZQO8UDXUN4S+pe0aTeTqlYw8rRHWF9TnvtpcNzZw== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.1 (3.54.1-1.fc41) MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Queue-Id: D01F120008 X-Rspamd-Server: rspam07 X-Stat-Signature: 1qoiqta87tkfpmbtusgbs4qx69989eeu X-HE-Tag: 1739239374-356765 X-HE-Meta: U2FsdGVkX1+NU6rlfBLilXJmdWxBKql55wS8BSmtK60QoAPgBUDuhjbXYjaWqLgsGuroHsCdurlOFx+YHgJHv2N7tbyXmdDALhwkHldmd1ZCjgrbmJkyfg+s0ZVVS717CcVm1qbMFKgRge2SgXb8yn6VwVvJRxkXPCXLunahtbyNlEMVChoI+P7L6iMQhLJ+L+VeZObnR5Dkk+TkjccnXEdKd0oPIXhZXgG/xBuk6xVx4JK9QH5O7j/rR1bITwvjg9FKWByNuj+DzODa59qTpSdHD2t93InVHDrlL7JuwWFsFQCR6GBLZoUwbGwsPIhDkmJSJP28O5UeN3iEP/6jBIF/8zPTLjWDrClyb9PZY+sWxxs4dhB1RAZ41czhF3YpOm2v+cTvL4u0H+QWnFNsvFjFSbXAnPEMfqXcAVS0LiTdapOIGgiAqQ7m6P/gUKdPFHOaPEdcPkEpCUTmhWuyomkzjD8YonF8co5NMnjzTHlUGNoMMO66msonEzylqtQLdQb+hyWacrFsKMXIp8UxgG3X8MZljY4mfl7HSBK+piDbS+c23NHrTImRjlA9SCblARI2TnQnwdQpvzlF5ePCEDcrXrkIzUD+O2Fw+TxQPQiYdWchQQks5DjcOiIpeeNqbzER9863MOJP5aWOMFW8coH+05NwxdL9KyV07Q1zMlUkkVFCjiGWyWdKknuGvSZNszcxhxXSNsz2kk8kPLXGrQ7ZaPm3MRLLqvl7jlcX/AQ2+t7UzMxbJq2zgmd7UtR+QQqfi4rcVp7ata6C7ehcZ3YsTl9Xmr9K55SIkDcOQvC3YmpQosZ8eNqWdtShSoQPGfAoqyaC5vY2/D3FraqCelyMKgN/YQvNDAiuScKiM50+FxEpgLC5OsFvSzZwP0wcFX4fWOjhR7gJ20NT6p5ztL7xS8j33eXBVHaDbv6L2jeNS0yJYbDKtpNC6EZZDO3MLBH7mA7AMS1SWpd9apn NKib08+Q 55eEIo2LvoGG8ZK+Vqk2W3/3nBc3rgIQ05Bj4EPTGMY0tnvmzVOfcr9/UPeFrnxbRthfVs58+Yt4LB7DldzmjLSNrLwD4Fpl3CqhFL1Wa7KwMMlB+GRLAAr9SNpin4BsOX5t2R7FxfwQp9k88M8QCMElx9g7itJLIQzDLvEvX2QqO5BD7c+Q6RegLfNsBkiZnJ3kK2kkPCYsWjGYT64D+ORA0h4b8MtLfA0Xhg7LY0lpFfrYz/NPCM9l/LIFhUoWuna1O3O0D3J2IaRb8Lj4HY724jD4ZkpNn33nxI/oyR4eVViRNFQTjsEUlqpIJrERA6V9nl/KTBSPjZdDScI0S4ebM+ptQ+AI/n50CMDMRP5H6x3KPY+V534DuSyCJeTOTpa3yMlgNZwgmQc0kiVyW2e9IQWyYJ65Rxb0dy/pDk+AA5fOxzDIW+Mwyh+suXFfLvByHcI76KLFas2UETiTWl9ShN/UT6O8MpWDiGStb/KYfLQo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 2025-02-07 at 17:03 +0100, Brendan Jackman wrote: > On Thu, 6 Feb 2025 at 05:45, Rik van Riel wrote: > > diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c > > index 36939b104561..227e972b6fbc 100644 > > --- a/arch/x86/mm/tlb.c > > +++ b/arch/x86/mm/tlb.c > > @@ -1086,6 +1086,30 @@ void flush_tlb_all(void) > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 on_each_cpu(do_flush_tlb_all= , NULL, 1); > > =C2=A0} > >=20 > > +static bool broadcast_kernel_range_flush(struct flush_tlb_info > > *info) > > +{ > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned long addr; > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned long nr; > > + > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (!IS_ENABLED(CONFIG_X86_BROADC= AST_TLB_FLUSH)) > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 return false; > > + > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (!cpu_feature_enabled(X86_FEAT= URE_INVLPGB)) > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 return false; >=20 > I think that first conditional can be shunted off into the header >=20 > diff --git a/arch/x86/include/asm/disabled-features.h > b/arch/x86/include/asm/disabled-features.h > index c492bdc97b05..61376b4e4fa7 100644 > --- a/arch/x86/include/asm/disabled-features.h > +++ b/arch/x86/include/asm/disabled-features.h > @@ -129,6 +129,12 @@ > =C2=A0#define DISABLE_SEV_SNP=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (1 << (X86_FEATURE_SEV_SNP= & > 31)) > =C2=A0#endif >=20 > +#ifdef CONFIG_X86_BROADCAST_TLB_FLUSH > +#define DISABLE_INVLPGB=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 0 > +#else > +#define DISABLE_INVLPGB=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (1 << = (X86_FEATURE_INVLPGB & 31)) > +#endif > + I'm adding this for v10, with the disabled-features.h stuff in patch 5, and removing the no longer needed tests from each subsequent patch. --=20 All Rights Reversed.