From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40E1DC433F5 for ; Thu, 13 Jan 2022 21:27:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7E50C6B0078; Thu, 13 Jan 2022 16:27:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7937A6B007B; Thu, 13 Jan 2022 16:27:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 683D76B007D; Thu, 13 Jan 2022 16:27:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0003.hostedemail.com [216.40.44.3]) by kanga.kvack.org (Postfix) with ESMTP id 5977E6B0078 for ; Thu, 13 Jan 2022 16:27:05 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 153E0903D0 for ; Thu, 13 Jan 2022 21:27:05 +0000 (UTC) X-FDA: 79026549210.19.63EA5A7 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf15.hostedemail.com (Postfix) with ESMTP id 5C5B9A0008 for ; Thu, 13 Jan 2022 21:27:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=ayS3prurjAu/ZPuhb/qI34CN7+Mgs9bDXWUscUrqSMk=; b=ZJ7Hm/hT9j+Jgq31XRQ8PdnWLQ zlxQMkNuR1Yap1HH9DQx0bri7HCa/TsoTd6cu02X5haj7+F2a8Qa64M5CfJByBeEib0E0IMqkhKkh ZA6EnQAuIGSjDim9BgQoBeLQ8B8DPHdXxQ/VSD9ZHOjvU5ctmy6cl/cC+LJPW4iOXTn8zpeFdpCoC uwOM83bQNnyW58yosvLtJMCQ+DLHwqxWaY4LSsXvCAo0Nedssw7tmsl9EvFQFsLCyU3piMNauliTF k3/3oLN/RtVEQGC1PT4d58GR6Peh60T/uznSKPHSXDPYTmvV+yM1j1Hl4l0WWRpcJsXeVzlpRrSI5 sW5Jrziw==; Received: from [2601:1c0:6280:3f0::aa0b] by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1n87cT-0011Xg-JH; Thu, 13 Jan 2022 21:26:53 +0000 Message-ID: <24d83e9c-a4d5-176b-1ff3-909d0ad56302@infradead.org> Date: Thu, 13 Jan 2022 13:26:48 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: linux-next: Tree for Jan 13 (UBSAN: invalid-load in ../mm/swap.c:996:11) Content-Language: en-US To: Matthew Wilcox Cc: Stephen Rothwell , Linux Next Mailing List , Linux Kernel Mailing List , linux-mm , Andrew Morton References: <20220113152247.3f7c6c49@canb.auug.org.au> <56c04e36-ff53-10c7-34dd-1c1385639de6@infradead.org> From: Randy Dunlap In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 5C5B9A0008 X-Stat-Signature: kizkk9a3g6akw6h1owq68q75j5jrpcr1 Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b="ZJ7Hm/hT"; dmarc=none; spf=none (imf15.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=rdunlap@infradead.org X-Rspamd-Server: rspam02 X-HE-Tag: 1642109224-944609 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/13/22 12:47, Matthew Wilcox wrote: > On Thu, Jan 13, 2022 at 12:12:52PM -0800, Randy Dunlap wrote: >> [ 1.561983] UBSAN: invalid-load in ../mm/swap.c:996:11 >> [ 1.561986] load of value 221 is not a valid value for type '_Bool' > > Ooh. This one's mine. Randy, does it repeat easily? This should > fix it: Yes, 100% of the time (for N = 3). Reported-by: Randy Dunlap Tested-by: Randy Dunlap Fixed 100% of the time (for N = 3). Thanks. > diff --git a/include/linux/pagevec.h b/include/linux/pagevec.h > index dda8d5868c81..67b1246f136b 100644 > --- a/include/linux/pagevec.h > +++ b/include/linux/pagevec.h > @@ -111,6 +111,7 @@ static_assert(offsetof(struct pagevec, pages) == > static inline void folio_batch_init(struct folio_batch *fbatch) > { > fbatch->nr = 0; > + fbatch->percpu_pvec_drained = false; > } > > static inline unsigned int folio_batch_count(struct folio_batch *fbatch) > -- ~Randy