From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC022C33CAD for ; Mon, 13 Jan 2020 12:47:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 792942081E for ; Mon, 13 Jan 2020 12:47:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 792942081E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0B81C8E0005; Mon, 13 Jan 2020 07:47:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 069D68E0003; Mon, 13 Jan 2020 07:47:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E99F48E0005; Mon, 13 Jan 2020 07:47:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0243.hostedemail.com [216.40.44.243]) by kanga.kvack.org (Postfix) with ESMTP id D4BBF8E0003 for ; Mon, 13 Jan 2020 07:47:08 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 8C3613499 for ; Mon, 13 Jan 2020 12:47:08 +0000 (UTC) X-FDA: 76372586136.09.water61_5b49c8f297740 X-HE-Tag: water61_5b49c8f297740 X-Filterd-Recvd-Size: 6389 Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Mon, 13 Jan 2020 12:47:06 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R101e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01f04397;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=13;SR=0;TI=SMTPD_---0TndsAqh_1578919612; Received: from IT-FVFX43SYHV2H.local(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0TndsAqh_1578919612) by smtp.aliyun-inc.com(127.0.0.1); Mon, 13 Jan 2020 20:46:52 +0800 Subject: Re: [PATCH v7 00/10] per lruvec lru_lock for memcg To: Hugh Dickins Cc: hannes@cmpxchg.org, Andrew Morton , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mgorman@techsingularity.net, tj@kernel.org, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, yang.shi@linux.alibaba.com, willy@infradead.org, shakeelb@google.com References: <1577264666-246071-1-git-send-email-alex.shi@linux.alibaba.com> <20191231150514.61c2b8c8354320f09b09f377@linux-foundation.org> <944f0f6a-466a-7ce3-524c-f6db86fd0891@linux.alibaba.com> From: Alex Shi Message-ID: <24d671ac-36ef-8883-ad94-1bd497d46783@linux.alibaba.com> Date: Mon, 13 Jan 2020 20:45:25 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: =E5=9C=A8 2020/1/13 =E4=B8=8B=E5=8D=884:48, Hugh Dickins =E5=86=99=E9=81=93= : > On Fri, 10 Jan 2020, Alex Shi wrote: >> =E5=9C=A8 2020/1/2 =E4=B8=8B=E5=8D=886:21, Alex Shi =E5=86=99=E9=81=93= : >>> =E5=9C=A8 2020/1/1 =E4=B8=8A=E5=8D=887:05, Andrew Morton =E5=86=99=E9= =81=93: >>>> On Wed, 25 Dec 2019 17:04:16 +0800 Alex Shi wrote: >>>> >>>>> This patchset move lru_lock into lruvec, give a lru_lock for each o= f >>>>> lruvec, thus bring a lru_lock for each of memcg per node. >>>> >>>> I see that there has been plenty of feedback on previous versions, b= ut >>>> no acked/reviewed tags as yet. >>>> >>>> I think I'll take a pass for now, see what the audience feedback loo= ks >>>> like ;) >>>> >>> >> >> Hi Johannes, >> >> Any comments of this version? :) >=20 > I (Hugh) tried to test it on v5.5-rc5, but did not get very far at all = - > perhaps because my particular interest tends towards tmpfs and swap, > and swap always made trouble for lruvec lock - one of the reasons why > our patches were more complicated than you thought necessary. >=20 > Booted a smallish kernel in mem=3D700M with 1.5G of swap, with intentio= n > of running small kernel builds in tmpfs and in ext4-on-loop-on-tmpfs > (losetup was the last command started but I doubt it played much part): >=20 > mount -t tmpfs -o size=3D470M tmpfs /tst > cp /dev/zero /tst > losetup /dev/loop0 /tst/zero Hi Hugh, Many thanks for the testing! I am trying to reproduce your testing, do above 3 steps, then build kerne= l with 'make -j 8' on my qemu. but cannot reproduce the problem with this= v7 version or with v8 version, https://github.com/alexshi/linux/tree/lru= -next, which fixed the bug KK mentioned, like the following.=20 my qemu vmm like this: [root@debug010000002015 ~]# mount -t tmpfs -o size=3D470M tmpfs /tst [root@debug010000002015 ~]# cp /dev/zero /tst cp: error writing =E2=80=98/tst/zero=E2=80=99: No space left on device cp: failed to extend =E2=80=98/tst/zero=E2=80=99: No space left on device [root@debug010000002015 ~]# losetup /dev/loop0 /tst/zero [root@debug010000002015 ~]# cat /proc/cmdline earlyprintk=3DttyS0 root=3D/dev/sda1 console=3DttyS0 debug crashkernel=3D= 128M printk.devkmsg=3Don my kernel configed with MEMCG/MEMCG_SWAP with xfs rootimage, and compilin= g kernel under ext4. Could you like to share your kernel config and detai= led reproduce steps with me? And would you like to try my new version fro= m above github link in your convenient? Thanks a lot! Alex=20 static void commit_charge(struct page *page, struct mem_cgroup *memcg, bool lrucare) { - int isolated; + struct lruvec *lruvec =3D NULL; VM_BUG_ON_PAGE(page->mem_cgroup, page); @@ -2612,8 +2617,16 @@ static void commit_charge(struct page *page, struc= t mem_cgroup *memcg, * In some cases, SwapCache and FUSE(splice_buf->radixtree), the = page * may already be on some other mem_cgroup's LRU. Take care of i= t. */ - if (lrucare) - lock_page_lru(page, &isolated); + if (lrucare) { + lruvec =3D lock_page_lruvec_irq(page); + if (likely(PageLRU(page))) { + ClearPageLRU(page); + del_page_from_lru_list(page, lruvec, page_lru(pag= e)); + } else { + unlock_page_lruvec_irq(lruvec); + lruvec =3D NULL; + } + } /* * Nobody should be changing or seriously looking at @@ -2631,8 +2644,15 @@ static void commit_charge(struct page *page, struc= t mem_cgroup *memcg, */ page->mem_cgroup =3D memcg; - if (lrucare) - unlock_page_lru(page, isolated); + if (lrucare && lruvec) { + unlock_page_lruvec_irq(lruvec); + lruvec =3D lock_page_lruvec_irq(page); + + VM_BUG_ON_PAGE(PageLRU(page), page); + SetPageLRU(page); + add_page_to_lru_list(page, lruvec, page_lru(page)); + unlock_page_lruvec_irq(lruvec); + } } >=20 > and kernel crashed on the >=20 > VM_BUG_ON_PAGE(lruvec_memcg(lruvec) !=3D page->mem_cgroup, page); > kernel BUG at mm/memcontrol.c:1268! > lock_page_lruvec_irqsave > relock_page_lruvec_irqsave > pagevec_lru_move_fn > __pagevec_lru_add > lru_add_drain_cpu > lru_add_drain > swap_cluster_readahead > shmem_swapin > shmem_swapin_page > shmem_getpage_gfp > shmem_getpage > shmem_write_begin > generic_perform_write > __generic_file_write_iter > generic_file_write_iter > new_sync_write > __vfs_write > vfs_write > ksys_write > __x86_sys_write > do_syscall_64 >=20 > Hugh >=20