From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F262E7718B for ; Wed, 1 Jan 2025 15:20:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 861736B007B; Wed, 1 Jan 2025 10:20:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 811276B0083; Wed, 1 Jan 2025 10:20:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B0EA6B0085; Wed, 1 Jan 2025 10:20:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4E0246B007B for ; Wed, 1 Jan 2025 10:20:10 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C6F1A121B05 for ; Wed, 1 Jan 2025 15:20:09 +0000 (UTC) X-FDA: 82959242226.10.1344E20 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) by imf23.hostedemail.com (Postfix) with ESMTP id C237A140002 for ; Wed, 1 Jan 2025 15:19:34 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GCqJuUoa; spf=pass (imf23.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.208.44 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735744770; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S/myDh+TmQLAgENNyjhGRDFzIXNAWZBQN8/oinLahgQ=; b=3vlQ9I0dGKHf69aMl4IQSTh9vJN9I48Pfvj5YN9KoApXitKV1JJbOWy8/RwuspuIyAlK5C /5BATohGoygN8Fw30MUhxlX9+0u6Km9jAlmnH6trcX6pC5bSQp50VWEt+an6ct331Iin7v e1ZaWs7dYTJR5NTGGDrqr6cbr+5Zp0U= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GCqJuUoa; spf=pass (imf23.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.208.44 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735744770; a=rsa-sha256; cv=none; b=O9+KCogS7yB6PEC2v/EQGGqPaCgDG0rBoL6eumf3y9Gw9RQjc6/xKyZ/EvatzwIVPzjK7Y yJniUxEsVLN8XORZIw/ek56ZN0f1st2pkpSjJKjmeTgNvldceho///W6a2DvEL/RSX95Gd +T0uED0LyU9U5+sMxa+504N1fJOeUU0= Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-5ceb03aadb1so15297331a12.0 for ; Wed, 01 Jan 2025 07:20:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735744806; x=1736349606; darn=kvack.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=S/myDh+TmQLAgENNyjhGRDFzIXNAWZBQN8/oinLahgQ=; b=GCqJuUoa2pHsq3pT3uc8vpN6oDakJb1ZcLbyTdQukI2uI/lqCKrxH5dk3qLAizbPBv hVmOdshMpy3GhHEpx1FA6QmZ9xVUu9bNnnFS9hBsCoHCpgqWOtTDv49ZC5DGFcWtXHnK /yUhU3MNfN+MmvJDne3Ohlxo5jiv8XYi4sC85nuE7YgWLJzKvi+OdlcIr2QIo7VohTye lhtHU5OZmu54mtf600THUr307SiUsRPce4fP8KAghMtK879xbM1wSo5TwzKxirG2NnvT HvQJT4oXUztK0zH6vdy4CkU5Flo6BRivxvXDT//fVYE7du3VeUjRPiagsurmYhjzSckT mZQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735744806; x=1736349606; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=S/myDh+TmQLAgENNyjhGRDFzIXNAWZBQN8/oinLahgQ=; b=ox52go8FiahNKk/mmGJrQGrEFBWSMQEva/Vz4M8cRY3PwOnIEnaRJiM1XAgJ5XiV0b Nl+0xWljLL7KFvoPBjlgHYtkFtAH7ssqWedkuMOkyI840b8UHZIDVyFUTe0Oplb6aQa5 IvFZUMazvw0lU932b3wlM8oBw+A84WzX4p5OPklGdUrUkshNSy8enxXEUrS8CtOxtAHh SNQPfEUdi4/VDVPAS4OGNCG8m2zNIlfrphNGZy/iUxgW7nIlmrWhsmhmCE9w8T6C9Ljz j17/XSdgCkzpOkH66zgI+yqD8LZK7BME2+Y+LEuQsyXfJBcFi8nrZpq7iAVTtiiutxq6 Fe7Q== X-Forwarded-Encrypted: i=1; AJvYcCUJRcAmZFL4Jnx/o+tJc+1/XOHOp1gDBLuiEHnB+ygrrHt+/t3wdgKkVfzexuB8DeEgEBmWd7oCSg==@kvack.org X-Gm-Message-State: AOJu0YyAppT8HFx3tWwGpzHYlDYqY3msIPhOR9KcMLjUVzebHJUa/uiW enARtAqRDyxNye1CPXrZ2JOc5Ouwi8BE2nT6Fn+PSHW6kZ32xPXi X-Gm-Gg: ASbGncs3dM3B3KtTkVtPliHddv5+CqBuF6/3LafiRSmv43A7L/DwCW33LbDurn61ww6 cQQ44Uve5J+je27Th18OSZhmLvtI4ZfWs66fMwOS/nRgFMAhqP0Kt5T72xSrj+DxU5UjBSv3haO GXcmKi9o3wXVIN8jUVYkHgio56q12NvzKuj6xJaXDMlMuN/r1WTeK4Bmemzjs5+IXojo8dLezH4 /pO+40m+HxQbX+z/2Y5fZ9S09sHRVfibwGPpcW9ocdB3N5boCfThICCsHX2aY6bz12bajy9 X-Google-Smtp-Source: AGHT+IGECEMAOda7kRcXPz4TemxgaiAtaNt1hi7wmNXw57CgHZNGtBAmGJHwfcevgCm2sR/twmh2Wg== X-Received: by 2002:a05:6402:35d5:b0:5d0:e877:7664 with SMTP id 4fb4d7f45d1cf-5d81ddada54mr39252504a12.19.1735744805753; Wed, 01 Jan 2025 07:20:05 -0800 (PST) Received: from [132.69.243.32] ([132.69.243.32]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d80679efc9sm17158529a12.47.2025.01.01.07.20.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jan 2025 07:20:04 -0800 (PST) Message-ID: <24c9b4b6-e07b-4cee-aa7f-6f317a1b7ef6@gmail.com> Date: Wed, 1 Jan 2025 17:20:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 09/12] x86/mm: enable broadcast TLB invalidation for multi-threaded processes To: Rik van Riel Cc: the arch/x86 maintainers , Linux Kernel Mailing List , kernel-team@meta.com, Dave Hansen , luto@kernel.org, peterz@infradead.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Andrew Morton , zhengqi.arch@bytedance.com, "open list:MEMORY MANAGEMENT" References: <20241230175550.4046587-1-riel@surriel.com> <20241230175550.4046587-10-riel@surriel.com> <95b614577f5475a919c878d6906d721004c83584.camel@surriel.com> Content-Language: en-US From: Nadav Amit Autocrypt: addr=nadav.amit@gmail.com; keydata= xsFNBF3nSCQBEACinGNWCLb3Iptvg066zPUQCFfR0nIX+j/pjxlLd094zOKLJ7Z1wKNNTQgb +Y1GQYwKurK1hFHISPc1T7xk2twzov5niFqQp1/E0I6t/92rxo7C26tKMrCHgqXpFXXBaOvq t0QN8B83o3sfS3OZyc0F5hWoJijhKQ+h7dJHMPpBBeTWiZzYVlMNz/wRzYrh1nvesbGJtV1w Wk96qoQAOagczRaSRWouJ1O2JbHqQarLJG657hqtPZctQ1mkXQcJedT1c8ejWBdIiU0rIpV/ R2uTgM5NSjVrY5OxiS2G4C/bDcI4Q6ApWxqu1zRGffKWRFJdQvttSv+JbW2q6OCvJReJs1i6 nTovpfJb3g9d7U76LtAw7HE5iIl5CmyFoTMMH+sDc5PG7JRboiofku9DWeDGK4rB2s97GuA9 BXJDHBbH1AI+Y0H6oz/Dri1sQSayUU8Xj/jCkwxpwDle1qYYE0UM4PqDTUoeejURR/h/AREt bCecfxNUYNz2jY8PUL0YXj6yex2p1otMy5sy7djrTqhC02AXLQ3Oab2UJuMZnf4cTbN2sGXu CRXcCSsoyhxIFtwpgdVIDqkPMCOEPvUwy9hWs0N9Xy+jOebpH6FYxq83pP3IhyBdaoexoyGL IkSzrO4+0bVk5voh5SIYVkLEooMSEQT9rfSdrJmRRuM7S/PowwARAQABzSFOYWRhdiBBbWl0 IDxuYWRhdi5hbWl0QGdtYWlsLmNvbT7CwZcEEwEIAEECGwMFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4ACGQEWIQRIkveiyXlibH/D0jUdoCpJptoPWgUCZWMLXAUJCz4qOAAKCRAdoCpJptoP WoWjD/0d8I+qQIHp2Eq7Whi+idkGDJaaBksRw2r0+XTzRj0CsCFJS7oMWudQaYaI2bTW9uha zfcmpnkm5aOVoxGOGJUJSy0H4of6lShE+7caoz1pdX+y15STij3+RvUjcGn0N+Mpxrnj6anm ArH5KOwzQJDiMF48ntQ2EQAFJ5X6YZ6Ed9N4I88XPeOtWaU21Q5tZI/ASHrQTH7BMukkVe2U PkSjn205vbrCfcC4Ohu9HXC8ey6l5txomFaTIRvaz1La3W8gQHhT2D2QeNnJFRudN5hQJNIE OHFi6QmPVIbI/uYD82h5uesiufycV2kvuIACmvs2T3tpaxSY9HOJF/yAhqg28hKE4wKQIwh2 wzZ+ywDeZ5TboqTjTU9oPHuRTxYItWmevJgQDwOYcssYI4wOdXvu/bh5VvhBgJxgkOOH7j8N efzqooL/2/pD/1JAO9GjPEWbuRx0dZh5tcMq/RYFFhdZQNFYmqdDyY0+y6ntxEo25ScvVLfR GqhpyJkN9+cqJZfg3IolbWoZxkSLtiCBge/EDRRoLJpjpsLpBmMmQcH/50WgQcoL5ObVlc1I ft1sKfzZvIyqXZfu3YcWgvOXfVXaMw1dXQ8ffwgyCSIsKvA5+Y45knd72SHny5z3gi1YsMc1 lm24v+OfxfmZMmJQ7TXBDl0JkOMnQ3A+KDb0oGAI6c7BTQRd50gkARAAt/NqfDSMph828JIn VOck27zsyT12AHRLIhsCCatw+zYbdMSLTW6hd/sChStdndAQlqOOW3mpm6bA+jl59c4OhkBW 8fDKgaWjVq8kBm4Z61zhzk3oXMmxgQ3cqMEfN36PCpcfs5MtLiMoa2JxaqFMQbKkmcZqz8fw qGIID/SMI5qdk+yWZSmR+6RdzXfppEIeqs78qTFxaEl+0MlAcgo2AjrMPLIjNK3k4jNAVCix KjMfkkPk6xVmP5Q7cr1st0xTTa1APt0y966oa6CZIdHY76D/jLpjJlfalctmEAxmyBqK0ZkK WDkEF+qCqqZ7oSkC1Q0ogBuBffIZb5srleqMz++IutiE4r/LELs7RanXXCRK5JYzZc/uAnxN fCJzqKR5/JxoSnCh0yQNU4FHa78DeD/SLnCu8JwTGkcX9ZUW/ZQ+5Nsimy+SlZb0UyaWA+vr Q7+F7OAL6PFsE8v+Q2u2EHwa8e2KmsL0sC+enBXbaogLFFfKi4I13vOk+76nCZTNetRhAubM etLe1PZZ0IDzgGhjFg+cc/jptq3qYjK+3jzhdKaqmoibAoea3E/5HsTVVbxUiYEdk2crTqf9 Mr5S5AzQfH19xU7uUduBvjN3L0dRKP0wJEqgCIB5gZBjD8AYmKSgdEujDAPQNXTJgwB99C+r F0XoHEmO6m9vI6djzDsAEQEAAcLBfAQYAQgAJgIbDBYhBEiS96LJeWJsf8PSNR2gKkmm2g9a BQJlYwtcBQkLPio4AAoJEB2gKkmm2g9ah7wP/jP18+dznONUt3Nga6XKYxxlVmVnMlqHx6SB jDWTwFzcQ6UeVVUmODWBSLI+iqg5djkgsTcHwI668qhIyyWaXC9ld+ONhUaE4NH1PKcJ8cdG vzhdTG8lM9mwmnJriTfih59OLI2yKpml/et44gvsfQpmFOyrdH9u6xPai5h3KyOoXD+Q3EzQ KEiHqs2x0PX72Jz4iVKEanP+qxEwzarUUcum94ecGilYY4jfxhfkgwBWjmC7ExbVTSEKIx3Q zdDbDiAxhAWymSisP3lbYqRo8mkg8r2emNan5L5Xh1b/62zmMO+p6gzucV7vO0VJxlKuUkFW 77Ug+X+hkDedvp2oRBz+wKtBxwSxlTM4toD49Jn111OMS6R5opquZP+/SJH1njSKY9MY3D3D 57QDpRUvqbqMDdqZqmYlMxntxTJ+0yksR61/t62F/bSp4XLxbgwCXMm73TxGrU73ngaS/Nxz Pv28VEcCGXZqFS2sbsbBSEjGgPhXf73YlI1fYiAFiaKHKvlofX+xNLeRHr9/+fL4JWPFurGi WYMyVA5Fv1sfefXhdEv9qNlhyNHxxB3vEpxkEOdo0JUhNfIcxe/w5iOfCUAtwUfvijvHUFHh U5QeQckJZTApjJ4S/Wa1ef8eS/LBsvG9xMNG3Ns+M+xR6unu6gTuzUNp7Zsxgmp8hs0racLB In-Reply-To: <95b614577f5475a919c878d6906d721004c83584.camel@surriel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C237A140002 X-Rspamd-Server: rspam12 X-Stat-Signature: d9uct5bi6zmekfpsn8w9mohp9zok8ycz X-Rspam-User: X-HE-Tag: 1735744774-365671 X-HE-Meta: U2FsdGVkX190v9Zl0TyFJFW3HDijvHovp/8lhQJh73JXv5IjmAipAitZBO7AEPdpcd6/b/Z6JbhxmqyKNDt7d2pl2DcVAYk9ulrBC6c1WaX6FGdWY136VeWNI/NJ3T6G0ljyqlFFlpG02FHZw0pVWBzpd/GZMSEE3eT0DriciSCU+vbAPk47vuuB2IG3q6o31aGpekmcDQm7np0L091wLdSsLFJmVtjvcz40LFhQhSqjP2wOAH9T4yINKhWTUqa7d47tygB/Hnu4bEBg1NitMeKF3b4jEY37Og9wa/upkeSYuKeeIo9zZ02Soy6gIe6xAoBbY9dafV7r3u4740vCRVi4UJbwy56TynTeG/sPjNgfi60kwQX8esbtwB0LEcmd8xt/loC9+E7mWT+nqq7/E2HNY/h3DfQ+hxmwfCN5BgtW6NUzXRspIHBifyxV5xhAPfbF4u/U44GmHPc44W3dU4tHMgmAafbq1nso9Ldsw6AKkiWCBT9xdmaGJVKWU1+MhzXWXL4Efp6xVfFe7pxYtxaTQ7YcyQABKAkxiXK6jJ2X5Xii5JZlUcsBicUdBN3+JlQcZYIMfBGs4woI+V2OLj1gx4krf4gIHQiIT6LyT2S5QsiPbTfIArJUDR3qWtSoq8EQKMeVsHZE4KboWUTwtonda7B8ufO0MW2/pXaChPlMgCNfqWeRUkFXWfLkfnP73SSor+TGyZRBSFB2nwAyvGEaMztEbcjX6mI0AmIqUOxqBRZ71DoSqN266EG1mmdf+1CiTtThBE1veTSAG44/hAnl0ey7078aGdXFZQ8i1R0oI2NAPGQew4wseaOW3B+0x4kZZbCcGrJN/tICvc8ZqWhS1LhqGhjpKU8Nx5gcLlM+TLMUt0Va9biFNAyTRNd6IEWvDhgsfgwKdbhgKPS0ttpX8ZlGuHT5CLlg5bQjkoWTtEzCsQc0VVmY1OWWgeLK55AHpo+wZUyhXFgEkGG kTK5YZox aCiTaBrnFFfKIwqIUAmHQ7LuoTr0iO+dUnXnvfUJEI/VFaqxnTOkMAPvcuX1v8+eCrC+T/XCll4luG9S3EQXMQExakHy+KEJ07WLKX+1H/ZErEIEzOSUseGh1B/BT/It+CNPW48YNhYLu+YVVbD1USOI42w38HAePQHxVNpfLiEJa+I6sIJIjJefo+FqRmA1O7uTOKPE91N7uxEJk+bs41tM9Ht1qHeffigwYVxce62hhCxUYI6uj6VnRqNKE0AmDiAafX+md/MNH3D3ihakKKXKMTPcImBVGevlUOdbs9Q5Lm+3FQAWTmkWfCnMOQFA4L6KF1+Oz3QnthCqEwhU5dMxtGAWoIhAriVr7ySABeh4IipqqomN0rJG32qQT4MDCGmq5PXSfF/RKQ6KFO+ig+9+y4/LismshBvgd3O5UbTecCwSUU3Az/Ow1fw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 01/01/2025 6:42, Rik van Riel wrote: > Fixed for the next version. Thanks Rik, Admittedly, I don't feel great about my overall last review - it mostly focused on style and common BKMs. I still don't quite get the entire logic. To name one thing that I don't understand: why do we need broadcast_asid_list and the complicated games of syncing it with broadcast_asid_used. Why wouldn't broadcast_asid_used suffice?