From: Lars Persson <lars.persson@axis.com>
To: Vlastimil Babka <vbabka@suse.cz>, Lars Persson <larper@axis.com>,
<linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
Cc: <linux-mips@vger.kernel.org>
Subject: Re: [PATCH] mm: migrate: add missing flush_dcache_page for non-mapped page migrate
Date: Tue, 26 Feb 2019 12:57:37 +0100 [thread overview]
Message-ID: <24af691e-03ab-d79a-ddbd-7057dcf46826@axis.com> (raw)
In-Reply-To: <2de280a9-e82a-876c-e13b-a2e48d89700a@suse.cz>
On 2/26/19 11:07 AM, Vlastimil Babka wrote:
> On 2/26/19 9:40 AM, Lars Persson wrote:
>>> What about CC stable and a Fixes tag, would it be applicable here?
>>>
>>
>> Yes this is candidate for stable so let's add:
>> Cc: <stable@vger.kernel.org>
>>
>> I do not find a good candidate for a Fixes tag.
>
> How bout a version range where the bug needs to be fixed then?
>
The distinction between mapped and non-mapped old page was introduced in 2ebba6b7e1d9 ("mm: unmapped page migration avoid unmap+remap overhead") so at least it applies to stable 4.4+.
Before that patch there was always a call to remove_migration_ptes() but I cannot conclude if those earlier versions actually will reach the flush_dcache_page call if the old page was unmapped.
next prev parent reply other threads:[~2019-02-26 11:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 12:32 Lars Persson
2019-02-21 17:10 ` Mel Gorman
2019-02-21 20:36 ` Paul Burton
2019-02-25 15:07 ` Vlastimil Babka
2019-02-26 8:40 ` Lars Persson
2019-02-26 10:07 ` Vlastimil Babka
2019-02-26 11:57 ` Lars Persson [this message]
2019-03-07 14:17 ` Lars Persson
2019-02-26 9:23 ` Anshuman Khandual
2019-02-26 9:46 ` Lars Persson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24af691e-03ab-d79a-ddbd-7057dcf46826@axis.com \
--to=lars.persson@axis.com \
--cc=larper@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox