From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01EAAC77B7C for ; Mon, 17 Apr 2023 15:47:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 44CAF6B0071; Mon, 17 Apr 2023 11:47:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3FD126B0072; Mon, 17 Apr 2023 11:47:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2EB798E0001; Mon, 17 Apr 2023 11:47:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 20E5C6B0071 for ; Mon, 17 Apr 2023 11:47:51 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id BFE5916061E for ; Mon, 17 Apr 2023 15:47:50 +0000 (UTC) X-FDA: 80691313500.24.CD4B5EA Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf15.hostedemail.com (Postfix) with ESMTP id 28884A0011 for ; Mon, 17 Apr 2023 15:47:46 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=mvLhMZoW; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=PSseswos; spf=pass (imf15.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681746467; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gWaGp6h7eG3pYrSv/bO1HCdBjKN4Xw+BSEvICpcpi/4=; b=6UuRidWjgeBOUOREayCXWZ4xp3vH1MVWJDHW8WXey60NHQ78ORK1r0AzI6rRtXEO/C4IuY PoD0Fw+ITbOJ0hySTqB5OS834l6liTsWTQ9Tjw+h3sJyC6QK1I/70QcgzfXz4UZ72p44VY 8exjBiOLyy3lZipkVUX0fQ7zBY84YVQ= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=mvLhMZoW; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=PSseswos; spf=pass (imf15.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681746467; a=rsa-sha256; cv=none; b=hDQzIN96JiNMhQ6ALYnIHVsojiMKqYV1WT9t1FYg7UQgu7yTyryKJmy5WWFMeRuyYqtCvU ZMzxL0KtQnnZvnOWEnmT3mJSFUayycHUxd2b+IzvMDu5pECyPfMf4ry84r0XPLXm3Ij9D6 efvF9Eh7hRS2Mhto4VkEOSIsbK+acg4= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id AD26A1F6E6; Mon, 17 Apr 2023 15:47:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1681746465; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gWaGp6h7eG3pYrSv/bO1HCdBjKN4Xw+BSEvICpcpi/4=; b=mvLhMZoWbebI8r+gQzEh+wSPI224Hxq7CWXkL7UiY/2/4m1jRLfToM2I+gR0NPHlCJ6yM6 mc0h/mdJGLUX+3JelZWTphsq01tQ28KugME+WPN2Va8dbm5iBj7UK/avtPPkjAcpV9G4rm RHizf00Skiwqjr+CdRzc34OYMtMiofc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1681746465; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gWaGp6h7eG3pYrSv/bO1HCdBjKN4Xw+BSEvICpcpi/4=; b=PSseswosx2QxDS48lOus2B6NdL8l+v1ajQBpJCOwg2w54gDmKeakceEmmP4FF2EMFq5jYF T9MdNipSW4OndPCQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 84E0D13319; Mon, 17 Apr 2023 15:47:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id uxDYHyFqPWSrPwAAMHmgww (envelope-from ); Mon, 17 Apr 2023 15:47:45 +0000 Message-ID: <24a0219d-b0a1-8b81-ff98-2fff107650c3@suse.cz> Date: Mon, 17 Apr 2023 17:47:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2] mm: Fixed incorrect comment for _kmem_cache_create function Content-Language: en-US To: zhaoxinchao , bagasdotme@gmail.com Cc: akpm@linux-foundation.org, cl@linux.com, iamjoonsoo.kim@lge.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, penberg@kernel.org, rientjes@google.com References: From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 28884A0011 X-Stat-Signature: fpjny3skticfyudnwgfkresftctjct55 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1681746466-459986 X-HE-Meta: U2FsdGVkX1+03BDU94M7KRWdxle+MBzGJxNZ9R5WVdiN7OQ8ssBcXCUgS13W7pG+JNoBr5kawN+pYspxjKnTlCWkwLCZYGpnu5xCRIAZvwxMJRXN52GqPOb64vtJzGMlLT/sRzX3/2kJD2ZrgcT0CdmPUGsHWgnYsb5odobvq9K9um3AjhayXJx0ZGf3rL+/VOc0yjo5jCJ6sZcwhogxMxume/ks6zFvjh4bJX+e0fTuag8h7ZEoRZvoy1khU8FhGvOCTooODvT5emcqQpTJlM+m4z+Uc0rn/XiS87Hh7w8qdcmzH2X3pKpakIw8wx8oRoBMxaMbMVVepJSkmTKF8Gyq9/Hp7hkqQIIQq9sY+Ijz/h9C0qiNHfRjiBGrlNYU0/815iloe7PiwGL4+s9M4g15w/lCMwBw1Cv1oDbedy4AuWiZ+hK+mUUUQv8o2Ea2H8wceAUaxqPZWTrEL3A0u/JoBecxzSatbH9NERT3vcP9DAccpz50WffJudzSsEFg2OsMmARNrS7HoxySfD1bl+B8JJuAPNUpHhC7nO7IJdDC0+2j1SbqmxXEAEJ5TM2WqeErxC74lXTF7q3/bSLrDEWGAr+tdnnRDEn1HAu37NLxW2y4xT12Sh9P3D+pwv+yf3h7BlTE7ie8lKLDXrCvV32wqSUhIJLpE3V8m9Zj2nNYgiXgK/JEtP042MGxAOnIBk9FTFVekXG5XedMXTTn75jQmPp+uDhzrDlOcdrOzfmw4hNlUfE9KkKRRWGN5Gka2aoMgzj5yroJ1ES0QtEDXFy8WjpjGGJSfwJMEKlbrFok2Pydopkn8nnLxPU22TaiC/+e7u8rdoRjaVaHJ/Jqmu0xr8MQiOpo94Ae6u3ZAP3nGSGH1qb1d611c29yVThlbwUDCz4fSGfvTfV1Ttah8nrd7V2CmRRYIE2yj8tGqaq2hKdbSFWQdgfrg4j1QITYHA9ba1YQS30ihE0t0/4 rJ5UEMFm ahch7OoRP3d3y74kFL10PK9aimgPphMoqbmpTbhhl5WHxGOoMNKXGNrxsxcMPiuAuHJFNVjzd7B6Emfk88/2P7cN4TTHJOTgop8uvg3txbXSJu1CsrImioqseCS0UHrFRSwDxLjgPP7h4f33d1FRxUXy7InL2cVl1M3uTk4iR8kXc/ZUmQk4dy++kTCKqUAw25RWGcP+6xLZvr432aTsP9eYW/S0tTW/ftbObWHFgVwmy6FyPt26aGd5eWssVFpLOIDHHsNHpF55jWjW1wq75prk+sz+BoY5WLrKK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/11/23 11:13, zhaoxinchao wrote: > From: zhaoxinchao > > Actually __kmem_cache_create() returns a status : > 0 is success > nonezero are failed. > > This function has three return positions. In addition to successfully > return 0, the first failed position will return - E2BIG, and the second > position will return nonzero value for setup_cpu_cache function failure. > > Signed-off-by: zhaoxinchao > --- > mm/slab.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/mm/slab.c b/mm/slab.c > index edbe722fb..399daa4d0 100644 > --- a/mm/slab.c > +++ b/mm/slab.c > @@ -1893,7 +1893,12 @@ static bool set_on_slab_cache(struct kmem_cache *cachep, > * @cachep: cache management descriptor > * @flags: SLAB flags > * > - * Returns a ptr to the cache on success, NULL on failure. > + * Returns zero on success, nonzero on failure. OK. > + * This function has three return positions. > + * In addition to successfully return 0, the > + * first failed position will return - E2BIG, > + * and the second position will return nonzero > + * value for setup_cpu_cache function failure. I don't think we need to be so specific here, so we can drop this block. > * Cannot be called within an int, but can be interrupted. > * The @ctor is run when new pages are allocated by the cache. > * You missed that there's also: * Return: a pointer to the created cache or %NULL in case of error */ int __kmem_cache_create(struct kmem_cache *cachep, slab_flags_t flags) I guess we can drop the first mention of returns and fix up this one. Also I'd make this a non-kerneldoc comment (/* instead of /**) as it's for a SLAB-specific internal implementation only. Only kmem_cache_create() is meant as an API.