From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2353C4332F for ; Mon, 30 Oct 2023 14:02:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6DFCE6B01FE; Mon, 30 Oct 2023 10:02:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 68F7F6B01FF; Mon, 30 Oct 2023 10:02:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 557846B0200; Mon, 30 Oct 2023 10:02:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 484916B01FE for ; Mon, 30 Oct 2023 10:02:19 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id CE6E1808C2 for ; Mon, 30 Oct 2023 14:02:17 +0000 (UTC) X-FDA: 81402292314.22.5E81484 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by imf18.hostedemail.com (Postfix) with ESMTP id 1360B1C0080 for ; Mon, 30 Oct 2023 14:02:04 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=cZWbLVLE; spf=pass (imf18.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698674525; a=rsa-sha256; cv=none; b=gW9F3ZgdpSvEOWhe9vcuFWssUm1JxkFmoXbPGVHxNJqAE1VHOrz0lhTzCS27gln2EQXDtR A3gEfXLV5KYnBFGUmmAVw7ocoUz00xunDx2PeyqVaB0dq4OFjVlB+r6ZR1UCWtcVFrNCid Vg0bk6wirCaRQGgt9vU5kMPGLYFbZHA= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=cZWbLVLE; spf=pass (imf18.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698674525; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4pM4/raj46zgv4xk5bfFK6Dn9w2JTEPZCoW46aHiMDU=; b=QmN3UQc+kYUJnCCYHgdiLIjEGLv3ky44st6vAMeh82Jgm2TIxwP5r8Yl69TpiPzHSV0zAf /Fx63qNjkqDHhfrdSMSsLWX0IOb+rrRJH8kn9zpSqLCRvNDu0hCAMNcJKLUiog/PccnfX/ +bfl2VAhWBZxaOobXLdFDxJIBmpgXN8= Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-507b96095abso6451304e87.3 for ; Mon, 30 Oct 2023 07:02:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698674522; x=1699279322; darn=kvack.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=4pM4/raj46zgv4xk5bfFK6Dn9w2JTEPZCoW46aHiMDU=; b=cZWbLVLE/QC0O+hOwlfdT6SH+DAgLdtrstVCK+vu+uXFut5oqRTckZDBiqyauE1Zv/ rT5W9fkDVc5AyJJ+cA8j5eisHdlbHwQtPILWyjZ/2Rz7dPPLUiREw8zXS/QVLXxlsl5w ssnVcrMt+aBjixYrW4G11c1P45TyX5i82wDKJr0zFBedExrOPxrUsIJc5Sw1ZLOr4Wjd K6jefyZ4eaGUaeJMhg1ZssgtaAOBfbdcW8UOpyx/tA4NIGwXO4M41RlJMWJgDBTSKzsb +dTKrmilBnlNyh5lJoIZUJlud2SNRWendOcWAi2rOVftXqgT1qcLcgqPECTZrXhtFOsj XEuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698674522; x=1699279322; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4pM4/raj46zgv4xk5bfFK6Dn9w2JTEPZCoW46aHiMDU=; b=YwkFfYyBVP2K4HtUQtdDoIEMh3M4gD5gzFybmXmAkRZcwA393XH1+IsfOXreQI7O3W qUiCO4He8sfBofBZpvSsNNnyB6nHbtdl4V+BigHtfAmSSBCptICbB53dHV+1sOEdfO9v 7YkNUS0uspJ1aE8Y79wAycRFj4QV5Slj3rQCk0waGRtWYz2UVi3KADsNpRiQHc3sQKZU 7E4KjduHUEkf+JpXR1yn9zwuzQsAuNpAyhbi/c3eB2j6dPBtLionecuTtas36xkFMtmH IkR5GjKi89yQK3SjEt84Mvo5z6WPwjhHUFuAyVOhTYMYEvWzer1JqwAaR2kT9clIXZiG h31A== X-Gm-Message-State: AOJu0YyRcXIwvwmJqcPVsia7+Xt4C8SLubAh7zW564yUBbA2N07P06S+ v3veWzlUHpgG/fi/73iFZbU= X-Google-Smtp-Source: AGHT+IExXDR5h/gb2Xkd0IPxFcJr1nDMGyjwni4lSAmtf29yb2qVdb4yT3orag51W3s1lUikBA/nsQ== X-Received: by 2002:a05:6512:3a96:b0:505:7896:18de with SMTP id q22-20020a0565123a9600b00505789618demr1445170lfu.45.1698674522086; Mon, 30 Oct 2023 07:02:02 -0700 (PDT) Received: from smtpclient.apple ([77.137.74.70]) by smtp.gmail.com with ESMTPSA id q3-20020adff503000000b0032d09f7a713sm8316888wro.18.2023.10.30.07.02.00 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Oct 2023 07:02:01 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Subject: Re: [PATCH v6 0/4] riscv: tlb flush improvements From: Nadav Amit In-Reply-To: <20231030133027.19542-1-alexghiti@rivosinc.com> Date: Mon, 30 Oct 2023 16:01:48 +0200 Cc: Will Deacon , "Aneesh Kumar K . V" , Andrew Morton , Nick Piggin , Peter Zijlstra , Mayuresh Chitale , Vincent Chen , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Samuel Holland , Lad Prabhakar Content-Transfer-Encoding: quoted-printable Message-Id: <24E0FC81-810E-44FD-9494-CA9374E495B5@gmail.com> References: <20231030133027.19542-1-alexghiti@rivosinc.com> To: Alexandre Ghiti X-Mailer: Apple Mail (2.3731.700.6) X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 1360B1C0080 X-Stat-Signature: 76cpa63zaaki6gqcfpu8md9gngkdqoai X-Rspam-User: X-HE-Tag: 1698674524-799471 X-HE-Meta: U2FsdGVkX1+vhVPVNgvGi5gCKwl8t2FEwELp9+m1nMbNMrHaykZzKCA6TP3yJc34TaWOUEUV0AVpj2afXXqczCuXQ7vHjeAgKvyxuw+TzIRN44MgXZ69TKazmEKp5nwv1oDwUGhhTWOILmz0HzzlgVcZcVbXyB/yWKZSAjfpeW25/FELYxxWgWsuzFnFbZnzENLQCLb9eWBl1i/Kb7sm30uA1598crrghDL+N7QE+lRhwMP3iEl4wjicdFKr7jVu9LQvNvaoIbHBK2XxgAMHRCEEgbp3PzChrI4dlM85RiaVo50Up2puFkuyXW43ih27bgitx/EVCHpQTS56i0Pt3rohDt4GTy9FRxPrYpqjR3Xv8L+UdU9Cs4LMPviEOGrOG4JpbHOUzYfBdEyUhy1nZVcSQodsJ2JnAjZlvRVjFFEKO+ZJ/xPchyz+VKo6t60Pu2n5GDti2LoiOD8tk5tZpc9LMoyCiPs/vvGh2v+G+x4z26/HJjNuL8xp3bPXiAKGn4EdCrP9DN+QuDpcooxN2vCovL8efxxu6FaZzfFOGnj9v2RokWs6Z4/ZXATYlgoYT6ZsAWe4GqIbeQ7td2b5PMFryvlwBgxoxebsniYSUdCYlyB1R7ieTcsah2DuGdZ2rQKsALrcIAMGl2Pn2sXhPqJ0r1+HDR4YaqAf3DERfGewtQByaVZ9CQ/nfsk9RcgdJKG0Qykh3lqb39XMMOBVABhY8WW+pj+XvRea5OUu8/Tnzo35eriMGmw578JB5lQJHWe9tLPgsliFmYrgC/6G5xQFltLeD8lJPsDiGx0/7U9OQv+JcojHjcaUYXhobhwWYMHFoOUkU4iwVtIr4gBaBk6IlqnhDMa63OQa8KBNWw0CyKoz2xBBKLQirQLoh8AvhuCjZHhoMza4RVXGwJMax01fIaQag+QT2VQ9ZAF1MKJVx5cJLH+ux2WfyvLmrnnsILgs9H0AcCAt0BFwOTr wKyhRLUa BVTfCqFchgv9XBLmy0M1ahta8kfc9FQ+PhgaSCmPv+6xBuhiSBIor/LtkqaHQqr5zJ3PgAVnNznNIYRFH23+DTc3lxqIqwhV2BNKoO4FcCr9yNYL1Cq0rDnsjCMzPLKnMY4s8BizBx+CcESsDrV8Ng5VLT6KqN+8+pvVReSe5Jzq2S9roh0fNXJbKh2Q8CuffJgEc+ya8ymd7AFRhTdSudhTWHOkzdRbTvGXhyAHnR6sVd0cTMdW3JG/W+GGPWA/ZBzvUTObotgwGVyFxkHlSI62yCtPQ1jOfjaVw2kQBNnuvqGbUJl8yMDpbdoJod6ZYswXIGuZgE50sl3SEmXKR4z+678z+pgP54cofj4/Tax38fWsgaVJu86/DSlp11KxI3JPNcjf5PYwrfUC1rxUtNmVQqiKwmSmQ7+O+p96C+r082GOh6QtjxbOSYQPbfxpab9xOUmlyB53exADsnQuLHGG+id6ClPB/KIMB4UDIf162OktT0vQcIPqWoPLT9Y8qJGugthvZk9EtyLcWN/fcQQd53NxbwAdmaKDuYirSS1TFQvjRBMB0GlojIFMffzcTBzlZ/uyI2MOpnjQAmnXVB+M5Rk8KEv6kEzSQ78kBBpaPLMdCl65ayhOqCw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On Oct 30, 2023, at 3:30 PM, Alexandre Ghiti = wrote: >=20 > + on_each_cpu_mask(cmask, > + __ipi_flush_tlb_range_asid, > + &ftd, 1); >=20 Unrelated, but having fed on the stack might cause it to be unaligned to the cacheline, which in x86 we have seen introduces some overhead. Actually, it is best not to put it on the stack, if possible to reduce cache traffic.