linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Muchun Song <muchun.song@linux.dev>
To: Yuan Can <yuancan@huawei.com>
Cc: Mike Kravetz <mike.kravetz@oracle.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, wangkefeng.wang@huawei.com
Subject: Re: [PATCH] mm: hugetlb_vmemmap: allow alloc vmemmap pages fallback to other nodes
Date: Thu, 7 Sep 2023 14:37:25 +0800	[thread overview]
Message-ID: <249C32BD-0CFA-4709-9953-DC4449B92519@linux.dev> (raw)
In-Reply-To: <20230906093157.9737-1-yuancan@huawei.com>



> On Sep 6, 2023, at 17:31, Yuan Can <yuancan@huawei.com> wrote:
> 
> In vmemmap_remap_free(), a new head vmemmap page is allocated to avoid
> breaking a contiguous block of struct page memory, however, the allocation
> can always fail when the given node is movable node. Remove the
> __GFP_THISNODE to help avoid fragmentation.

BTW: it is not a fatal error, so there is no need to backport.

> 
> Suggested-by: Mike Kravetz <mike.kravetz@oracle.com>
> Suggested-by: Muchun Song <songmuchun@bytedance.com>
> Signed-off-by: Yuan Can <yuancan@huawei.com>

Reviewed-by: Muchun Song <songmuchun@bytedance.com>

Thanks.



  reply	other threads:[~2023-09-07  6:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-06  9:31 Yuan Can
2023-09-07  6:37 ` Muchun Song [this message]
2023-09-07 20:31 ` Mike Kravetz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=249C32BD-0CFA-4709-9953-DC4449B92519@linux.dev \
    --to=muchun.song@linux.dev \
    --cc=akpm@linux-foundation.org \
    --cc=linux-mm@kvack.org \
    --cc=mike.kravetz@oracle.com \
    --cc=wangkefeng.wang@huawei.com \
    --cc=yuancan@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox