From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AAE0D2F7F9 for ; Thu, 17 Oct 2024 07:20:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EAA456B007B; Thu, 17 Oct 2024 03:20:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E5B256B0082; Thu, 17 Oct 2024 03:20:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D22A46B0089; Thu, 17 Oct 2024 03:20:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B3F966B007B for ; Thu, 17 Oct 2024 03:20:38 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id AE866120E8F for ; Thu, 17 Oct 2024 07:20:28 +0000 (UTC) X-FDA: 82682246262.26.827E841 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf27.hostedemail.com (Postfix) with ESMTP id 27A9540006 for ; Thu, 17 Oct 2024 07:20:26 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729149491; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=paNLVp53mrYbF6qArmgEFwhNhaIzQHGE0WoVNZHNzIM=; b=6rEZOvA7/7CMh1JH/Rj3b7xnpw9mZ34ymm2LuYdgCJdXySU4OVFJPKU7nDYWAj4jIjU19g atu9O/yrI86rMCkGHTNuoLDhJZgoCv/jD176+uqZoAxwNXWot0+XIiSRqza3dOW99jFmUW nIXLNB278jC5NktMHXxm9sAAYnHacLQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729149491; a=rsa-sha256; cv=none; b=Ky4AtS02gU9N/0oaNv3thDZjVZHPNIkZ2hUmr8BzCdjB/8WFzKODoOaj8PZzC9yO/Pjaqs fHdGPuyTep4Yr5liInWEcrKyOBt0rRN4OyD1cFHcc3+K0Vh6MTWcqzvWppqfxYBwF2OJnx nFj/FqwxldlACLT2Av1Pg5Az3/CGbo8= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7721DFEC; Thu, 17 Oct 2024 00:21:05 -0700 (PDT) Received: from [10.163.39.37] (unknown [10.163.39.37]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 664883F528; Thu, 17 Oct 2024 00:20:33 -0700 (PDT) Message-ID: <2497f65b-0041-4454-9d72-a1c6699ba1a7@arm.com> Date: Thu, 17 Oct 2024 12:50:31 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests: mm: fix the incorrect usage() info of khugepaged To: Andrew Morton Cc: Nanyong Sun , shuah@kernel.org, zokeefe@google.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, wangkefeng.wang@huawei.com References: <20241015020257.139235-1-sunnanyong@huawei.com> <37ce9dfa-3193-4e11-bfd1-d2c8b60b0090@arm.com> <20241017001441.2db5adaaa63dc3faa0934204@linux-foundation.org> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <20241017001441.2db5adaaa63dc3faa0934204@linux-foundation.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 27A9540006 X-Stat-Signature: mkzzw7cmjswseenqp7m1u5zte9scjn9x X-HE-Tag: 1729149626-303529 X-HE-Meta: U2FsdGVkX1+tcKV++kQKyGRAwdL7QzCBNkKI/9oSlnOfqwabKfKh7j6HhMawTsGVyNEBR81FIpUoUjPJmb8Tw7eNQtrqI2OlD8wC8Cd4heXBXVhPB7V816xbxs2cgSgubEmjOeL47ZKyCbejAwfM+QHxkKygbVL1Qh0rZDHnUJGpU6BIRcRS0n5nYi+qlw0QObWe+RD5J3y6Oc0Rd6WxZdU/BCV3W9Hs1WuKWGpxuEjSVxc+nKBqtf39fp+GUb23k7ADZZAQvY0CO0+b/vfU7iLsMzNH70sM+Zh38pxUPad6n7PTZrYImkVzZSc6GkH6k+ApiqkHBBvCpLVv0rnoBrIhUIu9GSrh1f/09Z37XsErYuzvsDfFh9zi55wFLHIwE/0JQuthZdRSYFE7EVsVvThCsAvHSMZCeKi0txJ2h5qYiTJlpY3nxr6rMihNePWJlT1HKzjGhlTM7r1rWK4oPuhysfl3/paJVcU78zkO7n0jUiRZYXCfOY7FzWFFnEp6/sntH9YxqBL4KJA/LdvgQempOH1qPu/5R8gqHBW8Yx4y6mXwT67kxl3rzo27xCbDqefkrV1KJ+nrlsrrrcHhlPS8dGqeETbpKvbzn5ArM2us2motx7VKe35DjuYbSfzNVrOPEubqH0LCWBibS3kwTir0Sl7W/OotYXX3NUCmZtC/lXSM7y3tQYnKNllTYN5mKA+kC31lEIgChnhhtKaNUJMNoeDJg/tR2nMgxgEbG3qG5ucKZsWyGEmhIWnqwkux0OSW2Y0TXt9Xdk/S0aEfn9Y/sRLKvxkTvkLVCWEfb1MtaKRGiA138cOBAv8W7Y5JFkqEu+UMFBd0PdYDSet9ORPOwSGZxlHvx+/tiXvd7pQgSTPzj3hT6T/9Bjr1HHMpl16WQRzo/mqcokW6pl65WnaLd2Yk8tLRtQDv3F04gScDY1RQJPaFySdA18HVgCJz1hUSiGaQ3p6wwG3C0lW ozE+3/1g BVuZXhYaf9IdVAJPVVbyRGdl3IbwN0RxdnKQNxY1hQIbQpaRotSiKl2nPqdAYNL23fBT/WGwJ0EJ/oTMBtshR3E/rjBlT4/I24U2tmTlxsPr+v4suhy/D9rH9uBt6giofCfHYweCQs+TPJd13CCzI3nAA7UKhJlSx7wvecUkIUDEqYur5SX1QWh7DgrZDskEPAGgDuBxC9oVfDFc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/17/24 12:44, Andrew Morton wrote: > On Thu, 17 Oct 2024 12:31:31 +0530 Anshuman Khandual wrote: > >> On 10/15/24 07:32, Nanyong Sun wrote: >>> The mount option of tmpfs should be huge=advise, not madvise >>> which is not supported and may mislead the users. >> Agreed. >> >>> Fixes: 1b03d0d558a2 ("selftests/vm: add thp collapse file and tmpfs testing") >> But nothing is really broken here. This just fixes usage information. > The usage information is broken! > >> Please drop the "Fixes:". > Fixes: is appropriate. It tells people which commit introduced the error. > > I don't think it's serious enough to add a cc:stable. Others might disagree. Alright, usage information is part of the functionality itself.