From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Nanyong Sun <sunnanyong@huawei.com>,
shuah@kernel.org, zokeefe@google.com, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
wangkefeng.wang@huawei.com
Subject: Re: [PATCH] selftests: mm: fix the incorrect usage() info of khugepaged
Date: Thu, 17 Oct 2024 12:50:31 +0530 [thread overview]
Message-ID: <2497f65b-0041-4454-9d72-a1c6699ba1a7@arm.com> (raw)
In-Reply-To: <20241017001441.2db5adaaa63dc3faa0934204@linux-foundation.org>
On 10/17/24 12:44, Andrew Morton wrote:
> On Thu, 17 Oct 2024 12:31:31 +0530 Anshuman Khandual <anshuman.khandual@arm.com> wrote:
>
>> On 10/15/24 07:32, Nanyong Sun wrote:
>>> The mount option of tmpfs should be huge=advise, not madvise
>>> which is not supported and may mislead the users.
>> Agreed.
>>
>>> Fixes: 1b03d0d558a2 ("selftests/vm: add thp collapse file and tmpfs testing")
>> But nothing is really broken here. This just fixes usage information.
> The usage information is broken!
>
>> Please drop the "Fixes:".
> Fixes: is appropriate. It tells people which commit introduced the error.
>
> I don't think it's serious enough to add a cc:stable. Others might disagree.
Alright, usage information is part of the functionality itself.
prev parent reply other threads:[~2024-10-17 7:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-15 2:02 Nanyong Sun
2024-10-15 2:34 ` Baolin Wang
2024-10-17 7:01 ` Anshuman Khandual
2024-10-17 7:14 ` Andrew Morton
2024-10-17 7:20 ` Anshuman Khandual [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2497f65b-0041-4454-9d72-a1c6699ba1a7@arm.com \
--to=anshuman.khandual@arm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shuah@kernel.org \
--cc=sunnanyong@huawei.com \
--cc=wangkefeng.wang@huawei.com \
--cc=zokeefe@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox