linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Oliver Neukum <oneukum@suse.de>
To: Ming Lei <ming.lei@canonical.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-mm@kvack.org, Alan Stern <stern@rowland.harvard.edu>,
	Minchan Kim <minchan@kernel.org>,
	"Rafael J. Wysocki" <rjw@sisk.pl>, Jens Axboe <axboe@kernel.dk>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v7 0/6] solve deadlock caused by memory allocation with I/O
Date: Thu, 17 Jan 2013 10:44:17 +0100	[thread overview]
Message-ID: <2496969.ClbQ8gLATp@linux-5eaq.site> (raw)
In-Reply-To: <CACVXFVOipr0VMyPQaZTLckxTaPan7ZneERUqZ1S_mYo11A5AeA@mail.gmail.com>

On Thursday 17 January 2013 09:28:14 Ming Lei wrote:
>      - we still need some synchronization to avoid accessing the storage
>        between sys_sync and device suspend, just like system sleep case,
>        pm_restrict_gfp_mask is needed even sys_sync has been done
>        inside enter_state().
> 
> So looks the approach in the patch is simpler and more efficient, 

Even worse. The memory may be needed to resume and the reason
we need to resume may be that we need to write out memory. And
there is no way to make sure we don't dirty memory unless user space
is frozen, so it is either this approach, or GFP_NOIO in the whole resume
code path.

	Regards
		Oliver

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2013-01-17  9:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-05  2:25 Ming Lei
2013-01-05  2:25 ` [PATCH v7 1/6] mm: teach mm by current context info to not do I/O during memory allocation Ming Lei
2013-01-05  2:25 ` [PATCH v7 2/6] PM / Runtime: introduce pm_runtime_set_memalloc_noio() Ming Lei
2013-01-05  2:25 ` [PATCH v7 3/6] block/genhd.c: apply pm_runtime_set_memalloc_noio on block devices Ming Lei
2013-01-05  2:25 ` [PATCH v7 4/6] net/core: apply pm_runtime_set_memalloc_noio on network devices Ming Lei
2013-01-05  2:25 ` [PATCH v7 5/6] PM / Runtime: force memory allocation with no I/O during Runtime PM callbcack Ming Lei
2013-01-05  2:25 ` [PATCH v7 6/6] USB: forbid memory allocation with I/O during bus reset Ming Lei
2013-01-16 23:37 ` [PATCH v7 0/6] solve deadlock caused by memory allocation with I/O Andrew Morton
2013-01-17  1:28   ` Ming Lei
2013-01-17  9:44     ` Oliver Neukum [this message]
2013-01-17 21:57     ` Andrew Morton
2013-01-18 10:22       ` Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2496969.ClbQ8gLATp@linux-5eaq.site \
    --to=oneukum@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=davem@davemloft.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=minchan@kernel.org \
    --cc=ming.lei@canonical.com \
    --cc=rjw@sisk.pl \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox