From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88FE8C54E71 for ; Fri, 22 Mar 2024 15:13:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 021C16B009A; Fri, 22 Mar 2024 11:13:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F13CD6B009B; Fri, 22 Mar 2024 11:13:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D8CAC6B009C; Fri, 22 Mar 2024 11:13:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C88646B009A for ; Fri, 22 Mar 2024 11:13:21 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6829214052A for ; Fri, 22 Mar 2024 15:13:21 +0000 (UTC) X-FDA: 81925018602.08.231C389 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 0E7B41C0009 for ; Fri, 22 Mar 2024 15:13:18 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="K/IEPDTN"; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711120399; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lYld5p/VCeSrMUznGR/p3X5X3n0WwiN1FlKMIm0o1BI=; b=qun5jMuVrdzuGEaoSZ6VRkCdnKORIfFVBlhb0sJQTUDviLZ78iMw3OReVES4l2jAJmOo70 NRHaeUQtlu6Ojk/i7jdKSr8af6mvNtndBKuAOZls8fDWd24IresKWcoiku/6JTSR/4tiYD P9URsHccP5wPWtZ5hVQMjXbrZzelA1s= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711120399; a=rsa-sha256; cv=none; b=RwrZE6D2BbdQSNo018JaXz/EAPMj26/zSayJxQ61WH/+8RHpuIx/4SnK2TCD7kG5MaLInU dmTr/ofUktlYBt3ETyG7Nz89zQLBQd741ob+4a/sXIpP2QftNEzCEaXavmx0O4NFTzBaSH L+MMwnMkaEk5gV22xe/mHin3SYMzFwA= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="K/IEPDTN"; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711120398; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=lYld5p/VCeSrMUznGR/p3X5X3n0WwiN1FlKMIm0o1BI=; b=K/IEPDTNnhEj5itcUWBiQpzOjRVlGPxXUPDewPTjk4B1Htv1l3htKF+hqHc94IQ+sy9D7y Y/gbTrVXFsTaecBNGGMaPIrK6UWyHLLvREYiViNqNcHLOQENk/XxQzU1T9LO7DVbp9pj2E 1iDGNzNZTemF5gWaKkLfwgaoeMjc2pk= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-649-DO75eljlOIuTQbHe4IAK7A-1; Fri, 22 Mar 2024 11:13:14 -0400 X-MC-Unique: DO75eljlOIuTQbHe4IAK7A-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2d48e62e525so20557341fa.1 for ; Fri, 22 Mar 2024 08:13:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711120393; x=1711725193; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lYld5p/VCeSrMUznGR/p3X5X3n0WwiN1FlKMIm0o1BI=; b=TlNjbmJgoSL9yXUURODT3atmJVBH7D5+DZmgqpubXGG51vaP4YanXwm/6b652XWWnX joP+3kWkrDvCSmglM3QzAC5P+dxzAxP/OjZLSpQWpcttwdbQqkrGAqNXW6sujf2tMsXi ZhzQWyhZ9GtSgdHCLGWWgmNNWnQQQPmd9pPFJawM8IrxgdOEBWjsPP8gTmfm5/1TVibh waowOS6qZbBBMAx5GBBm6IRikDQA7scU2NDc9WxSNNWxAB9NpHUP+QsiPVmT7mT9iWMh FQ1ETnwhl4t260WbS55m/xM/RgKM9TrKCBoZi+oVATf+JNm3q4JUoBm0fR55KZ8/F7gv mSKg== X-Gm-Message-State: AOJu0Yy8dei6/GWnWU8CwxwxDMusModqSYIwbJiz1VJw1FEP2NLaEuxB NSZJpzXBeB5TF/kC0emBnk9MVFxNGyA6W2vcrdfCqZUj8AvU4caYU7cs30owshon5ZWWdfRpT2p eikHYL/6QxIK6+mEcJ0rR9NAV73NSnzarNZDkZJm9IX7Q5n0N X-Received: by 2002:a05:651c:49e:b0:2d4:8117:71a9 with SMTP id s30-20020a05651c049e00b002d4811771a9mr1791322ljc.16.1711120393001; Fri, 22 Mar 2024 08:13:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHaVFjerNkd9vLtcJTh8OrDWydEvutiluz35M+gl9FYqc7SkzbBdxyrZ0xN6PB/gDGJfmDi6w== X-Received: by 2002:a05:651c:49e:b0:2d4:8117:71a9 with SMTP id s30-20020a05651c049e00b002d4811771a9mr1791299ljc.16.1711120392451; Fri, 22 Mar 2024 08:13:12 -0700 (PDT) Received: from ?IPV6:2003:cb:c71b:7e00:9339:4017:7111:82d0? (p200300cbc71b7e0093394017711182d0.dip0.t-ipconnect.de. [2003:cb:c71b:7e00:9339:4017:7111:82d0]) by smtp.gmail.com with ESMTPSA id p17-20020a05600c469100b004132ae838absm3299664wmo.43.2024.03.22.08.13.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Mar 2024 08:13:12 -0700 (PDT) Message-ID: <24965785-9b56-4c8a-bad5-ae2545deba8b@redhat.com> Date: Fri, 22 Mar 2024 16:13:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 9/9] hugetlb: Remove mention of destructors To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org, Vlastimil Babka , Miaohe Lin , Muchun Song , Oscar Salvador References: <20240321142448.1645400-1-willy@infradead.org> <20240321142448.1645400-10-willy@infradead.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240321142448.1645400-10-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 0E7B41C0009 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 9fdrz7zffxgnh5myc6wd4m1guknkutyc X-HE-Tag: 1711120398-72539 X-HE-Meta: U2FsdGVkX18C2js8DFcxjSekdB7ZESWF9L1OOdfP0R/vZN3Vwe45m0Ec/pGhI4AQqZ58FW3xCceHbUUeQiJnFw6g0zE0MNJjO85yCNPnCNmSFCQ5s62sAKR1YtbJAPTNMOHdCgFs4hd5RRD3Qj2YgBTBL+BXxXLNQw+Kg1/nMSwYeYR5/7/Oo9gOxPoP1hY7vvN2WYxk1INgY/dgn3P2i2mYtU1BsQNjSCV7qnK0bfWvqjOOcO//SZbnp0SI+mNJISjarA1llOWMvCB1l2KtbMCuFYmZNUG1eNjcNLI1mEKdXWDx5hQMPyRvcMd0ALqElHz8dFjgQJLZDGxI6JB+uoQN40/qwbTXE7XdMxutDRx5Wx553Fth0aOR9j+QY0l6DcnvQMowZy02mJNcXp2cHLjNtxa/1bQxYhJPpvN7Kx/H+ydOCDS1qQp7U7DrobOkWXE4ATkh/X/JYQejoQEr+k7FITbkIJQHgWfi4nFrVzmrz7+0QlTYfKzdn7zgp2JfaZA9efSkn7uhAMDW6vU0D4+simawfOXLWMJpZkwaH6+bqTbwWoIMpqh3w+TgDg/klNvV0pNdh8ccgV6VnuVhZ2AEd37rJfGgbQE8BC+Ad5Fb3dVmpWw9N9waIC/O7PNNNvH/Yck5UYot1q+cpjgfWXQ6fzcJJGpDf2I0JNmmAyIm8+AF98PLuwfWMS3DmHttvrRlzD6yQd5WVtpaQ+MKEvvmKKiwOUmxYsUIINpRNBYl5KxXkJnXzosKVQ1GHFu8F1HCmBqf9DqMPzo+5J787hE23w4MD1UhrVWEh7T8qiAQG2zzv6cyTHBNa7Spp4d1BV3cV6BaJDPb0oz4E2Mw+jSvaonHkkeTpqjKn8VC/yCDdjTBHsiRonFLYKt75PEhlIYoFJjaCAj7Y0pzkjsj2tyT5Ixn3/ToSbOV0fq0chgsmhURz/7sV8iTIRXxYe9rqUuf8eUwof263kdYTjp ldnkF94M zDmog9vLpafBiRstkj42xWtm1yvoT3S7XGGytxF3a02YlNVIEMO9sbYFQu4HuBU5mZBg05f+RcMuymJLM6Bdca3FdI9fHgm8T32KOW0CAzmWDdv3zYmGZI7CbGMTpYRIs6E84Dt5JicY7+XiS3eavNS68xxQctAVPY2hKKAwB1V6d3/LuJ8Fw+B7L+F3C+mI5Hl4g0qOxR2ddC2ZRayWwUkc2xmD2UYULddL/R3Gk8Gsrfy2sB8DyEiQ5oXtiXhzPyIuWITRLak4UjDX0Nssu82Ux4+TIg3igR4f5Jh3Plv/88Nlk1vh6f7Px5+wCOTZfe1ksjgFPkJyVBnJhVGicO/UWjsR2ybQCYrurB4WXsFdzET5guj1fuxLo1wXo2MMZ6fDigi3w+yM7TAB5GkWQmNnY65Gzk9l09Ftkh3DF6EufQ8rAEfZA8/s3KHQSzmhSJn43wK/0xhaYybMFq5wll8BOKZOBRfNJMxy7tzOIiYxjamsybiOptbWoOw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 21.03.24 15:24, Matthew Wilcox (Oracle) wrote: > We no longer have destructors or dtors, merely a page flag > (technically a page type flag, but that's an implementation detail). > Remove __clear_hugetlb_destructor, fix up comments and the occasional > variable name. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/hugetlb.c | 42 +++++++++++++++++------------------------- > 1 file changed, 17 insertions(+), 25 deletions(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index bdcbb62096cf..6ca9ac90ad35 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -1619,19 +1619,11 @@ static inline void destroy_compound_gigantic_folio(struct folio *folio, > unsigned int order) { } > #endif > > -static inline void __clear_hugetlb_destructor(struct hstate *h, > - struct folio *folio) > -{ > - lockdep_assert_held(&hugetlb_lock); > - > - __folio_clear_hugetlb(folio); We're losing that sanity check, which is a big unfortunate. But hugetlb maintainers can decide if they want to keep it. Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb