From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BAEDC433F5 for ; Tue, 28 Sep 2021 10:39:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0269B610FC for ; Tue, 28 Sep 2021 10:39:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0269B610FC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 925BE900003; Tue, 28 Sep 2021 06:39:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D50E900002; Tue, 28 Sep 2021 06:39:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C4A0900003; Tue, 28 Sep 2021 06:39:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0109.hostedemail.com [216.40.44.109]) by kanga.kvack.org (Postfix) with ESMTP id 6C12F900002 for ; Tue, 28 Sep 2021 06:39:26 -0400 (EDT) Received: from smtpin34.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 32A562FD96 for ; Tue, 28 Sep 2021 10:39:26 +0000 (UTC) X-FDA: 78636635532.34.B654B8E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf12.hostedemail.com (Postfix) with ESMTP id CF6B110000A5 for ; Tue, 28 Sep 2021 10:39:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632825565; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DYyRP8f2WSPXLKn2r0atH4kHz0+e95PC/BIsP+3v9Vg=; b=cOKwPAdKIHBthVhsOxqm9VBtu1ybeDbzFsjoAyjOaLL1zrCWfLkbTlNvlTCDSB1iOnSJho XsY+ZbzQ5wwOcAfT7lZL/sXZza5YEA4wllQ1Kos8j1k6S/8bgSLRbhG/CJ7VBvohkgPByu iKZO68IL63oLttOZAzUWDAT7nmmlbRk= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-324-gXHYDTA9N56QjrmWpfUb2A-1; Tue, 28 Sep 2021 06:39:22 -0400 X-MC-Unique: gXHYDTA9N56QjrmWpfUb2A-1 Received: by mail-wm1-f70.google.com with SMTP id y76-20020a1c7d4f000000b0030cf1eaf5cbso912259wmc.0 for ; Tue, 28 Sep 2021 03:39:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=DYyRP8f2WSPXLKn2r0atH4kHz0+e95PC/BIsP+3v9Vg=; b=PZz0CpczKHV/zZuTbFUCPsGwbzLBSrqKQYPGG9EVEwKVyKmb7Pkc5KTvBa9zDdQ0Ko avMc/Ygc6QYF7cBGfAwJI8hwvmT2h4Wqd5qhgCwPf55YROYRs0SAhMm6azBJnpA8E00z rdRbI/3WpkshNJ1oNk0C1zeRk+WlOko0hpXK/FhSEwgDTfCRVHPnjAMjUx4jEd4t3adG 0627iCE1dqkMQ11t2uD2vrPB5UJrh+G8HTnYa9Q/s034ZEmk7t1FGYuBDWORJtrGVAnj j1v9UAhUlGT1yN1+yIBpiAB5i3qD+CY68L2UcCAZ573kI3uBykBJ+kkmMWPtmgH8HSCB 9PqQ== X-Gm-Message-State: AOAM533Nmh5WN6vX+k6+w2YQdzDxpBlM5d/wAnU4Y7yvsyzJvWajNPIN GnxqWFy2Batk+zbq5QbLfzp5/YqDn5YyBYLB0vdMLKh8S5EHW1hHfXg9rgnY52powcU3Xd/JHRc R/pMNIS0UYuM= X-Received: by 2002:a1c:9a07:: with SMTP id c7mr3955089wme.106.1632825560827; Tue, 28 Sep 2021 03:39:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyzCY0Hdy7y3Kl5ZYiOJTlyBidLUskdQBMThtPvr1/Xa9GGJ57rzbqXIsDlLSvJOnzI3ScMsg== X-Received: by 2002:a1c:9a07:: with SMTP id c7mr3955070wme.106.1632825560558; Tue, 28 Sep 2021 03:39:20 -0700 (PDT) Received: from [192.168.3.132] (p4ff23aaf.dip0.t-ipconnect.de. [79.242.58.175]) by smtp.gmail.com with ESMTPSA id x17sm19856317wrc.51.2021.09.28.03.39.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Sep 2021 03:39:20 -0700 (PDT) Subject: Re: [PATCH v1] mm: page_alloc: Add debug log in free_reserved_area for static memory To: Faiyaz Mohammed , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: guptap@codeaurora.org References: <1632819849-511-1-git-send-email-faiyazm@codeaurora.org> From: David Hildenbrand Organization: Red Hat Message-ID: <248ec931-7c16-3e2d-cc8f-8ce0dd4e923b@redhat.com> Date: Tue, 28 Sep 2021 12:39:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <1632819849-511-1-git-send-email-faiyazm@codeaurora.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: CF6B110000A5 X-Stat-Signature: jquhjzie1eurix5skttunc8qh9ie5shx Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cOKwPAdK; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf12.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com X-HE-Tag: 1632825565-113844 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 28.09.21 11:04, Faiyaz Mohammed wrote: > For INITRD and initmem memory is reserved through "memblock_reserve" > during boot up but it is free via "free_reserved_area" instead > of "memblock_free". > For example: > [ 0.294848] Freeing initrd memory: 12K. > [ 0.696688] Freeing unused kernel memory: 4096K. > > To get the start and end address of the above freed memory and to account > proper memblock added memblock_dbg log in "free_reserved_area". > After adding log: > [ 0.294837] memblock_free: [0x00000083600000-0x00000083603000] free_initrd_mem+0x20/0x28 > [ 0.294848] Freeing initrd memory: 12K. > [ 0.695246] memblock_free: [0x00000081600000-0x00000081a00000] free_initmem+0x70/0xc8 > [ 0.696688] Freeing unused kernel memory: 4096K. > > Signed-off-by: Faiyaz Mohammed > --- > mm/page_alloc.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index b37435c..f85c3b2 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -8129,6 +8129,11 @@ unsigned long free_reserved_area(void *start, void *end, int poison, const char > pr_info("Freeing %s memory: %ldK\n", > s, pages << (PAGE_SHIFT - 10)); > > +#ifdef CONFIG_HAVE_MEMBLOCK > + memblock_dbg("memblock_free: [%#016llx-%#016llx] %pS\n", > + __pa(start), __pa(end), (void *)_RET_IP_); > +#endif IMHO, the "memblock_free" part is misleading. Something was allocated early via memblock, then we transitioned to the buddy, now we're freeing that early allocation via the buddy. I would not expect memblock_dbg once memblock might not actually be alive anymore. -- Thanks, David / dhildenb