From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEFF7C282E5 for ; Wed, 5 Mar 2025 19:59:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D2F728000F; Wed, 5 Mar 2025 14:59:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6805F280007; Wed, 5 Mar 2025 14:59:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4AF3E28000F; Wed, 5 Mar 2025 14:59:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 27D65280007 for ; Wed, 5 Mar 2025 14:59:42 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D66B11C8F5A for ; Wed, 5 Mar 2025 19:59:43 +0000 (UTC) X-FDA: 83188562646.22.45DD1A7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 70CBA40003 for ; Wed, 5 Mar 2025 19:59:41 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JiUpEFlE; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741204781; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nZmZJbeQSrqRCdjQiNkr8QO8akLMmV/h+boSg4x+6iM=; b=MDeP5pLQ9wGXa1NdnvZyl7AZ3MgDJFIn59XE89Uqst6Yrztgcne0HLTDNBZgFgHnB/e3zW 7o5cUQ1ht8lqvBxwbNjr0ASnagSt85QCbdwYo4N0qZMbzZn7R8/S0Gynw8yihACd3YZv8V 5wisSKVc6hUlUalXDRsLYmbkcUodL3w= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JiUpEFlE; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741204781; a=rsa-sha256; cv=none; b=lEVwdrbJ88kttgYh+ulhAZYvYhckObvfSjKCO9IBJhIRmAUGb0DSGazpgzjk2x8wzkXEAS xKUsWz9Y5tLfaOdHDNe46yveTEWzjmFKOfKSu0uOtTen/1R7uxB1ZgrN+2oxLRCyYDEnbz xRDqu7PjBPuCMcoLnbwhE0SZCk3iTdk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741204780; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=nZmZJbeQSrqRCdjQiNkr8QO8akLMmV/h+boSg4x+6iM=; b=JiUpEFlExGV7lskjUvZ0Y/D1hn2uaPq1vAp82z7BL+qc5EALhWondJ/SbqnHxUDKViqPro tmMZ08MFWzhMXkQVZX36N9knqheFX2HwMxbuDMDj+QpN1tmhpfI+NlQn+KkRlAYqaA6IbT WW2qEPzW6xHyl6C5hR+8LuNT0M9fp84= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-403-YAoXBpxDOvuPa4qOf9lsAA-1; Wed, 05 Mar 2025 14:59:34 -0500 X-MC-Unique: YAoXBpxDOvuPa4qOf9lsAA-1 X-Mimecast-MFC-AGG-ID: YAoXBpxDOvuPa4qOf9lsAA_1741204773 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-439a0e28cfaso38327755e9.2 for ; Wed, 05 Mar 2025 11:59:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741204773; x=1741809573; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nZmZJbeQSrqRCdjQiNkr8QO8akLMmV/h+boSg4x+6iM=; b=eSJZ/CmgI0MV6qYndBxhDV9xOce2My0cnOsW/56Af1BCOynrNoo7tlsb4vRPdF9DIh 5DOdmv41N765g53Yh5s/xsk5YBKU6gcuWBPvMJpzBpA/Q39sAemBNhoAplzbzS7coSe5 uahNmCUCYFi6OX/ya/opLF6S8pQcPZIHlYgsvMipuu8L8sEytAMvQw6OUEr7wbbIb0Jm TU97hVnzNfwdKsgSU/zf7o4XvdfvCbWcV3/yDAkabadu1IAtYFNmo6OQ0NbcPb1UHfPg 2c2zvwfVbrpbMOSUVzBPwZtZ3WCdb64fcOAF7SrbEeQRG+95VHKaONomEoFJEKjK6rUb gE2Q== X-Forwarded-Encrypted: i=1; AJvYcCVmHfOoaxey6EnxasCKfl0YwK+0Pm01DegUASMIVjXhyQ5NW4XwtyNC9fJr7fpiFoXfMoC26NY/UQ==@kvack.org X-Gm-Message-State: AOJu0YyDEY95dzxeS7aRVROnQ3qCWbbYLlpod3DZjQqP77C9oMa460Yv Nflz8+vM3lRCLOp/YWxVv7X9074DIrl1Cju3hUwm/wGrSjFLNi3kuN17ZSo4Xh6Oq163xx5B0Hz f/wKBrUDsUY1Cchg/WCjF5hUfkmUtKqlNGnXv1h3oyWa6g+S/ X-Gm-Gg: ASbGnctLT5m6VjuLXZKp5Updnd2jdqrwOSCEiOvFRYNBsfXgxTNhmxXQlbkjcDJIqPe 5BPV5vHoyPwW44aACuCEtPkpCaUx3aQ4qB3UXesvln00MuODK2hpp7HmDV76VYjREunE1NYmaYt +ugqQHHuXgkZ2NrNjFvoKs5Kc4AmQrzz31I8N4diI4tJhnfHe+8URj9Q8rGOkvKz3adSxfrSl7K qlqXKEgCRovjAuHdqYCaG4xC286/am/YQ2Sr33RE0Np+vbu8Hta054lzIX3fP8x3IxlbIrhTP+4 O6xvQyqGtz7uIbfTK1OTfXdh4er9FJvh4h+gRum8d4iGsv1HTpB9o7JGBAiMBkvxRDQtsrbXwiS Qemnbv2VmFPwY+TW9MX+7jBsfZX6MjoGbjgfcvhjR2II= X-Received: by 2002:a05:6000:178a:b0:391:13ef:1b0f with SMTP id ffacd0b85a97d-3911f7c3353mr4143939f8f.39.1741204773438; Wed, 05 Mar 2025 11:59:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IE1I+GEM5IEPN5/WQ69b5Iw3kXM57cQdPQPl9xA9chlh/tdslQRtsW67EGy18cq+cCHjacCqg== X-Received: by 2002:a05:6000:178a:b0:391:13ef:1b0f with SMTP id ffacd0b85a97d-3911f7c3353mr4143922f8f.39.1741204773085; Wed, 05 Mar 2025 11:59:33 -0800 (PST) Received: from ?IPV6:2003:cb:c739:5b00:84f2:50f3:bdc8:d500? (p200300cbc7395b0084f250f3bdc8d500.dip0.t-ipconnect.de. [2003:cb:c739:5b00:84f2:50f3:bdc8:d500]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-390e4844abbsm21789810f8f.70.2025.03.05.11.59.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Mar 2025 11:59:32 -0800 (PST) Message-ID: <248ab74d-0f5c-4076-bfb2-a5eef8aca757@redhat.com> Date: Wed, 5 Mar 2025 20:59:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [QUESTION] Plain dereference and READ_ONCE() in fault handler To: Dev Jain , willy@infradead.org, ziy@nvidia.com, hughd@google.com, ryan.roberts@arm.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20250305102159.96420-1-dev.jain@arm.com> <8477d9ec-b9ce-4a3d-b61f-1bd44d3360a5@redhat.com> <3c3f3cfe-9fa7-41d7-9759-cc67306f13f5@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <3c3f3cfe-9fa7-41d7-9759-cc67306f13f5@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: IQnktDPyfljjP7blJW9_aUGTwQOCOejvKPeHN8d0onM_1741204773 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 70CBA40003 X-Rspamd-Server: rspam09 X-Stat-Signature: w863bd7baofdwcm314dp1c3wg1rhu9jb X-HE-Tag: 1741204781-528468 X-HE-Meta: U2FsdGVkX181z0SPaeSjJOjkHz6vDt5tmmzA+khNeOJPFCqQ68/IAB/pm+vuyxK8lY7+0xkoYo/FGUVsmuPe5nR5MuLs1fYGTRrEwMD110AvehQOJ+dG3Yf1GrRiHtENYLFJNn9wTRdS4tAmXzzjowMXf7Sdgtmb40L+PRvcLZVhHcfkNr7dJiTraYJ2AmFNGBt6wod6Id+M/B7VWtAms4znRFMKCRjz3PRflRvj/c2OwaBpIbXL9nf3S3Qm36kYrGahlh5AvVz/RHHjIhR8rs+3lAECaS2shosRGfq3IvMoyDaCp2zEM/CGil1lJnl90MCH4F5Y5Ic5ICf2dxMZdXH2qPNof1ZXLct7628s3u1rhjPTofPW+lpUiSOm7yGGSfIPTJ3y/UIfodF0babnB5YouQuQpk3lbrWA5E5LEIcDezd9+m0vzD7JMrgUz/jQ0nrDeFElNzDFJbITTwOku6A8OLbu1w+frYg+p+PNzFuvCCE6rrLGesb0GL3Zroy/OtHtWiloDZ/bSIX7i0IwIFHy4bqobox/UFXiiJt8qJgHo/mMHAlT2Ya4RFmz7aVNwqXMlp5iGMLb2I7jXSN53HpbFwkmUOjzdZhKoG3oggnz1XLwcY47EJpRS9Rp9sTXhW9dtXz9f1tyR1N8Cty0ALiFamV0Whedo1zWauW1k+hrwDafld8V1bF7BTdnMQ+o8L0L4+HznjhNNZkyqKnWO+/ZICtQ7kjl5zbmhtpNiHuYastx0pnK2PhW3S2gQMghnTUxm0GT7Lvw8itia3FJwZF2R1LnCVDa1JMGfpjvOOAG2lDhnKgtNv0nkL/cJC0/OHlOELppdp+ZawPeFVX8iUwTOjvgF6G6BUQBUQ9w1IvFRABek8e3mCtF5RnrjBdhFh29wJSKp4CYOitHY58XXLraPp6qVOKKXuWsyNbkOl7ikutbAymqRGI0uDOss2dOWtC2YLHx7EmIuaWMkSm 1eAfdzIA MTcBO1gqUx3zVV1rqz0AE1A94MFaDSb+tLA3x+mXTc02aiFA0zMDQgK2I99sfNx2EBI7uqHO6i2GxzEW/2CQQkQdYVa/4Hw9ebIkKfN0B20ec7UZvgS9gpPs13ioAYqU58LyPKfY3iFoPXVSwlFvS9IlrnOEOvkQcqUtCeByhoLDIqSwgqM5CxUEnYMVAO8B7OHBzF0gtXX8Kopyb8b1sum31eWpqWaDGa52Q0quxHhYprcQ96HFR9lLDgTET6d1HEUKbwo33VLJkXpy727Y28JaiwF5yI49+ssuCcxP28xxkTQEGZ9Vw3x4+rqzxRjXY5Wux+yGTdnToA7x57c2jxVxEYF0Fel8QfDZ/ME3JlJq5rwcJ20MgjPnN5+mlE/4i77HrhAJKNl+DHe0SP90+3hO/RClbBeJ5zyzklmJ55+HB85EvuuueKif7vwjtYZhUd4+i X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > Oh I just looked at the arm64 definition and assumed ptep_get_lockless() > == READ_ONCE() :) Now this makes sense. So I am guessing that we can > still get away with a *vmf.pmd on 64-bit arches? > > A separate question: When taking the create_huge_pmd() path with a read > fault and after taking the pmd lock, why shouldn't we check with > pmd_none(pmdp_get_lockless(vmf.pmd)) instead of plain *vmf.pmd...surely > now we must load the actual correct value from memory since we are > committing into mapping the huge zero folio? So you mean we go via create_huge_pmd()->do_huge_pmd_anonymous_page(), to then end up in the path where we do the mm_get_huge_zero_folio(). If we hold the PMD lock, pmd_none() cannot change, so there is no need for the lockless variant? So with the lock, you get the actual correct value that cannot change. > And after looking somewhat more, why even is a pmd_none(*pmd) there in > set_huge_zero_folio()...it should be the responsibility of the caller to > verify this? Any caller will just assume that it got the huge zero folio > mapped so this check should be redundant. Yes, looks more like a VM_WARN_ON() scenario. So I agree that that one does not sound useful. (*maybe* the compiler is smart enough to optimize that check out) -- Cheers, David / dhildenb