From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A424C7EE2E for ; Sat, 10 Jun 2023 22:23:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F14948E0002; Sat, 10 Jun 2023 18:23:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EC4BD6B0078; Sat, 10 Jun 2023 18:23:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D3EA98E0002; Sat, 10 Jun 2023 18:23:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BFBEE6B0075 for ; Sat, 10 Jun 2023 18:23:20 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 065E580318 for ; Sat, 10 Jun 2023 22:23:20 +0000 (UTC) X-FDA: 80888265360.27.7A3782C Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by imf10.hostedemail.com (Postfix) with ESMTP id 2B893C0003 for ; Sat, 10 Jun 2023 22:23:16 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=dqE0P6Gd; spf=pass (imf10.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.221.43 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686435797; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=W6uujsqxk2yhJUnZO8C8LMRZDFMVQxUsWZqX3BJiMYo=; b=z7nz4lN1XUSVXC9L4VefNuhfgPsN6K+MLxjBN6XjXjFn6RB6PX6J1sbZEPNrjaBZGXgiS9 KiRYBG4uH0D69b5P8jie26mWPM67Qsayb3H3Vobsk1kH9bbvFCvQAYD2AAt19/ccDVibky 1XmoYkfoFF6mJq7JntnLa0AlLuZ2+X0= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=dqE0P6Gd; spf=pass (imf10.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.221.43 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686435797; a=rsa-sha256; cv=none; b=x+IpIdH2INyYjebhWR+8f0Tx9rcIw8MLfvUFeHia2aO2mnULsrF5nCEp5hEpOlH7Hh0XkQ x7DJgvha/xonej9j2LEeUHS5OSN25HNTQP5tQ72HhXbCBrb0YfCiSDdRlI8k5qgihHH78U C3f05HijV39Z8+aFSObBGv7kXQcIu50= Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-30fba11b1ceso284848f8f.1 for ; Sat, 10 Jun 2023 15:23:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686435795; x=1689027795; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=W6uujsqxk2yhJUnZO8C8LMRZDFMVQxUsWZqX3BJiMYo=; b=dqE0P6GdikJnbYFdQSRIi2KOgVqaDnasOeFyR7JM2mKAp2+dj8QCflKMZr6ElaYn2y GUVRS50A9wAiwLMHfalqLzULubL7s+KOITKlPOhgMMds2NedshymH0QnPhsDvrcsaAmG LEDm8puQhRiHft4VBQW17t74P7WyDGyzBzEsiftvuhCe1cSVeqhFQXxM9qjwuM3u+np/ WMBnlG+nFpJBh1xIHpSjO+TJvZ3Vyc3kbNQx0Ln0wzt7Q+hFY+0qh3A8KotjrEssuzoQ XhTomxufEdzbT8DzkwUL8Nu7B+G7ohtOlfpfoMTCCbBTjAMyP3kE2m0CsqfNzQW3SlrM 9OGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686435795; x=1689027795; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=W6uujsqxk2yhJUnZO8C8LMRZDFMVQxUsWZqX3BJiMYo=; b=T4/FeSVtIXJ5tNqpw9s1O3JFhrEL1Z9ahT4sb7g23D/DQG4iPsSz0H1eXPVj1DjNlR vDBM4cOIJgxOq9sfGfkCxXNVjRw7qXPpYOo2ycITgZG/vVuhl/fWtzPuzsNtmIpkFWQ3 D0r5MZcFejGHRRruJURXQMKn7Hg+0O/DxMK2UBSYCaFVTYahr6+IdznqLn4ZhMXt1wk9 VDyrHfBU+rK2W02JOKff4pesz3CKAnz+EW5YwOdyIxt5fd5nKU8shVmm7bmcMYPOomxJ ljSrhmUZujJZLFlF301wm8E2rVW3zE8Cyo4Wo+tGW897KvnsR9oaRplPdONvzKlaf5Ra n9hA== X-Gm-Message-State: AC+VfDwee0zISvZ5i9SVu4TdZZjluT3D7Qa7B5Xp8k0ayOK3/7SeVLi8 y4EEl5fPPbGTVSMCH58BmqE= X-Google-Smtp-Source: ACHHUZ5bZ1sBnZaeM/asURPTfk2/lAvVnMr23APe2Et/y/Cg61gmXxb4Xy7tnYS2NdlK80vo63YpdQ== X-Received: by 2002:a5d:4208:0:b0:2d2:f3e3:115d with SMTP id n8-20020a5d4208000000b002d2f3e3115dmr2232033wrq.59.1686435795330; Sat, 10 Jun 2023 15:23:15 -0700 (PDT) Received: from localhost ([2a00:23c5:dc8c:8701:1663:9a35:5a7b:1d76]) by smtp.gmail.com with ESMTPSA id b14-20020a056000054e00b0030c2e3c7fb3sm7961901wrf.101.2023.06.10.15.23.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Jun 2023 15:23:14 -0700 (PDT) Date: Sat, 10 Jun 2023 23:23:13 +0100 From: Lorenzo Stoakes To: Andrew Morton Cc: David Laight , Lu Hongfei , Uladzislau Rezki , Christoph Hellwig , "open list:VMALLOC" , open list , "opensource.kernel@vivo.com" Subject: Re: [PATCH] mm/vmalloc: Replace the ternary conditional operator with min() Message-ID: <2489af27-0e6e-4005-b2c0-dd4e55d15154@lucifer.local> References: <20230609061309.42453-1-luhongfei@vivo.com> <832d7c69-ffd5-4764-8ffe-3a02bef0efb0@lucifer.local> <3fc87d60-4e81-4f49-95f0-0503ad5cdf35@lucifer.local> <20230610150809.babdc5a7919258f066c8637e@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230610150809.babdc5a7919258f066c8637e@linux-foundation.org> X-Rspamd-Queue-Id: 2B893C0003 X-Rspam-User: X-Stat-Signature: gzsncr8cjniq454f3ed6gue315wtqzdr X-Rspamd-Server: rspam01 X-HE-Tag: 1686435796-683460 X-HE-Meta: U2FsdGVkX1+coPRhFLDfjLCYSjgP2pqy2577DX5i9AtgIigGPQW0GXHaxip6sNu2TMzHbhJ0aqP6svBay+bH06gmmXrR78ZOUQhkVO24e1G9Z0JXc5K5cgtGiUIoHcwc94xaLrpcai5XHXC5YfR7G6wwRlU/0Lt9n34bHBwspX7OjyWuQV+f87BRx9xeF8IHGd/GjsGTTAdlhPJWb+GGccWYDbb5zbgxAWMhVEbq5BFdobZxXafmmlGRByFaRmiLAaDROs0acg13iyCXkzIGvMIYr2utMgBmg7MqeLPdwlhWkHck7+yJJ06zjzT2cABD894BieY5DO92n83dYp1ifqrvLx2vhIWNFymBt9+8OQZAFYMjg+Zr68lxRvgBIZzbX4+1oLSTnwCuw/9omn4g08xtxS9yio6F157vpO2dgCLciFII1KEzoUO+z5c+A8rrlYuUeJlb85Yv8gPG5nsCL6TG/Jdr6ULPZTQhmiSxVOYLrNZUOQPQ1dll9hTJHjIElLY+dzKajqTDCEJ7ElSo5KJjbMtaP+hmQwbI4NneC77su2Dt64/9cdclJGg/AHD2g0So0NuOMbeBk+nWV859EIZ520bgVyq7EAbOTcr2OyYAEedI8q5vAHp2oMYPUZ18WC4l6IT8ryzgKz1elCJDcO3jXK66Nhky9r7neTZwWvyQdTf/h27Mz9UUDrJDXehYs/2lB9p6TI+0mBXJe2ddscJQUIyF0sLKtCIP8nPaWvr/+nEQbga9CvN6GCcj00rRts86mq9gnrjvmErdjDbqxmYTE6n1T+kUxdATkrDeyvq04odizPilnjC3WAZ5hpL5xIMIgWAKCHt/LhhlVwyqOfpUPoDYx6VmODrrnR0k5RY9x/b8smAgf02MMfBOPD5hNbVstTpVz5es38+Kc7gbh3jku76z9Tztm8q/EjJJizo9h/JApV+4TfK1SG0A3Z7R+jNrTCigVfRGKu80NIe Mryt7fyl rAhQ1gLwjFv+55ZirQqxwgpJ8li13U+eLKwocKEbZBnWSQEj1MVbYRCYvtjZyt39LxkJ461a8m6Qa8H3vpSMzBt4FSewwUSiEYp73Dt29kI5bqDuCkvgOZgMbsoNlmOk1QTyue7dedE5vgn12WeOLGTMYI9VXtg6T+C+Wyulb4MdOlniDydUFko7mWx2g/HvYPsNV+F0j7wCszMvpDIqPdF+53umLYHd0VMTcB5yP24bzSdkpgfUD0W5RzFrByYsNrsXxAvZCosdu3u9O7OYROG3MORq316eIzwSzT6Wlaja1eEA8YRyXElvyNXm/EMG+R0hts0suPm9OJ9u41vdsXzOeY7TRtsdkfyYj5yvHZ/4h45IKkJ+bfu7GUIKH3h3KFKQkFGRhf9Fbnhldbto8wYdr909RGRCiuM7Zgyk3OF06ZYsYDA9KTr78KOoJr4XjqkHH7Ra/8/+BGZqicvcVCPG1Vg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jun 10, 2023 at 03:08:09PM -0700, Andrew Morton wrote: > On Sat, 10 Jun 2023 22:06:35 +0100 Lorenzo Stoakes wrote: > > > > > OK, as per the pedantic test bot, you'll need to change this to:- > > > > > > > > num = min_t(size_t, remains, PAGE_SIZE); > > PAGE_SIZE is a nuisance. It _usually_ creates the need for a > cast: > > hp2:/usr/src/linux-6.4-rc4> grep -r "min(.*PAGE_SIZE" . | wc -l > 117 > hp2:/usr/src/linux-6.4-rc4> grep -r "min_t(.*PAGE_SIZE" . | wc -l > 279 > > Perhaps it should always have been size_t. > I mean I absolutely agree this not being size_t is a bit silly although I'm pretty convinced sizeof(size_t) == sizeof(unsigned long) in all kernel arches (correct me if I'm wrong). So I'd not be against this at all :) > I suppose we could do > > #define PAGE_SIZE_T (size_t)PAGE_SIZE > > And use that where needed. Mainly because I like the name ;) I'm not sure I love that name :P but it is kind of cute I guess!