From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 598A5C27C6E for ; Fri, 14 Jun 2024 07:39:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5F8C06B0110; Fri, 14 Jun 2024 03:34:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A8D56B0111; Fri, 14 Jun 2024 03:34:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 421C16B0114; Fri, 14 Jun 2024 03:34:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 256426B0110 for ; Fri, 14 Jun 2024 03:34:54 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9BAFA4052B for ; Fri, 14 Jun 2024 07:34:53 +0000 (UTC) X-FDA: 82228682466.02.F5EE0E7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 6A8DE1A0009 for ; Fri, 14 Jun 2024 07:34:51 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iTeKz99Y; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718350489; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vhVev5eg90093EG6VTzZKwAqU1fLL5DOVgG/qvzSWSI=; b=wJHwSGnMN+ry1KTaMUkgpzHqq/carF8eWWij2khBNGGtos3MykE8IpsKQUMW+StwicQy1K gD0ESltzDbl9ccBK1ALDhgioQVo84J7Rr1rTp8i66C3rcIXNPPDyV2O4dEjypvFpBsE47F DreSTsC1Hb2Lksq7Rh7sIUVq1miTCBY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718350489; a=rsa-sha256; cv=none; b=CFF6hqM+fPjHhKyyieRIATjLbqljtJ9chEs7JfVcEtQP6IxYPRmNGiona4rn+GBrrCbJm8 QCpdxDMNnXLSZNX4bX2Zjv/jQ7DQ5JMbwiVWplpyZTQtlOg0Ki5tZUswOV/mRuNpKNrqrF A1b44g3rsJ4SMCBTnVrlb+nE9p/rIcU= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iTeKz99Y; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718350490; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=vhVev5eg90093EG6VTzZKwAqU1fLL5DOVgG/qvzSWSI=; b=iTeKz99YGI0erm4dgSpbH7OjyCGXTzkE2ohmBtkX7XEmk/IDduuo1N/0KFIRhkdHLRuuJR GpLYktbnJ874FwB2mX3UqxW5z1Udr/14eQmBrNFypbluEoQAsOiZ2GdTbkgx+yT1u2jS+D uvBkaEXW+A8d6TfreOFQovTkYC1tWPI= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-439-XYp8W7OwP6qNNU9BCFOVSg-1; Fri, 14 Jun 2024 03:34:47 -0400 X-MC-Unique: XYp8W7OwP6qNNU9BCFOVSg-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4212a3ddb6bso14262045e9.2 for ; Fri, 14 Jun 2024 00:34:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718350486; x=1718955286; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=vhVev5eg90093EG6VTzZKwAqU1fLL5DOVgG/qvzSWSI=; b=RhyFV4ZYfKI/WXC+uFd9YiZnKzGbLEeG232N6svobjCePmSCBoeePjN20nzSWRasYW WN75fdVZlLVb5+YTP+IX2jvNYYNDPcYfqdufrkPWpJB3DBVDumZWtevpeMkyojzeC0l/ jNTVIoA6GfbVgJJ4Nfvv1elzU/w0ORRTv3IbYXsHAfbRfrww8l4w4tkzrdd1pGXwHdHE 6hXPlJw+CMkBPmH9jGlxruOREgmIalTMv8/NZ7i8ty7g7j2uP6/84hMEpQbas0rqzKoA C9JB09zqGdELZhDwC9wJJkCIYDJIbInfYV/N2PS4siPMRO0wNRWEZflRQtJjpyZTGrGO b/4w== X-Forwarded-Encrypted: i=1; AJvYcCWyGlT5QdU7BK4Vd9q48JDtQg+C0hZaDZXxvk3sBxM58fH4rroEyZS/yYvuhTJCvvaj9uGfi/AppONFqT9nrXUeEJ0= X-Gm-Message-State: AOJu0Yy3aDuFXxq8q5Aqs7SsVcTEuQAi/mAApmLsagNz7V8aC6xIKToa RVdumQPZTv7rOXQS0tWX19zGrRceaspr7AXjuZlSviyAhQ5a41DxOhKtFnRxKejlZ18GNDxu44o JShtO2Gxelrr6qPS6Tn7KOmqEzPVrYcTSqmUjM92ZYxSswKj5 X-Received: by 2002:a05:600c:91e:b0:421:f04d:ebd2 with SMTP id 5b1f17b1804b1-4230482fbafmr19347955e9.22.1718350486227; Fri, 14 Jun 2024 00:34:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGdM8+eLlcOV7kPwNlHClMAOvLSS/9j7Nu56kRRk9usDJl6Ety/UD4TwIYPO2OSi7HEZD6V7w== X-Received: by 2002:a05:600c:91e:b0:421:f04d:ebd2 with SMTP id 5b1f17b1804b1-4230482fbafmr19347765e9.22.1718350485820; Fri, 14 Jun 2024 00:34:45 -0700 (PDT) Received: from ?IPV6:2003:d8:2f4f:2b00:69b5:3684:56c:6dd5? (p200300d82f4f2b0069b53684056c6dd5.dip0.t-ipconnect.de. [2003:d8:2f4f:2b00:69b5:3684:56c:6dd5]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-422f641a633sm49911955e9.43.2024.06.14.00.34.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Jun 2024 00:34:45 -0700 (PDT) Message-ID: <24765af3-2f2d-4451-9d9c-c35784ae95c6@redhat.com> Date: Fri, 14 Jun 2024 09:34:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 2/3] mm/rmap: integrate PMD-mapped folio splitting into pagewalk loop To: Lance Yang , akpm@linux-foundation.org Cc: willy@infradead.org, sj@kernel.org, baolin.wang@linux.alibaba.com, maskray@google.com, ziy@nvidia.com, ryan.roberts@arm.com, 21cnbao@gmail.com, mhocko@suse.com, fengwei.yin@intel.com, zokeefe@google.com, shy828301@gmail.com, xiehuan09@gmail.com, libang.li@antgroup.com, wangkefeng.wang@huawei.com, songmuchun@bytedance.com, peterx@redhat.com, minchan@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240614015138.31461-1-ioworker0@gmail.com> <20240614015138.31461-3-ioworker0@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240614015138.31461-3-ioworker0@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 1fihf1zmt657e73s9uhaexqgt7h57hym X-Rspamd-Queue-Id: 6A8DE1A0009 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1718350491-185964 X-HE-Meta: U2FsdGVkX1/V+kaM0+qz/Mp/LBCOtmX68KtRD2UOJHBEWRQXOen9OU4ZS0+rAISJ0GiYcDp8Znkhomb13sgImutoMcWk9aMTHr/+1PgA4e0dcX1BMLGnWEprzNUsxJkDMF143n/c3LweUs3LlvK5lv2t6YT0tT8MriR0sf+bJ4D/8/p+uniU1YMLJXvyBwfxvGw3pUi5HNNFgM1mI3hduObhIgx+3BL8kEs6BtyCQeG2F7gWwurKVGKwnT/W6W02p7i38EsU+deOY2neDfo5Q6xtaBtzZKqxxahuDeDSwlNiBlRhnKIWP5iwMzqrk8sK42hsuoz3OAIzr2MQoGdoAsTOCNQFp3+WN6PplO/TzgcKoVJ49C/u3GR5XAN0DI7sBG4xjKV+xIROQ1qmfebft+sLLDx5G8r8xteVnykdW1uibVcjDzc2Zlz6mfi5J5HWes3U8frkaLXPZF4KYh4G2Y1/ocECTQJJK2MVZUY7zBaMhJUr7Sw6FurgTVFZs0gR6JmZ1opv9wqWKTCEeQsgd9LiGp8mf7fGprKUGt0hWTnDy0ITPgMA0NUunW/eHjRPV5U8YcwKPVA+vdiIJTVMVsgjjiRBapn/u+FqrhfY3nnrJfrlOt0SsPzRXP9aR8iIHMZcTfYMN0+CPytIN5Fg7UPU+sWX9wxR4Vyboc6vYn46EP9Do44l8MymJ/DApwXuaE66LWzUIej4hQX5od338mmCwt7uGO2UkUQclTwClH2/CAH8SbEo/PTgprto9oJMAaa6yA96sybl7T90irr9SZ5Y5bv+//NxWu/zw4WB4mr18heR0W3di1AFmh2CRdWRs3yW9kvxYynaYcC1z7GNkH8V7KM1UBAz4zjLSlXNgNZkutGMW8gMPR+ghxIi6zvwfPItJmux+JHhZIjZmw1sgB0jFC5UeNfFYFXBbq/M0fyVL17qzsAAndlzfV9jvE2Wvsuf6ygjyJilf/yhSFM OwdbS3qz RHKNYP/57p9f8c29HkukbzJS4+/cK8eBiWC7aAlkNJgz9ccsF7bb+gxxbVyU4TPkmNdAStc8MYtc8uYTLM+v9ystxTF1iQDr/cl2CbWZsT/u/h+79xlbAW5W5j2QS6sjjzgXz6f/LTp8ZNiMxpJ6cdehuoCpQO4tj2ObITk3Vdc7wca93B0rPNFgaBaDv7nWG83F5R39uuva3U0FX5M5/jxzwqVYtvOOE2P1fjOiTa0JKgqKwwG487QT+uFhNWDPNC+YHjUeWkovwtHwP6vZOtqyKBDH4cGFqvIDQ/7I5wUnejEvZHHnWZuVvbugzAvVFlc1fa0lW140/dIIlziAfM+CKM1yJUpfsSTHHHhw/ZvFmuiHSrQwcmL8pcstjRL4SED+zc3bMK6WNr0M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 14.06.24 03:51, Lance Yang wrote: > In preparation for supporting try_to_unmap_one() to unmap PMD-mapped > folios, start the pagewalk first, then call split_huge_pmd_address() to > split the folio. > > Suggested-by: David Hildenbrand > Suggested-by: Baolin Wang > Signed-off-by: Lance Yang > --- Would have converted that VM_BUG_ON to a VM_WARN_ON_ONCE, but it's just moving code, so no big deal. Thanks! Acked-by: David Hildenbrand -- Cheers, David / dhildenb