From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8091CA0ED3 for ; Wed, 4 Sep 2024 13:33:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EB9836B025F; Wed, 4 Sep 2024 09:33:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E6A1B6B0277; Wed, 4 Sep 2024 09:33:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D0DE16B025F; Wed, 4 Sep 2024 09:33:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id AEB976B025F for ; Wed, 4 Sep 2024 09:33:37 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 064E94159B for ; Wed, 4 Sep 2024 13:33:37 +0000 (UTC) X-FDA: 82527148074.28.DE2EB2D Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf21.hostedemail.com (Postfix) with ESMTP id 23DE31C000E for ; Wed, 4 Sep 2024 13:33:32 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=BbEMDXTn; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Ns4WjIcP; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=BbEMDXTn; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Ns4WjIcP; spf=pass (imf21.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725456686; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Xo3bl7lGh/dhzDujakQFQJnzPs8JEyUC7jjOQMu7dao=; b=HVGf0o7lLjFWgRNqPRLKY75Vwyzis+g80d6SdKlu2pDuFuHVlww2PYD+YHxFvvKI8G8tRV PvDhUWqRd64ZpNjNXRkLk45O4QWAbRvXyhIjhy6VlXSh1z701BL2jnrTmb+/9E57LzbZqa a0bifjCSm9WWk1ZL+zW78Nd//h0lNbM= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=BbEMDXTn; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Ns4WjIcP; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=BbEMDXTn; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Ns4WjIcP; spf=pass (imf21.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725456686; a=rsa-sha256; cv=none; b=B3kqZNFXU8rTpnWb6SpF/ad1CrL9qw6IrrwvAOlXV+U6N2KSM7cKpNO2CsAcyOff8qqOKy /uVRoVrxw67wmkTJz2PfvawVOUQHzFCBNPT0BerEt8OuE80AXOqVJkxaC31UXp4VIp+0Ez MhIKQ+BSjNDCQcf6Pk455rmvS+yZzwg= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 647FB1F7C1; Wed, 4 Sep 2024 13:33:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1725456811; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Xo3bl7lGh/dhzDujakQFQJnzPs8JEyUC7jjOQMu7dao=; b=BbEMDXTn9Qpqra0JGjD0ivxqdWpq69mAegH7K8r5dHp90ipsFBQ/5jLlMlvZyJI3C89L1x nMCc+bIzrJ8y1o5Ocg3Uzv76S2qC93g8VSTOgGWv3IiYqwUJPZtNChqm8FypkSCOC36Oc6 /4sUgHZM1OWujOlnryjKvb5NWA7FjU8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1725456811; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Xo3bl7lGh/dhzDujakQFQJnzPs8JEyUC7jjOQMu7dao=; b=Ns4WjIcPxMmtTATwDqT/SBhHOfuPYoxi0gxpw0NZkvTZSJ6CXVBM/50T/WYs+dsR/SOJZE VhU1Tp+FHMstiHCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1725456811; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Xo3bl7lGh/dhzDujakQFQJnzPs8JEyUC7jjOQMu7dao=; b=BbEMDXTn9Qpqra0JGjD0ivxqdWpq69mAegH7K8r5dHp90ipsFBQ/5jLlMlvZyJI3C89L1x nMCc+bIzrJ8y1o5Ocg3Uzv76S2qC93g8VSTOgGWv3IiYqwUJPZtNChqm8FypkSCOC36Oc6 /4sUgHZM1OWujOlnryjKvb5NWA7FjU8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1725456811; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Xo3bl7lGh/dhzDujakQFQJnzPs8JEyUC7jjOQMu7dao=; b=Ns4WjIcPxMmtTATwDqT/SBhHOfuPYoxi0gxpw0NZkvTZSJ6CXVBM/50T/WYs+dsR/SOJZE VhU1Tp+FHMstiHCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 514C4139E2; Wed, 4 Sep 2024 13:33:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id HSwCEath2GZQZQAAD6G6ig (envelope-from ); Wed, 04 Sep 2024 13:33:31 +0000 Message-ID: <24717bab-7d5d-4ed1-a17d-65d4676e22a9@suse.cz> Date: Wed, 4 Sep 2024 15:33:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 12/15] slab: create kmem_cache_create() compatibility layer Content-Language: en-US To: Christian Brauner Cc: Mike Rapoport , Jens Axboe , Jann Horn , Linus Torvalds , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org References: <20240903-work-kmem_cache_args-v2-0-76f97e9a4560@kernel.org> <20240903-work-kmem_cache_args-v2-12-76f97e9a4560@kernel.org> <20240904-storch-worin-32db25e60f32@brauner> <23eb55c3-0a8c-404b-b787-9f21c2739c4e@suse.cz> <20240904-absuchen-gockel-8246820867b4@brauner> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20240904-absuchen-gockel-8246820867b4@brauner> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 23DE31C000E X-Stat-Signature: oifn6dfk4fb4f74xo4ok1r7fu9kz69j7 X-Rspam-User: X-HE-Tag: 1725456812-469302 X-HE-Meta: U2FsdGVkX1+120iDxTYn9A//JGijOlzTLTlskX152LNxEmNnQRBA7YJ7WwVw9D5rU7YkyeXDRePMRYBw/aLUdki/L03NFGkfuaVYczFWOn9mlxRt5NaIH8qCbh64HeoOI008pWLJb8/c/feOvcJvl4dK9QI+nfi9v02ApNf5RzKRVM0xnRLy8eG6ybURYGbhgAjIu1GGTXx9RZ7hWSAFGimCXQDuAO5msxXmOfuuYlIgLddxoLgvYa6I0t9pxAePXWGoentDGHUmddEMDtK8Nsjl/dKeWw1UhcQL85MHvF2it2EzyducVjI1EIVjT4VIh/T1BIcwk908dGVd65NTRklMxf0BUFe3l6GFs40xW1n6A4ssL0zWnPkDZG3NtNJAO3Pao2bocHc5wGSC1NPo26/zJr+Pq4Px9Qhp7bfNmNe55vESjuGEq2shVnpkB2yQ4Vx6JR+zgfmqAA7EjDTbw9J6WFGQr0cRbq35t5B0AtEiCMXge/xLb67BN/j5GXbitRaN/Y9MB9Aa1GMmfD9jlIsADieWGxwSxsYycWwClZLFtV+sTSrcI4/a1xWqcjXkNHb2AmTCLC2Sj8090NcxDwoWlcyTyzk+FQslm2Pa5Rdbrbuo1XF4HjHRa0QPQXri815A+5hDQ9mZYywyHau/UE8QykXEQbqvQgoXttipXJkl4YP7YoDaliJQLO+s1zgq2G0SL29UrqWXmUvo8FqYAVWpiTOtn7zI+MvKKQj2J19+UkVKoMqM7xq8c9qz5gp1dacLaj94reD36t+Hm7afILBGc1i9Qd0ODaNyEDTA7b8tlqFKoyglIi3AKliQVze4yQRh2o/hnfwztDJ8fiaOvhselFwcTvUKC6BcNISWH8oAxesdGXiz7mYitQvQuAAyJHuZmoyRWuijsZV80CpufFx/nCGbIYh1FM0AL8Kk3lQH1KhvgWSZFvaleBH+FlG+QgkN90wNkXSeGrmcJus ws/u+T8x 0/YwTMaUREzclYTPgMqMxzE6tDGgGh9aTtCHNaHGesgO+rzjmZmzXYAA4fQZMwHq/lHxypMIGsr48R7iC8c87XZp9YT3mTjlvGtOc49WrIPBhyOydJcaEPpK/P29E4ocdIhvgzhQVmhRgW6MuvDYpXZZvYVw5IzTBatr38HFOVTVjpucWz9GQL4v9MRQEPZ4cq3WxeU3MCn/AATQYkhrYW/b4PUeAmQz6W976ZUrrzpC7HrkCqNfqvKDGjoobsBQdEzdbHvQclIgKvWWl/ZIooUywSXwl1NCrK4W3oEqw0uDgUfOChsuEcJpf8NnZiPHfgAi0kfLWdmLWQEc35Wxp3ABAoofAlKDj2MNCY0r26Hm44QQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/4/24 13:38, Christian Brauner wrote: > On Wed, Sep 04, 2024 at 12:50:28PM GMT, Vlastimil Babka wrote: >> On 9/4/24 11:45, Christian Brauner wrote: >> > On Wed, Sep 04, 2024 at 08:14:24AM GMT, Mike Rapoport wrote: >> >> On Tue, Sep 03, 2024 at 04:20:53PM +0200, Christian Brauner wrote: >> >> > Use _Generic() to create a compatibility layer that type switches on the >> >> > third argument to either call __kmem_cache_create() or >> >> > __kmem_cache_create_args(). This can be kept in place until all callers >> >> > have been ported to struct kmem_cache_args. >> >> > >> >> > Signed-off-by: Christian Brauner >> >> >> >> Reviewed-by: Mike Rapoport (Microsoft) >> >> >> >> > --- >> >> > include/linux/slab.h | 13 ++++++++++--- >> >> > mm/slab_common.c | 10 +++++----- >> >> > 2 files changed, 15 insertions(+), 8 deletions(-) >> >> > >> >> > diff --git a/include/linux/slab.h b/include/linux/slab.h >> >> > index aced16a08700..4292d67094c3 100644 >> >> > --- a/include/linux/slab.h >> >> > +++ b/include/linux/slab.h >> >> > @@ -261,9 +261,10 @@ struct kmem_cache *__kmem_cache_create_args(const char *name, >> >> > unsigned int object_size, >> >> > struct kmem_cache_args *args, >> >> > slab_flags_t flags); >> >> > -struct kmem_cache *kmem_cache_create(const char *name, unsigned int size, >> >> > - unsigned int align, slab_flags_t flags, >> >> > - void (*ctor)(void *)); >> >> > + >> >> > +struct kmem_cache *__kmem_cache_create(const char *name, unsigned int size, >> >> > + unsigned int align, slab_flags_t flags, >> >> > + void (*ctor)(void *)); >> >> >> >> As I said earlier, this can become _kmem_cache_create and >> >> __kmem_cache_create_args can be __kmem_cache_create from the beginning. >> >> I didn't notice an answer to this suggestion? Even if it's just that you >> don't think it's worth the rewrite, or it's not possible because X Y Z. >> Thanks. > > I'm confused. I sent two patches as a reply to the thread plus the > answer below and there's two patches in v3 that you can use or drop. Right, that's the part below. But the suggestion above, and also in Mike's reply to 02/12 was AFAICS to rename __kmem_cache_create_args to __kmem_cache_create (since patch 02) and here __kmem_cache_create to _kmem_cache_create. It just seemed odd to see no reaction to that (did I miss or not receive it?). >> >> >> And as a followup cleanup both kmem_cache_create_usercopy() and >> >> kmem_cache_create() can be made static inlines. >> > >> > Seems an ok suggestion to me. See the two patches I sent out now. >>