From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B027C761A6 for ; Thu, 6 Apr 2023 15:32:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C2B4B6B0071; Thu, 6 Apr 2023 11:32:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BDBC76B0074; Thu, 6 Apr 2023 11:32:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AA2E26B0075; Thu, 6 Apr 2023 11:32:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9A8966B0071 for ; Thu, 6 Apr 2023 11:32:04 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3E9A3812FC for ; Thu, 6 Apr 2023 15:32:04 +0000 (UTC) X-FDA: 80651356968.21.72D769B Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by imf24.hostedemail.com (Postfix) with ESMTP id E19F118001D for ; Thu, 6 Apr 2023 15:32:01 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Q045xQnc; spf=pass (imf24.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.88 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680795122; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=azSveYtsvIrZjoVt1aC8Z5NwZpxVuO7o21DTx0HqGWA=; b=ZOAl92z3j4N1WJ12BHcasmt7Bl9QGnz4CbctnMw2MIXcHFNWgNUgZvNEoYw7Ko3mFlr3Br fyxz2eFhiWSkB8HW7A9fivWmMWt0om4Q5ymYpJRyv/3BZ7X8vWPl7sNO0zeIzBQWyAWwXy fkGD7Irwu2ldyG1fucvI/st6V4eX4uQ= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Q045xQnc; spf=pass (imf24.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.88 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680795122; a=rsa-sha256; cv=none; b=eCw7hzAmwtpqfiDc+GkzZ2VBTRFTH4Q+Hqk3hc3YZklvmo+88R6eu6urfhq/zQkELD/wD2 xw5oeCJ4JRd8cCnlhMHrufzJUIkUib3uTcOJhbd8hgYrnpWQZ06uM7cO3Jkv2Z7Us32wsK c2rkzF2ppcVX272x5quEfZFgSRfTob4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680795122; x=1712331122; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Ruqew8xBk5gM/kBHIUBFERD+y/y6oG1MmbVU4HLVKms=; b=Q045xQnc+ZQCRw2YoRYiSCsgw2zZDJYpKZpiTb7tLEHpbrjFf8V9JLxt ifKvDBPkEYNjNvm4KsYS3cyyjGesdQZ3uEqBWcM+VQfZmAEQpA3RUDVsw wNxDtE4pg4jK0wgsBip3SU39tQXF9TDO1znrEGPPEvk7GvSuDqRuOF/sd mgTYHY8egYSH6tXfNfbdOaCYiV/SMqW3W7kPXkfbicHQ+xK7im/JK5pk6 Qdae/kA54OvO2K66VloiNj5oBRGfyUx3Iudxsz6De1pM0aI3DojHVH+dv bHKn409hY9NGAfhsZB8B85Lb41s8HrMQy11i7XEdO39Wv5Y1fB9Zt5lUm Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10672"; a="370596772" X-IronPort-AV: E=Sophos;i="5.98,323,1673942400"; d="scan'208";a="370596772" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Apr 2023 08:31:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10672"; a="756397773" X-IronPort-AV: E=Sophos;i="5.98,323,1673942400"; d="scan'208";a="756397773" Received: from mariowei-mobl1.amr.corp.intel.com (HELO [10.209.123.94]) ([10.209.123.94]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Apr 2023 08:31:40 -0700 Message-ID: <24661bc4-cc95-5c1b-b88d-94d4ce335d0b@intel.com> Date: Thu, 6 Apr 2023 08:31:40 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 1/2] x86/mm/iommu/sva: Fix error code for LAM enabling failure due to SVA Content-Language: en-US To: "Kirill A. Shutemov" , Dave Hansen , Andy Lutomirski , Peter Zijlstra Cc: x86@kernel.org, Kostya Serebryany , Andrey Ryabinin , Andrey Konovalov , Alexander Potapenko , Taras Madan , Dmitry Vyukov , "H . J . Lu" , Andi Kleen , Rick Edgecombe , Bharata B Rao , Jacob Pan , Ashok Raj , Linus Torvalds , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230403111020.3136-1-kirill.shutemov@linux.intel.com> <20230403111020.3136-2-kirill.shutemov@linux.intel.com> From: Dave Hansen In-Reply-To: <20230403111020.3136-2-kirill.shutemov@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: cdw54txjkwi4fyn55rjy5oqrza4eyqg6 X-Rspamd-Queue-Id: E19F118001D X-HE-Tag: 1680795121-286604 X-HE-Meta: U2FsdGVkX1/BIWS1bcqLHM10+gSlcP2muHtb/nFfgMStPQivqfbEY2jD6MR+mKN5TVz2kDQooYtZhO8C2TFmF+goXx3NfJtw4+7tW4aFfk3tuftGWSSyGoaM7MQMv8n6zTRSdP5d1jNocG4ST4HdvxMxJ0dZ8mR3agwNTDwb3Ad/35OrGf2nwXNkYxtwWg+d4md2poWWyA8KF3xp4vm3KydQeN27iLzdeZHjbe/itbKSQLPLysRx1JfZWqG/nk4gy/BRwt1Lg1GKF/swJeGfzuXR0LlQ5RU2XFsG+vN/N8XdkE6yQlWGQW1nyKbqX3p98xmu9vIfAoWBSIQ1lWsGxaNaJ7Qh1I9Vl0NUNI5b6XTxdqqn2rE9AjcXa9DUL++zkBZ6G9KNm99uH/hIRGlJZV81CCi+tL7NFoDEUvrvV/VwoF1e5O4xqwWjszrTg2AvNCJB+nuHYEqrgCKXHdRW3gqGL7StYdqEDs3i4NY557qV/NU0EZPsBHvoZ9oQuXhwI7KFXW45Uy8GolQ4VL1MvwVFtgWUYm+s51jeHkbxYSXhVG8ZdemLcj6QL/M10AXx2WDQQADDiUqvKNCY454bxyG7rH01O2nu06L9ad2XsFj3K9mSAmkJkDFlmfTO81rGRKApiaE4Gk3V5/sIAJpjlDWzPU26DyaE+dmZLEylu3mCTtbE7xr/zGfJbmyAeYPIhLYlsXujqQVAxLYOrA5AlO1Fw1TiQh85+4PHjBv8N7EmvzgRlsfvkTnBC+7joVN+gQSodTcDFCyejihpTlU9z9309mBHVfbzLqr3uaOekMyPTdXcTjKL6qdIos56ief3hR/PXQqwNQvhaoat1iyrBFNgma7L10Wh1xOC6yTH/ST2mqYYsCb917rDpOM3XmICNynoVHIKcuAI7VO0JiwP1jlzn40oqx51jKliBK4tq0OHBzAMTTbHNa8Ifs/2CfYCGBN7L4IgQnmw3X06MI7 KGRgT+F8 EGqXmMrFFgwsQv4Ib2Ni8jPuEa+lG22quxBaOM2BVNKhzL9EHawYSWsGdrL5tKaaYSvkK6dbMIRZB50FLotjvQe+lqRD3YkuQTk187ViWuOux9ddPraEf352th9AHQ5LHWFxfEhvLazg3a54miFhe0l2HXKkNXLmzETi1jvA0G3R/uCx6h4eqB3FSeJfzHuBf9DKb5Gv7TFjFwIEYpUXs/uIUTYLSk5jBo7LwL1D0iOsch2NptKtlIk0WCaZhxH06obPDBaO6aoWezYQ8PIeo57FMf69aZE94eTJa9SGCcriUGz2+yNGAXbB3JlSZG60wyNIexPN8GkU3USvWdQl3v+SvLx5Oarw/TkbkZlA5dpPVVfc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/3/23 04:10, Kirill A. Shutemov wrote: > Normally, LAM and SVA are mutually exclusive. LAM enabling will fail if > SVA is already in use. > > Correct error code for the failure. EINTR is nonsensical there. > > Signed-off-by: Kirill A. Shutemov > Fixes: 23e5d9ec2bab ("x86/mm/iommu/sva: Make LAM and SVA mutually exclusive") > Reported-by: Dmitry Vyukov Hi Kirill, These look fine. But in the future, Link:'s for Reported-by's would be very appreciated if the discussion happened in public.