Re: [PATCH 3/3] mm/rmap: use folio_large_nr_pages() when we are sure it is a large folio

[Lorenzo Stoakes <lorenzo.stoakes@oracle.com>]

On Fri, Aug 15, 2025 at 08:49:43AM +0000, Wei Yang wrote:
> Non-large folio is handled at the beginning, so it is a large folio for
> sure.
>
> Use folio_large_nr_pages() here like elsewhere.
>
> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>

This looks fine to me, so:

Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>

> Cc: David Hildenbrand <david@redhat.com>
> Cc: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> Cc: Rik van Riel <riel@surriel.com>
> Cc: Liam R. Howlett <Liam.Howlett@oracle.com>
> Cc: Vlastimil Babka <vbabka@suse.cz>
> Cc: Harry Yoo <harry.yoo@oracle.com>
> ---
>  mm/rmap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/rmap.c b/mm/rmap.c
> index 645d924bfc7d..1b7011afc663 100644
> --- a/mm/rmap.c
> +++ b/mm/rmap.c
> @@ -1703,7 +1703,7 @@ static __always_inline void __folio_remove_rmap(struct folio *folio,
>  			nr = folio_sub_return_large_mapcount(folio, nr_pages, vma);
>  			if (!nr) {
>  				/* Now completely unmapped. */
> -				nr = folio_nr_pages(folio);
> +				nr = folio_large_nr_pages(folio);
>  			} else {
>  				partially_mapped = nr < folio_large_nr_pages(folio) &&
>  						   !folio_entire_mapcount(folio);
> --
> 2.34.1
>
>