From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B05F9C67861 for ; Fri, 5 Apr 2024 21:07:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3257F6B0089; Fri, 5 Apr 2024 17:07:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D5EC6B008A; Fri, 5 Apr 2024 17:07:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1C4A26B008C; Fri, 5 Apr 2024 17:07:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id F02486B0089 for ; Fri, 5 Apr 2024 17:07:57 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B638EA1291 for ; Fri, 5 Apr 2024 21:07:57 +0000 (UTC) X-FDA: 81976715394.11.1CD0C80 Received: from mail-il1-f173.google.com (mail-il1-f173.google.com [209.85.166.173]) by imf23.hostedemail.com (Postfix) with ESMTP id A5967140011 for ; Fri, 5 Apr 2024 21:07:55 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=H51tEnbL; spf=pass (imf23.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.173 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712351275; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8tFcMER8j7g+Kousn29UjGQVOvnMnxSE38Y7ZswRMOA=; b=4OYkZVLOcIpmTwMrBpCOqYWwGt774XzrOY8r/nNdkRpLKES7OY66aTQ9973IhU6BHv9M6h iuiSf1vpITsbn1Zq9mgLhfQZQm/fkRTrV0KiczHi+DOURiL0/MlgpiS3G151gQa1ueyRbj KppaVyM4olgz41di1jN3QyXuIbF+CTY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712351275; a=rsa-sha256; cv=none; b=NBCehSMSk46uq8PpGQX5P7gpl0OpxgKXcfsE8XX87RVPKrCefzwLBNTPr1NWuqfT/OOYhM JK0HhtEHIZLZgnZKRBiVM24UxxRNLA8px5Lmus5yE5HAUYLpaKgmobeC0HXSs81C7hNzVV tPu9InFdaBI8Uky4ALJbOdbgxF0wigI= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=H51tEnbL; spf=pass (imf23.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.173 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org Received: by mail-il1-f173.google.com with SMTP id e9e14a558f8ab-36a11328dfeso1159085ab.1 for ; Fri, 05 Apr 2024 14:07:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1712351274; x=1712956074; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8tFcMER8j7g+Kousn29UjGQVOvnMnxSE38Y7ZswRMOA=; b=H51tEnbLsbpI41kXRMih74BhJbPs4i4rBel+RILoJviW/wHYg8Y6MAUAG+GkIm4v51 v3PSu94P3bLUYZXBUrV58aZyxyccf/ZAEjrqfFpi6U9WC/EYGWBxblugviG1alvpNIRY MOpmFV0mrq+jZMGGOgKj8LTIOOd2SmL8wdAkk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712351274; x=1712956074; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8tFcMER8j7g+Kousn29UjGQVOvnMnxSE38Y7ZswRMOA=; b=b5/SGNm6Y3N8imm2xBVMO6lAe4WFxBifBxk9O9+b4fM/JxBalt8cLNnOWdPq5NooHf DhH9ouzvaCSDzA3C8w1i7BQt1hmYWdLuM8VA6G+wQ1vcqnrnKdAB7trAezubLBPeLdj8 tCOo0yTNAC7DBqkIYMdy9yJbkg2sGASGSx5VVVTRnOhkV7xA61vjfi975Cfr1jNghrx2 wF1jZXc5fISPPbGGnVvqmP7Bko52GXAV83oyBTQ0xwBP/LDQyBn785UQOuLaEPqojXp1 RdZU3OwKyKEys3F0YvTYIbZSUIpecJWPyof9YG9CklitoIZ1U934ji/cvgvOgoBV9azo Geiw== X-Forwarded-Encrypted: i=1; AJvYcCVlx4FwveQsX4kGyxa6xakhirFAe56lP5Jg4kMGf3J+SRh1wqo2U1A9rI/+JaFyEtWBXcwejfuhyK3qn7iBs/s3SuU= X-Gm-Message-State: AOJu0YziwQBUQerxHuflDS3bFq/dsQG6iSkyQY+mOB8bIfWqirb3VTR7 hyKQslZpaDI15HNfngi3jVZudmZB0mGW1eVUMNR72vxN2XAv2r4eRV6N/On8ztQ= X-Google-Smtp-Source: AGHT+IFpUdTjNiUrmIGtr3vJSUg8kWEja0OcCt+9TF/CDdmE4VJ6Ro4tdKiAzi9GtH7u4JkONeQpNQ== X-Received: by 2002:a6b:ec05:0:b0:7d5:bfd3:7237 with SMTP id c5-20020a6bec05000000b007d5bfd37237mr2616439ioh.0.1712351274500; Fri, 05 Apr 2024 14:07:54 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id l2-20020a056638144200b0047efdf3a882sm784394jad.177.2024.04.05.14.07.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Apr 2024 14:07:53 -0700 (PDT) Message-ID: <244a65f0-4f9c-444c-b150-ef3b18cfbaa7@linuxfoundation.org> Date: Fri, 5 Apr 2024 15:07:53 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2] selftests: Replace "Bail out" with "Error" in ksft_exit_fail_msg() To: Muhammad Usama Anjum , "Bird, Tim" , Kees Cook Cc: "kernel@collabora.com" , Shuah Khan , "linux-kselftest@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , Andrew Morton , Eric Biederman , Shuah Khan References: <20240405131748.1582646-1-usama.anjum@collabora.com> <2a77adeb-ed22-4a9b-a1d9-ac5d29ae696d@linuxfoundation.org> Content-Language: en-US From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: a5ee483dkqmqt85y45esh8cp7htxomb6 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: A5967140011 X-Rspam-User: X-HE-Tag: 1712351275-822869 X-HE-Meta: U2FsdGVkX18MJtjuLqy8C/gqI39EJVgt73oSA6pVG+1qibzZ8CRG6455lxSnWK3IKs1CpDE41hLlKnV+7IL5ba9Rox1dZHa6TNQzyilMiegA4a45lih3qP79IAF2U6PE+jM+a4+tKNokcC56y1QyBcmXrbtW+ZtcNdWzTYlwvoy9BzZxnSrcGUcaOruH1egXEBDbkRtDXw212WWrUVicUBT+iOf+HJDCHOQNUnBFq0ZpKpWNwKUhCrHysBWkupge1M2IvyxXePqp+tPa1EHYoSFfh0E1OLIXFnIba7bBIMNHGYwWtOKNj8qDtR3i35ngsTYbcajX3wUN6o/Yj6zoguiIcNXOAvCIg7RgvHbCJwFPZNPMm2vx9TeD5bwZ+wVDeJylL2zyzcVEsSK49MBENcQTWD8p2mZQ26PL2VqMHhd6yi5/mH2g5tjJ82acsLZs1elblNBEPnINzlwXOi8YFwv3CJN1rgplSfUEuMZ2oJFvejuGK8LTdCSPdhloVmGp183B5mvPMPbOP30QAeyFkEUJndIydDxE/7D16N/FLDkky4xe5E7Gw3MWFMQs+jftLHESkbB9IgldU2Szmu9oXtw2qp1sQst0GKRnM9UkCflofNvGOTuBTInvnyvDpmzGLbk8rWQIaZ2z+Gh5SLS7skyjsWZJIwlGEmipDyGbxpIqqY50JhmEcqVb/qpW8DB/ifH6reE9+fqIaB04T4e/uhT9obQFdYMtndNha5p+wVgsYnRXzrrIKtdHEMqKFH7BzDlW2BnIhlsiKqmahwAuUKF4tsT9yjZY+j8yEC7MiOAZenjzGU2luSAwfdLHpcZS6MPG7bPyaUQwgesQ+sg0sPJq9IrwL45Kw+9ebnDS8JFNdCwDgwKROw+YBOmVZyRiLmJo5IpqhLawye0ywmM84PDBMAOgmR2uQsSyrNlLjT2biWohGmGJZTip7W7Rv3gkv/hoH76jLUhnHu8S/Q1 tRZTpxs7 alSRrLIUnEPPgy+q96/laba4ZN5MbTBoYyoZyMWGDuaNRc3rbL6DZiSJdflnGGQ+kc+Oz86/zdiV622lVBwxIivRnP44kAGblaaJPKmexpY5RzZFhmhnJy9J9tcHzdrcs2USsAG6V2MH0diYkPDN0D6XC8psvIhpZSXJKmzcbvrm+RNgItglAah+v0xr0H0WJn3bDHQnwJIWBFD+FMBChcEHUzTaDVDRFQahaE/1HfdJtfH0CjlHg2LigNVNPkaBbNWWQbYgXFpRy6v38W+tHqL9wM0CXDNyIvvB2+PTvF6pIDsxaBbxKTLmuYKfcundPmvcAaLiKS20A2P9HDp7i8VnmuAC6w0LS57K/QyTlLBedwsx8JgcnG70x/TQFlpf4Z5/J/x3BTCFzJTYtni/Wp27wrHG8eKpFr5ca986CVOXwE20cj557GJe8hFlD4sLXCOb7bczwRCnuUc/JA2xpKStEJ644owdoDlZcY4afHeJ1t4jOsj3IWF+el8A4+HK3P56iWH7pjDiH+STHCnGguBc0FikrlIbVO1jIKInk7JG+GwxDte39Rc60pkddt65zMgOqwnXi4VdfUpRl+Iy0xAWhT4mNmQsP7xvVMVbZDjsXMovSM/B085kUE42hIyDGMN0eHxp0B3CCxfG3lzGQSB7D6mXBS1VONZxLx3cDyp09FS8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000030, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/5/24 14:38, Muhammad Usama Anjum wrote: > Hi Tim, > > On 4/6/24 12:36 AM, Bird, Tim wrote: >> Sorry I didn't catch this on the original submission. >> >>> -----Original Message----- >>> From: Shuah Khan >>> >>> On 4/5/24 07: 17, Muhammad Usama Anjum wrote: > "Bail out! " is not descriptive. It rather should be: "Failed: " and > then this added prefix >>> doesn't need to be added everywhere. Usually in > the logs, we are searching for "Failed" >>> ZjQcmQRYFpfptBannerStart >>> Caution : This email originated from outside of Sony. >>> Do not click links or open any attachments unless you recognize the sender and know the content is safe. Please report phishing if unsure. >>> >>> ZjQcmQRYFpfptBannerEnd >>> On 4/5/24 07:17, Muhammad Usama Anjum wrote: >>>> "Bail out! " is not descriptive. It rather should be: "Failed: " and >>>> then this added prefix doesn't need to be added everywhere. Usually in >>>> the logs, we are searching for "Failed" or "Error" instead of "Bail >>>> out" so it must be replace. >> >> Bail out! is the wording in the original TAP spec. We should not change >> it unless we plan to abandon compatibility with that spec. (which I >> would advise against). >> >> See https://testanything.org/tap-specification.html > I didn't know that exact words are coming from TAP. Thank you for catching > it. We don't intend to move away from the spec. > >> >> The reason "Bail out!" is preferred (IMO) is that it is less likely to be emitted >> in other test output, and is more 'grepable'. > Makes sense. > >> >> This would get a NAK from me. > Let's drop this series. > Thank you. Dropped now. thanks, -- Shuah