From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCBEFC636CC for ; Wed, 8 Feb 2023 17:02:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5558C6B0075; Wed, 8 Feb 2023 12:02:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 505956B0078; Wed, 8 Feb 2023 12:02:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3CDC56B007B; Wed, 8 Feb 2023 12:02:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2CAE46B0075 for ; Wed, 8 Feb 2023 12:02:54 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 041FC160E63 for ; Wed, 8 Feb 2023 17:02:53 +0000 (UTC) X-FDA: 80444744268.28.08299FB Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf29.hostedemail.com (Postfix) with ESMTP id EAB8312003E for ; Wed, 8 Feb 2023 17:02:49 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="ko+debm/"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=DbSs3cq4; spf=pass (imf29.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675875770; a=rsa-sha256; cv=none; b=l+OXa3K2VTA77RG4AIHOePpOCWQu02lSPrA1kfkYQUg9o5erxzC9VvdGq3ctJ4mQR+0XZ+ yKbTaysgZbb3xXorIQsDH2jy5MNO8dgTyMS2Se2c5syZi/wBt0Y80bgpXnxN2WN19L7iHX OOfXAt2X3sX3+RsMobsGcV2A+y67A/0= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="ko+debm/"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=DbSs3cq4; spf=pass (imf29.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675875770; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nY2vXdwHiUi3upLIwQWRCsV8NPYZtr4IXeAtBs5Kaaw=; b=ciqp12vMb+bP09c8REhKxnAQE/7ilccZnDs8M2/d2wlGFt5IE5LruxuQAokjoypp9ozMb+ egsKUpuKO6dXaeTqH0nk6liMXrrYNFbY0YfWTXajKXQgIOl7QFOI3hd3X2tlcnRmzw+cOG icJGugvDs1Gx4YWmHYbAWzzVNZgS1Rg= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8485D1FF10; Wed, 8 Feb 2023 17:02:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1675875768; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nY2vXdwHiUi3upLIwQWRCsV8NPYZtr4IXeAtBs5Kaaw=; b=ko+debm/S9WRnZ4IJ2BwND17LugSmccg1Dttj6pmkYYMd7PrjDEaYCRYqtkNnWHAAzOwWr HvwIKsWqGA4D2q2vLYQupujQPeCM/uKi050QktOSbThEH+oGPJJzd8Z47vqE/UY/YHpZQR J0BXAU9mo0Osg1xwtxpxToPNpZlks6c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1675875768; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nY2vXdwHiUi3upLIwQWRCsV8NPYZtr4IXeAtBs5Kaaw=; b=DbSs3cq48z1R6rg+Px8GMIJs9iPYUJS4gr8ByZNB4WmiAAzCaSFjHi1+roCOwnBBQA2pMm 7bKYoN1aoeSIp2Aw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 671B513425; Wed, 8 Feb 2023 17:02:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id n/qgGLjV42NyaAAAMHmgww (envelope-from ); Wed, 08 Feb 2023 17:02:48 +0000 Message-ID: <244795ea-78f6-d02b-ecbb-0b2e1d2dfdfb@suse.cz> Date: Wed, 8 Feb 2023 18:02:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH mm-unstable] mm/page_owner: record single timestamp value for high order allocations Content-Language: en-US To: Hyeonggon Yoo <42.hyeyoo@gmail.com>, Andrew Morton Cc: Mike Rapoport , David Rientjes , Joonsoo Kim , Michal Hocko , David Hildenbrand , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230121165054.520507-1-42.hyeyoo@gmail.com> From: Vlastimil Babka In-Reply-To: <20230121165054.520507-1-42.hyeyoo@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: EAB8312003E X-Rspamd-Server: rspam01 X-Stat-Signature: 7djec815b3pa569qohpti3wjiuihbd6w X-HE-Tag: 1675875769-364267 X-HE-Meta: U2FsdGVkX1+uYJ6h76X4THqmu4WhAmpPYlojX0EvmTfHdg+vdVsq19ILYPQQCWcVzzWrDwXwL6co4C8tI909CXuDM3ZMxi1nfHRjpxcKpXEsHYUMvm6HJnEsfXpkUXL+JuZ3Hm0AB8gUwhX8Ack98o3IJbkTkTccvgPOF24OzKImTnBjdjG0sEjsxm11S2RWa4kDuj6IwEYrtrHBGWSwUTGLtvwh+bPgVhpIxqAEXxZSj+RtLKc8TKFeXOQnynAkycAlMK3IVjFwI36H6z1dEVj1fM/0y7z8clVazL/55Mhi50WWmxaKPeSVUXrosUW7xkshfHPbqrklU36mgq/vKGKqQr/NixGj3hkTT34Ilmld073l/Uer+8T8UiUELKuiIt8O9BUprbIsOxzLUiVrz72M3wEIyKPQ1Iaxq3SYSXd/fMhuoBmkifj3LlNq4NgHueVtJ2BSFYXFYEWolBX3PaggE8MXfXP4k6WNOV9gsCGjVQaXjdO6qgyl4sOjvzB3e0wEwllthkGXGoGnt7U5cZF7cBgGtAIxqgruKUJ8nRhsqw09yIDI80jS67fXamoR6vyPhPhySx2+h/irDL7PHU4pEJad2XQa6c0H7iVxyn+kYPLXuir5217R2/e90aJUVa6AkBKBCB4Yx38Vaq62krGnWMsg8NPDwFk1gZ8izuSrYYCenlgq2bfwUiHTwGJBJsr0hrBDO9WdwrBFZHJMB6s3BOV4Fo5V8pXvEAiTfubxqrseoybSrZNjV9r12WcdnoPQQFzpjsWRttPNbgkCzM5bYvcssfDJK2r9HKObMRXteGTpVP/1UF8n+x5SvnG+gtzB7qNtKfcdqDqCsi7EY0w26QVOOhZ2BmY4/cbS0PBuZ+WNftzybRAVtFMiQXM7d0BX4mAjb7tlzjS7mdMGoajO5vRnskEFgzygih4hP4WNp3O9MZ/Gg8ww8FGc3wZvBj9GtuPGSE3YUZeJJXa lp8wdFO9 G1xZuFCR0zVz1cvNDvK4yl+q0Mj02YEyRLHAaNzM9fYwW97UEwtf8clH7l/c6ECS/sEusbtz8W6xoK4m8W2RVw9/GquE/sQIjEAntsuhldeYffwisAMIobOi+uhZ+Ka5WmMC+wCS4gT2Gt8dILCwcC02XD5imHzsLSx1WNba6sEpabzimaqB4/jU1IOhkRQ2MJ2PccQwhCNEMMSu0QhHHGKjbOf6urtPok1LmPzgnq7gpTKLYHgQTNCUybf6KJy7N40CCVmkK9WxDd4zez6tIr79+VAMrI/pe+beHDlTp4lsVwE6ni8B+VgNqcQMFjeMg/91a3auZZ+ZbQhcItnhbvwBfHKb2RLiO8Ic+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/21/23 17:50, Hyeonggon Yoo wrote: > When allocating a high-order page, separate allocation timestamp is > recorded for each sub-page resulting in different timestamp values between > them. > > This behavior is not consistent with the behavior when recording free > timestamp and caused confusion when analyzing memory dumps. Record single > timestamp for the entire allocation, aligning with the behavior for > free timestamps. > > Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> Acked-by: Vlastimil Babka > --- > mm/page_owner.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/page_owner.c b/mm/page_owner.c > index f0553bedb39d..80dc8f4050fa 100644 > --- a/mm/page_owner.c > +++ b/mm/page_owner.c > @@ -163,6 +163,7 @@ static inline void __set_page_owner_handle(struct page_ext *page_ext, > { > struct page_owner *page_owner; > int i; > + u64 ts_nsec = local_clock(); > > for (i = 0; i < (1 << order); i++) { > page_owner = get_page_owner(page_ext); > @@ -172,7 +173,7 @@ static inline void __set_page_owner_handle(struct page_ext *page_ext, > page_owner->last_migrate_reason = -1; > page_owner->pid = current->pid; > page_owner->tgid = current->tgid; > - page_owner->ts_nsec = local_clock(); > + page_owner->ts_nsec = ts_nsec; > strscpy(page_owner->comm, current->comm, > sizeof(page_owner->comm)); > __set_bit(PAGE_EXT_OWNER, &page_ext->flags);