linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: balducci@units.it
To: bugzilla-daemon@bugzilla.kernel.org
Cc: linux-mm@kvack.org, akpm@linux-foundation.org
Subject: Re: [Bug 203715] BUG: unable to handle kernel NULL pointer dereference under stress (possibly related to https://lkml.org/lkml/2019/5/24/292 ?)
Date: Fri, 07 Jun 2019 08:22:32 +0200	[thread overview]
Message-ID: <24422.1559888576@dschgrazlin2.units.it> (raw)
In-Reply-To: Your message of "Thu, 06 Jun 2019 14:44:31 -0000." <bug-203715-9581-JKJKlU0qlh@https.bugzilla.kernel.org/>

> Please try the following on top of 5.2-rc3
>
> diff --git a/mm/compaction.c b/mm/compaction.c
> index 9e1b9acb116b..69f4ddfddfa4 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -277,8 +277,7 @@ __reset_isolation_pfn(struct zone *zone, unsigned long pf
> n,
> bool check_source,
>         }
>
>         /* Ensure the end of the pageblock or zone is online and valid */
> -       block_pfn += pageblock_nr_pages;
> -       block_pfn = min(block_pfn, zone_end_pfn(zone) - 1);
> +       block_pfn = min(pageblock_end_pfn(block_pfn), zone_end_pfn(zone) - 1)
> ;
>         end_page = pfn_to_online_page(block_pfn);
>         if (!end_page)
>                 return false;
> @@ -289,7 +288,7 @@ __reset_isolation_pfn(struct zone *zone, unsigned long pf
> n,
> bool check_source,
>          * is necessary for the block to be a migration source/target.
>          */
>         do {
> -               if (pfn_valid_within(pfn)) {
> +               if (pfn_valid(pfn)) {
>                         if (check_source && PageLRU(page)) {
>                                 clear_pageblock_skip(page);
>                                 return true;
>

no joy; I left the FF build running and found the machine frozen this
morning; however, firefox build could apparently complete successfully;
I can't say when exactly the problem happened, as I haven't found any
message in the logs

thanks
ciao
-g


       reply	other threads:[~2019-06-07  6:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-203715-9581-JKJKlU0qlh@https.bugzilla.kernel.org/>
2019-06-07  6:22 ` balducci [this message]
     [not found] <bug-203715-9581-IIXSanmjPc@https.bugzilla.kernel.org/>
2019-06-25  6:08 ` balducci
     [not found] <bug-203715-9581-Ws6dSkF6YF@https.bugzilla.kernel.org/>
2019-06-28  6:16 ` balducci

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24422.1559888576@dschgrazlin2.units.it \
    --to=balducci@units.it \
    --cc=akpm@linux-foundation.org \
    --cc=bugzilla-daemon@bugzilla.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox