Re: [linux-next:master 4766/5417] sound/soc/sof/core.c:135: undefined reference to `sof_client_fw_state_dispatcher'

["Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>]

On 13/02/2022 00:42, Pierre-Louis Bossart wrote:
> 
> 
> On 2/12/22 15:00, kernel test robot wrote:
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
>> head:   6d9bd4ad4ca08b1114e814c2c42383b8b13be631
>> commit: 3dc0d709177828a22dfc9d0072e3ac937ef90d06 [4766/5417] ASoC: SOF: Convert the generic probe support to SOF client
>> config: i386-randconfig-a003-20210930 (https://download.01.org/0day-ci/archive/20220213/202202130429.GEdTKNDQ-lkp@intel.com/config)
>> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
>> reproduce (this is a W=1 build):
>>         # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=3dc0d709177828a22dfc9d0072e3ac937ef90d06
>>         git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>>         git fetch --no-tags linux-next master
>>         git checkout 3dc0d709177828a22dfc9d0072e3ac937ef90d06
>>         # save the config file to linux build tree
>>         mkdir build_dir
>>         make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <lkp@intel.com>
>>
>> All errors (new ones prefixed by >>):
>>
>>    ld: sound/soc/sof/core.o: in function `sof_set_fw_state':
>>>> sound/soc/sof/core.c:135: undefined reference to `sof_client_fw_state_dispatcher'
>>    ld: sound/soc/sof/core.o: in function `sof_probe_continue':
>>>> sound/soc/sof/core.c:287: undefined reference to `sof_register_clients'
>>    ld: sound/soc/sof/core.o: in function `sof_set_fw_state':
>>>> sound/soc/sof/core.c:135: undefined reference to `sof_client_fw_state_dispatcher'
>>    ld: sound/soc/sof/core.o: in function `snd_sof_device_remove':
>>>> sound/soc/sof/core.c:427: undefined reference to `sof_unregister_clients'
>>    ld: sound/soc/sof/core.o: in function `sof_set_fw_state':
>>>> sound/soc/sof/core.c:135: undefined reference to `sof_client_fw_state_dispatcher'
>>    ld: sound/soc/sof/ipc.o: in function `snd_sof_ipc_msgs_rx':
>>>> sound/soc/sof/ipc.c:574: undefined reference to `sof_client_ipc_rx_dispatcher'
>>    ld: sound/soc/sof/pm.o: in function `sof_suspend':
>>>> sound/soc/sof/pm.c:227: undefined reference to `sof_suspend_clients'
>>>> ld: sound/soc/sof/pm.c:217: undefined reference to `sof_suspend_clients'
>>    ld: sound/soc/sof/pm.o: in function `sof_resume':
>>>> sound/soc/sof/pm.c:171: undefined reference to `sof_resume_clients'
>>
> 
> I can reproduce this with the attached config with networking disabled,
> otherwise I have a compilation issues.

I was also able to reproduce it.

> Not sure why we are only seeing this now, this code has been in the SOF
> tree for months.

It came out of randconfig, we might not been lucky enough to get this
combination...

> At any rate, it seems like a legit problem, where some configs result in
> the sof core configured as built-in but the clients configured as
> modules. We need to find a way to force the client to use the same
> configuration as the core.

Changing the SOC_SOF_CLIENT from tristate to bool worked, but I think
the fix via the Makefile is better:
https://lore.kernel.org/alsa-devel/20220214071330.22151-1-peter.ujfalusi@linux.intel.com/

-- 
Péter