From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2FDFC352BE for ; Fri, 17 Apr 2020 14:41:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0AA252223D for ; Fri, 17 Apr 2020 14:41:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0AA252223D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 888C48E0021; Fri, 17 Apr 2020 10:41:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 860B98E0001; Fri, 17 Apr 2020 10:41:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7507A8E0021; Fri, 17 Apr 2020 10:41:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5E0AF8E0001 for ; Fri, 17 Apr 2020 10:41:01 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 16D12824556B for ; Fri, 17 Apr 2020 14:41:01 +0000 (UTC) X-FDA: 76717609122.26.rate22_42e48c077e012 X-HE-Tag: rate22_42e48c077e012 X-Filterd-Recvd-Size: 5482 Received: from out30-54.freemail.mail.aliyun.com (out30-54.freemail.mail.aliyun.com [115.124.30.54]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Fri, 17 Apr 2020 14:40:59 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R871e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04357;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=39;SR=0;TI=SMTPD_---0TvqIRjz_1587134450; Received: from IT-FVFX43SYHV2H.local(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0TvqIRjz_1587134450) by smtp.aliyun-inc.com(127.0.0.1); Fri, 17 Apr 2020 22:40:52 +0800 Subject: Re: [PATCH v8 03/10] mm/lru: replace pgdat lru_lock with lruvec lock To: Johannes Weiner Cc: akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, yang.shi@linux.alibaba.com, willy@infradead.org, shakeelb@google.com, Michal Hocko , Vladimir Davydov , Roman Gushchin , Chris Down , Thomas Gleixner , Vlastimil Babka , Qian Cai , Andrey Ryabinin , "Kirill A. Shutemov" , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Andrea Arcangeli , David Rientjes , "Aneesh Kumar K.V" , swkhack , "Potyra, Stefan" , Mike Rapoport , Stephen Rothwell , Colin Ian King , Jason Gunthorpe , Mauro Carvalho Chehab , Peng Fan , Nikolay Borisov , Ira Weiny , Kirill Tkhai , Yafang Shao , Wei Yang References: <1579143909-156105-1-git-send-email-alex.shi@linux.alibaba.com> <1579143909-156105-4-git-send-email-alex.shi@linux.alibaba.com> <20200116215222.GA64230@cmpxchg.org> <20200413180725.GA99267@cmpxchg.org> <8e7bf170-2bb5-f862-c12b-809f7f7d96cb@linux.alibaba.com> <20200414163114.GA136578@cmpxchg.org> <54af0662-cbb4-88c7-7eae-f969684025dd@linux.alibaba.com> <0bed9f1a-400d-d9a9-aeb4-de1dd9ccbb45@linux.alibaba.com> <20200416152830.GA195132@cmpxchg.org> From: Alex Shi Message-ID: <2403add7-d468-7615-22c5-3fafb1264d54@linux.alibaba.com> Date: Fri, 17 Apr 2020 22:39:59 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200416152830.GA195132@cmpxchg.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: =E5=9C=A8 2020/4/16 =E4=B8=8B=E5=8D=8811:28, Johannes Weiner =E5=86=99=E9= =81=93: > Hi Alex, >=20 > On Thu, Apr 16, 2020 at 04:01:20PM +0800, Alex Shi wrote: >> >> >> =E5=9C=A8 2020/4/15 =E4=B8=8B=E5=8D=889:42, Alex Shi =E5=86=99=E9=81=93= : >>> Hi Johannes, >>> >>> Thanks a lot for point out! >>> >>> Charging in __read_swap_cache_async would ask for 3 layers function a= rguments >>> pass, that would be a bit ugly. Compare to this, could we move out th= e >>> lru_cache add after commit_charge, like ksm copied pages? >>> >>> That give a bit extra non lru list time, but the page just only be us= ed only >>> after add_anon_rmap setting. Could it cause troubles? >> >> Hi Johannes & Andrew, >> >> Doing lru_cache_add_anon during swapin_readahead can give a very short= timing=20 >> for possible page reclaiming for these few pages. >> >> If we delay these few pages lru adding till after the vm_fault target = page=20 >> get memcg charging(mem_cgroup_commit_charge) and activate, we could sk= ip the=20 >> mem_cgroup_try_charge/commit_charge/cancel_charge process in __read_sw= ap_cache_async(). >> But the cost is maximum SWAP_RA_ORDER_CEILING number pages on each cpu= miss >> page reclaiming in a short time. On the other hand, save the target vm= _fault >> page from reclaiming before activate it during that time. >=20 > The readahead pages surrounding the faulting page might never get > accessed and pile up to large amounts. Users can also trigger > non-faulting readahead with MADV_WILLNEED. >=20 > So unfortunately, I don't see a way to keep these pages off the > LRU. They do need to be reclaimable, or they become a DoS vector. >=20 > I'm currently preparing a small patch series to make swap ownership > tracking an integral part of memcg and change the swapin charging > sequence, then you don't have to worry about it. This will also > unblock Joonsoo's "workingset protection/detection on the anonymous > LRU list" patch series, since he is blocked on the same problem - he > needs the correct LRU available at swapin time to process refaults > correctly. Both of your patch series are already pretty large, they > shouldn't need to also deal with that. >=20 That sounds great! BTW, the swapin target page will add into inactive_anon list and then act= ivate after chaged. that left a minum time slot for this page to be reclaimed. May better activate it early? Also I have 2 clean up patches, which may or may not useful for you. will= send it to you. :) Thanks Alex