From: "Huang, Shaoqin" <shaoqin.huang@intel.com>
To: Mike Rapoport <rppt@kernel.org>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
Rebecca Mckeever <remckee0@gmail.com>,
David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH] memblock test: Modify the obsolete description in README
Date: Wed, 27 Jul 2022 17:54:26 +0800 [thread overview]
Message-ID: <24026aa6-24fd-22e9-75d9-b095499e4ce5@intel.com> (raw)
In-Reply-To: <YuEIKdxSJcuLia15@kernel.org>
On 7/27/2022 5:40 PM, Mike Rapoport wrote:
> On Wed, Jul 27, 2022 at 06:16:15PM -0600, shaoqin.huang@intel.com wrote:
>> From: Shaoqin Huang <shaoqin.huang@intel.com>
>>
>> The VERBOSE option in Makefile has been moved, but there still have the
>> description left in README. For now, we use `-v` options when running
>> memblock test to print information, so also add some description about
>> it.
>>
>> Signed-off-by: Shaoqin Huang <shaoqin.huang@intel.com>
>> ---
>> tools/testing/memblock/README | 19 ++++++++++---------
>> 1 file changed, 10 insertions(+), 9 deletions(-)
>>
>> diff --git a/tools/testing/memblock/README b/tools/testing/memblock/README
>> index 058146b528a5..f39cc0aa6b76 100644
>> --- a/tools/testing/memblock/README
>> +++ b/tools/testing/memblock/README
>> @@ -33,20 +33,21 @@ To run the tests, build the main target and run it:
>>
>> $ make && ./main
>>
>> -A successful run produces no output. It is also possible to override different
>> -configuration parameters. For example, to include verbose output, specify the
>> -VERBOSE flag when building the main target:
>
> The description of VERBOSE build option was a logical continuation of the
> previous sentence.
>
> Instead of doing mechanical changes, please rearrange the text so it'll
> make sense.
>
I agree. I will try to give a clear and continuation description.
>> +A successful run produces no output. It it also possible to override different
>> +configuration parameters. For example, to simulate enabled NUMA, use:
>>
>> -$ make VERBOSE=1
>> +$ make NUMA=1
>>
>> -This will print information about which functions are being tested and the
>> -number of test cases that passed.
>> +For the full list of options, see `make help`.
>>
>> -To simulate enabled NUMA, use:
>> +It is also possible to pass options at run time. For example:
>>
>> -$ make NUMA=1
>> +$ ./main -v
>>
>> -For the full list of options, see `make help`.
>> +This will print information about which functions are being tested and the
>> +number of test cases that passed.
>> +
>> +For the full list of options, see `./main --help`.
>>
>> Project structure
>> =================
>> --
>> 2.30.2
>>
>>
>
prev parent reply other threads:[~2022-07-27 9:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 0:16 shaoqin.huang
2022-07-27 9:40 ` Mike Rapoport
2022-07-27 9:54 ` Huang, Shaoqin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24026aa6-24fd-22e9-75d9-b095499e4ce5@intel.com \
--to=shaoqin.huang@intel.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=remckee0@gmail.com \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox