From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21BADC25B74 for ; Tue, 21 May 2024 09:37:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 955656B0093; Tue, 21 May 2024 05:37:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 902976B0095; Tue, 21 May 2024 05:37:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 77C856B0096; Tue, 21 May 2024 05:37:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5A9196B0093 for ; Tue, 21 May 2024 05:37:11 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id CC36BA0207 for ; Tue, 21 May 2024 09:37:10 +0000 (UTC) X-FDA: 82141899420.13.E8D88A2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 9DBD014000F for ; Tue, 21 May 2024 09:37:08 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Xhjf48Iz; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716284228; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rDFlJpNTjiUekAo5FWMGJemrvpMD/p0F/vFU1Y8pBs0=; b=RvDLEdjJUDHt5P7AgRx9XsCKKu7yJ3R1ln+UhI4YNkYQ4NmMXfAkdDb3tXc3MAN5Aw/wBy zXEfVStqgKnYNxR2GQCALQvUJ7+NbH5pKgItaUxnlEzuwP2QyipYMZ8pRkwivDZIk4dLjD Z55UPjP3xygrcQXnw+xuaYyGUWN47zA= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Xhjf48Iz; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716284228; a=rsa-sha256; cv=none; b=5ePBa7fjK7tpfAoKphhoof0WwZz97EKXkW8oJvlEdCGjv3tWnOaIxIXAdeEjfKvR4iX9XD IqGg1otcxwzoylRVgz8yv/5Zp3tppfGKh2qjpinNb54CmZKV684XrI+wYWQfbYm7yT50UE 1ZUnZJSCyOGRps+L0WAsfL3D/tXzLBA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1716284228; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=rDFlJpNTjiUekAo5FWMGJemrvpMD/p0F/vFU1Y8pBs0=; b=Xhjf48IzYS7mEvQtXi308fwssi4WRDFaTRc3rD4EDlV8amqyFlRpVue+15iwiZ8l8QY5NQ Zlxx7AFeZFD/WSgDB9Lm2AJJRNR1XYXiMl9GCUMxAJ4seBsagVG35aLkcY96OMbEPiF9YY NzwY1CMESTO3L6zaKKe/cULiycjrrhg= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-463-y2oUncMoMD60O5MGcpuPQQ-1; Tue, 21 May 2024 05:37:06 -0400 X-MC-Unique: y2oUncMoMD60O5MGcpuPQQ-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-354c7c04325so1038926f8f.0 for ; Tue, 21 May 2024 02:37:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716284225; x=1716889025; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rDFlJpNTjiUekAo5FWMGJemrvpMD/p0F/vFU1Y8pBs0=; b=bmK/OKAH0fW49H6vdHjix9yDbf3q7GrQo0jpfBlugELQbEbz7Ulfk9JivNm0wY44Dx 2laLsf2GqFXUP3wgXqWwAXJqexvT6kSjmeyI+ITdnIPmuCOM5x+Wy04svZj+Sz3gjW57 axN/2qsHFSMkaJjJbVTdgValDr276L5rRGsyhyqvim0kTXoPQEcFHx+8VO5Bv8OQq3iw xQdjSTNxmwKZ1ssaY08CAPJX2EPy5vwV5TIj8LBLG1MjesU6O4e/BOC6zBGfN0nOWkCz tKnYnVC6jSYatHhw2kVtR+l92wYI8lyabRUIvdd5ZzJUknmVp+IPytpkJc0B6QsV+SS7 nhlA== X-Forwarded-Encrypted: i=1; AJvYcCXXIWOCCEMCuTxkCL20lxA5ffWgQEGW97Vdtkh2rc23JmrEmnyeKvmn1/p+G6cQeyqmTJS9Up5mDDoWNB118Qj5peo= X-Gm-Message-State: AOJu0YzV9FkMjpGT1GLQUUtVbtCySS0gMRm54kXOHlLVGLwBWHh/p9V7 3y9CdI66dFGw+fixKUuCJYgFQz1aV0O6DReNGq9EtPabs7/oJCLHdKnHpBk/sBUDbv7xKhWrSF0 u/GRmg9XSymxurTv3inS/fShXwz25PBRnXgks4jOmoSlfEDiv X-Received: by 2002:a05:6000:e50:b0:34a:6fac:6dab with SMTP id ffacd0b85a97d-354b8dfddc1mr7273223f8f.12.1716284224889; Tue, 21 May 2024 02:37:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHZHbSrxCuT/wa8crEuH3CPQzv1FNo859SSRyP6VjZBMZLItGlJKgLbp9PLk0pfe2Z3u4lI4Q== X-Received: by 2002:a05:6000:e50:b0:34a:6fac:6dab with SMTP id ffacd0b85a97d-354b8dfddc1mr7273204f8f.12.1716284224572; Tue, 21 May 2024 02:37:04 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-351d3bdad9bsm14849747f8f.46.2024.05.21.02.37.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 May 2024 02:37:04 -0700 (PDT) Message-ID: <2401d1fb-33cb-49b0-8bd7-594ff3e5ae91@redhat.com> Date: Tue, 21 May 2024 11:37:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/3] mm: Use update_mmu_tlb_range() to simplify code To: Bang Li , akpm@linux-foundation.org, chenhuacai@kernel.org, tsbogend@alpha.franken.de, paul.walmsley@sifive.com, palmer@dabbelt.com, chris@zankel.net, jcmvbkbc@gmail.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, loongarch@lists.linux.dev, linux-riscv@lists.infradead.org, ryan.roberts@arm.com, ioworker0@gmail.com, libang.linux@gmail.com References: <20240518074914.52170-1-libang.li@antgroup.com> <20240518074914.52170-4-libang.li@antgroup.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240518074914.52170-4-libang.li@antgroup.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 9DBD014000F X-Stat-Signature: ihposcjphgru68ohw9eib74c58c4hxps X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1716284228-829803 X-HE-Meta: U2FsdGVkX1+uUygdNmSW1FdxiyLl2KCkrN9XV6z7oHuJEn+/jynj8xsPuEG4ux2smb0OOfeUcqazAAkI2VwC7bvkUl6ffQbi5rsGTwoNKH30v24lTme7DebyK7BFYhuV3vK67nSJ2pjY5OWtMExK5sySFKflaVAKK1sC/iSvILa6kuIGFayg0QCn7Cn0fy7DKa0zO/VAESVdf9HfJ0tlMmjNk7cQWrpgFVO0gEYO2+4UKJtbKkfmZp22HkRmVh4zQ8uXOnoFFmJVN739Q5tvBH+gD5m6mymh0aAiiJkXHtpjY9DNoqSOnDjd09DLGwm3qzxIgySKhnlyOOAAsc57C9vGjlAe9n48A3E8/InH3LUdCkv/3W78FmA+7iI+w9siXgiok9kdnQfrErzElWjaXuLUArUKmZVLyQgunOtW13GJWdC2QJevcRVv5ZrJg9hzVX4OdijbE7fOnwwsLOCOLc/lzJIwwP9bb5Z8bF6gIqBlxAMGQgfiyQzbme7Vr8JBT9o8A7zS/KeQK7kNM6Sfqwarmi2MApJZih1ByFhGbcW71UM87A8DrtmNSlff6XaqJD1Bu8nhnmeyXegKR1ARxKBgYwdEqTS1UAsOPHer1RrbZUDxrH9Mjhrbg8RGFo+JuMfBW6iE0gsyoD02zyc+VnKi1d1CrlfckYB+KopdJVOlR8BTy64BGWVilUA/rcAnRrt3WpRxFLpJkmrJgOu1hstxxGesQgYVmKSpwscOXOBw983363X2jX+CKIL7b+0e7i4Ng5DNKhoUeA7ZakjLW9lzEtF0mpO5OoXLvvA7+LhHgKKXpuCalwB9V0frQ69sCseb/raeh3pCmTzCL55vulSFGmCN0EvPhKdOc49x7LLWSL7mIIGlQ5NHsZVVCseQgIx98V+p3IRJ8PPoqvziYoGxaKbnEiSxorYkdWpxla57PYZMi2kpQ1vv552ubUJRGXUa0lOMO4CbT8AmdGq IDmFCJh7 ofs6mFOjRSxzecqhLsAzLNIois6WOTLP2ZxMcLSlH9v25nGgs8keU9YXXPGjykl7uomaUVWbAmfgbA39oWZVCutw16+G15lDYuVccwgmN3M+6J86h7zLjyT7o7QX8gOlCzR7YRN8gaByvxjLBrdcUGGTyDkQg4pzTZ39vChNdORi/7vSpUg9khqSaQ1I8MmDEUHLaJplUX9NAlc0GXrkfuN2sWiUTn+2t0r5Yseh2dk3lBhuycWHxvsnjt+FmpTUJ6mQ0NEK5EuZmddy8/JxnXSXXj+GPKstgcqr285tnNPxHbHA0PW2Vl4JL5gXKoJ3rUum6V9xZd7jMvlfmiIIP3zy+2riPDS/q3D7Jt3rpxGeXivN7jJi3UxcPGSC28H/9nuQyjzsE3OCp2V7xGMPx7Fyg/WvC2CF2TU0+2KE0XH4A++ZAL3Rt7J56Hbm2vnM2fvM1VAIp9hES13C2t89n+bwhANwdoCIW/A0rqMeRA2y0Hrx6mXRRBtM82p/mXcsLRlGlUNi/Qa87Qb/UNmX3OA83SfZHwEjbpGcpLfKyLC+CYBDomVTAN13J+31EXbm0DXLxt7lq/j5BMrqs6VnCrmjhfXH/ri+gGNU8nf5mjD6STl6jpdHDHle9pQynRu9duDqNGc2U98WhUHdXIWHJFQxAJZIlWv+VZWp3wQxdDv8+2MAcqiP5aGrdtwGqDRqugK8F X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 18.05.24 09:49, Bang Li wrote: > Let us simplify the code by update_mmu_tlb_range(). > > Signed-off-by: Bang Li > --- > mm/memory.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/mm/memory.c b/mm/memory.c > index eea6e4984eae..2d53e29cf76e 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -4421,7 +4421,6 @@ static vm_fault_t do_anonymous_page(struct vm_fault *vmf) > vm_fault_t ret = 0; > int nr_pages = 1; > pte_t entry; > - int i; > > /* File mapping without ->vm_ops ? */ > if (vma->vm_flags & VM_SHARED) > @@ -4491,8 +4490,7 @@ static vm_fault_t do_anonymous_page(struct vm_fault *vmf) > update_mmu_tlb(vma, addr, vmf->pte); > goto release; > } else if (nr_pages > 1 && !pte_range_none(vmf->pte, nr_pages)) { > - for (i = 0; i < nr_pages; i++) > - update_mmu_tlb(vma, addr + PAGE_SIZE * i, vmf->pte + i); > + update_mmu_tlb_range(vma, addr, vmf->pte, nr_pages); > goto release; > } > Acked-by: David Hildenbrand -- Cheers, David / dhildenb