From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57BA8C3DA4A for ; Thu, 8 Aug 2024 18:13:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C69AB6B0083; Thu, 8 Aug 2024 14:13:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BF2A46B0085; Thu, 8 Aug 2024 14:13:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A44E36B0088; Thu, 8 Aug 2024 14:13:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 864386B0083 for ; Thu, 8 Aug 2024 14:13:02 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id EB158415ED for ; Thu, 8 Aug 2024 18:13:01 +0000 (UTC) X-FDA: 82429874562.16.4199762 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf29.hostedemail.com (Postfix) with ESMTP id B623912002E for ; Thu, 8 Aug 2024 18:12:59 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LnWa9TCC; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723140747; a=rsa-sha256; cv=none; b=KmPNiYjykjJPx3nyQUDu8JiVl/5TNfCRemsomsIwZ7WASsUeLMhCFEoGUw3MnSRg7fL0E+ NXG1PWDYgf2B9Me9+CbM20k7IXK7GWVhFHfXBBzibGcjTvUT7E5lW9srY0Txe2jU4AEodv wYLOA7c8Jx15mHXB4mNYg62omLlCXGM= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LnWa9TCC; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723140747; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Sby/LX1Z7JxkNjpyIbfQ0FNVYX/5ZiYS7SaHjE6I1kI=; b=Qr3rD8Pwdg+pW/Rn+YwhbTD+9eTB1qR/MEOAT6F2Dor8+IeFhPoaJNJLJ2td/abDdXPlUg N76xMcli9S5nPWUKTU8AaspjzoHb1j3SwrdD4Kv7XfBnvmCFpFPIHb+nRw2onk8rqCWfGr 6a0l11Ijf1fAi9xO2ICrNTA2f+w1Z8Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723140779; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Sby/LX1Z7JxkNjpyIbfQ0FNVYX/5ZiYS7SaHjE6I1kI=; b=LnWa9TCCMrDPTttujY/VgqDRpjBORvQgUSXkfEGTSwjZkoj8A00BK25gs7M+1ywqJKWouD 4iuDnCv5NENXGSmGHOHDaalW+WCjtw90qdH3tVN+u1OssOBBeHLsthUa+P5WkMc9amYM96 KZmZ0t68Jb+NGvhJ1IoJpobRYR/JROw= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-607-qdCkYwjRNL-2XVWTNr68MQ-1; Thu, 08 Aug 2024 14:12:55 -0400 X-MC-Unique: qdCkYwjRNL-2XVWTNr68MQ-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4280e1852f3so9178695e9.3 for ; Thu, 08 Aug 2024 11:12:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723140774; x=1723745574; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Sby/LX1Z7JxkNjpyIbfQ0FNVYX/5ZiYS7SaHjE6I1kI=; b=BAzQqci4GDQR6yR9+FF4TlUBlKO04BDAWil6JxTYa55p1JyeFuTOkoa6vJwyZySfmT JeIpX4SMCl988mmDV/7oWTgMgv8JizWI2ZiDY7ug1KJVpLQB3dNDFCjg3HmsgX++8S1o IQE7+MvFl3y56VE9rASqNW+gcsC6+o65jbVNWFyTlfBVGHFOXRV+IjdA0VJ6OIDZCe0z fs+lzeXo09wV3kVSSGZ6fHTWOTFq3tHjquafrP/HcxJJeCGoezjmSNA0miwsvEGR0cwF ceul8fUgdvxMJc5tJM/CpxGQMAfChRlwMJN6x8u+raVEr8AyqmRL0tk+KeLfnfN1bcrs y0+g== X-Forwarded-Encrypted: i=1; AJvYcCVkfVHyA11sVNEqNCOeMXlCFyMOOLokGkxFv7rUdKAdlIq9YxxJzNpkt1YEVe0kTFaraqF64i8qntq0o7BFs6v4tH4= X-Gm-Message-State: AOJu0Yx2DSY2ZXt84YXYPfrTBZWIQa7Q4sxCW9hdrUYN7Ft/Xb8wXTlD QEPTTTwlvYTty5jvKP34kvghkzx5XXK8JrtTKzPcX098qqC+waEmTMyCSnsxM0EgWDuN13aXmmo QMyisvTdKJs/KvYCeALvJT2tm6rzKmBvB8ZjYIVPakCnB8TWv X-Received: by 2002:adf:fa4f:0:b0:368:3ee5:e3e1 with SMTP id ffacd0b85a97d-36d273cde58mr1692225f8f.7.1723140774253; Thu, 08 Aug 2024 11:12:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEYjRZzGeEoOB+7CuuXgLrCB1uYf8qQUNYyEmlp1E1bTlB1Ve2QnSpVqkr+g30YSrqwVM9+EA== X-Received: by 2002:adf:fa4f:0:b0:368:3ee5:e3e1 with SMTP id ffacd0b85a97d-36d273cde58mr1692213f8f.7.1723140773726; Thu, 08 Aug 2024 11:12:53 -0700 (PDT) Received: from ?IPV6:2003:cb:c713:2a00:f151:50f1:7164:32e6? (p200300cbc7132a00f15150f1716432e6.dip0.t-ipconnect.de. [2003:cb:c713:2a00:f151:50f1:7164:32e6]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36d27229689sm2693875f8f.95.2024.08.08.11.12.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Aug 2024 11:12:53 -0700 (PDT) Message-ID: <24003526-ba18-42fb-b5c0-7b89872eb61e@redhat.com> Date: Thu, 8 Aug 2024 20:12:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/4] mm: don't account memmap on failure To: Pasha Tatashin , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-cxl@vger.kernel.org, cerasuolodomenico@gmail.com, hannes@cmpxchg.org, j.granados@samsung.com, lizhijian@fujitsu.com, muchun.song@linux.dev, nphamcs@gmail.com, rientjes@google.com, rppt@kernel.org, souravpanda@google.com, vbabka@suse.cz, willy@infradead.org, dan.j.williams@intel.com, yi.zhang@redhat.com, alison.schofield@intel.com, yosryahmed@google.com References: <20240808154237.220029-1-pasha.tatashin@soleen.com> <20240808154237.220029-3-pasha.tatashin@soleen.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240808154237.220029-3-pasha.tatashin@soleen.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: jjx8yknh97apb9r4g311b9whfchhqjyo X-Rspamd-Queue-Id: B623912002E X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1723140779-765536 X-HE-Meta: U2FsdGVkX193migq/fSC/Yq5s9StY+6uSgLJABcKq8vG9an8P3yQZ5Ucwy1LVCGTl+f3ZcZNLAPwEVLWr/+RZdbE0gcRMvaci/GnLEmuddsNCYrYfGWLe8eGLjqQb6sgDaafB5iK10TsN80jk9wz/gjLLkFAtunaTR1LBoxwuTOwsrkZJi2/7Tm0LjDvNF215Gy2mpR80hdTXeeM1ME7KJQ/qsSExQAbfqznzyvJrQehEc9cNxwWcO9cmi6lsB7bRvvAkuMoUTcSZhrwCw2DE748tFrzb0AHexH9sWiiYOmj1kzMk7DVUAjFNTZ/RSzgmjw7hU/S/e0nDwICFvz4kpLeavPJYDpdwVnzjc9xC6J/GQnxkGrgZqrH6+Mdh6JKpHWUxHZXGlBex5jKihwVXkWR5nBdW4SsuY2rhSW2bOYJcojJQqQRCwrX96QrQ/z7YJRvVMZqhYThb+WqeFFuJgt5UXgE65aNcKAmycnDOMnmk0xkzosc4MVwW60SIBuFgzOhrBexCyRIf+SCwJGHEkQ2pOf5cieOqhrVns4+KKpihpOnW0iqaUyLp9yWqgF1D3CNHufOWXGnVNVc2WsY7CKCYH4/194qibHydIEOKUIhh1BwaJMrkIVM5FDQj587m5ZckuKH3hedHQwatBW6AJ/bBNegLty7z5tk12pYySf3N93Q735t8c5hFPa+KGfmmm2tHNcls/XpGL65MABjpP0MvK9t+waX8OjTda21PlJOPShiiU/8O1jHTmJ8Jz+cbMGHjUHYEmhjirkW0xXzdExq7NyFTYNaBNhc9v24t+KICVZF80Zo33T1S7leMa/9S62G2hRmn5cpEa/Mx6qfG9xXYnqisNC75YrytB4kYLEoozVNySYv2SKyJtFnGOO6qqBo3p0miK5g7HsM/GNnZ8agbpch6i0XBJ0TknKyz+HSXyD+aBKlRmx1GbsCH5HCeFmdrLyVhpOvrPsZEtr fzVR/IHJ gIFF2Xk/qoUOke84eHm45coU6CiQvfOL7Jp7P040fvRJh/kZVXL/HoFQ1x81sBAqvFwwBZPGup66TveWek58dTWQj/dQLTuBACz07ChFNNIBBIpc899Xz0aLlQ9Ee//UFJggSLoWHu6Wg0T8OuixuGjggImGfL3EG1i9qUeraeFGp9/tEEiyNzSltX3ReFNOqLkmo2qpwcuVmzHzhNJnyMsdPbVh2Ek32Ts+S50psPQoZ3jW50Nh1GU4/pWbRAqGcVGEDZskv9gBQqE3+G1G1Q7Yse16eGFallP0NIGC2/woq1QRu74IOxbXLU1sNRTKUjSMp8QF7auOiJk8tIsLYx2ne9K3+85ZLH/cblseQDI1HL9B6QMQHNytdVmVKfrQo0GgALb2gv3LI4KQylF48VgxQOw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 08.08.24 17:42, Pasha Tatashin wrote: > When in alloc_vmemmap_page_list() memmap is failed to allocate, do > not account, the memory is going to be release at the function exit. I would write it as "When we fail to allocate the mmemmap in alloc_vmemmap_page_list(), do not account any already-allocated pages: we're going to free all them before we return from the function." Acked-by: David Hildenbrand > > Fixes: 15995a352474 ("mm: report per-page metadata information") > Signed-off-by: Pasha Tatashin > --- > mm/hugetlb_vmemmap.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c > index fa83a7b38199..70027869d844 100644 > --- a/mm/hugetlb_vmemmap.c > +++ b/mm/hugetlb_vmemmap.c > @@ -392,13 +392,10 @@ static int alloc_vmemmap_page_list(unsigned long start, unsigned long end, > > for (i = 0; i < nr_pages; i++) { > page = alloc_pages_node(nid, gfp_mask, 0); > - if (!page) { > - mod_node_page_state(NODE_DATA(nid), NR_MEMMAP, i); > + if (!page) > goto out; > - } > list_add(&page->lru, list); > } > - > mod_node_page_state(NODE_DATA(nid), NR_MEMMAP, nr_pages); > > return 0; -- Cheers, David / dhildenb