From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B777D462C0 for ; Wed, 13 Nov 2024 15:09:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D604C6B00AC; Wed, 13 Nov 2024 10:09:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D0FD66B00F4; Wed, 13 Nov 2024 10:09:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B63036B00F5; Wed, 13 Nov 2024 10:09:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 979F26B00AC for ; Wed, 13 Nov 2024 10:09:55 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 35AD9160B19 for ; Wed, 13 Nov 2024 15:09:55 +0000 (UTC) X-FDA: 82781404566.03.8D7B8E8 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf13.hostedemail.com (Postfix) with ESMTP id 5AFC020022 for ; Wed, 13 Nov 2024 15:09:08 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=swqLElMO; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=jWHHpyRo; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=swqLElMO; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=jWHHpyRo; spf=pass (imf13.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731510399; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=L4iJ1l2BTJVeMoB7baqjT7BcG8SgipsbPqwJAjDalYo=; b=pXNjM5fZCWyBQUpli/XqjHKKBTurAefOV8LD2BjFTbqYaUdo8AlHWGVWV0bGW52OIWQMlf GRv8H4ec2kl8z98H7YP24WqMWbgJXtuQOPUIdr7MvB1M24ZVCHjrC7BfI2bEMocASYitJO iYi7Bj0rpwk+R+RAoPHZKQL8SKnC5rA= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=swqLElMO; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=jWHHpyRo; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=swqLElMO; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=jWHHpyRo; spf=pass (imf13.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731510399; a=rsa-sha256; cv=none; b=sHuGeW5SX9H5asvb9Jq6kB13wWdVcrEtXNAsZZvZ0U9dm378plyRIEqrnPnrqW1l7z8lQC HZnmMLTjSR9Jd33eieULAogI1DuwuPUix/N1r07sS7f5pefuLX0PMspO0ycrsqWDxfbiFN XYmTwvBUqXbjwEF5Q5FjchKSnnoPOAs= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2DF4121137; Wed, 13 Nov 2024 15:09:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1731510591; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=L4iJ1l2BTJVeMoB7baqjT7BcG8SgipsbPqwJAjDalYo=; b=swqLElMOtmlH28HnWbiSY8pE8puNrD4SI9Ju2ZRfBRrBD5uYgDIbNZE6GehJkVckOvAvka olosQ50gkZlYAPJuIrceQ3AYydYYB5ZWCASfduM/j5TgBGx5ljiIoUjBzixjH7pmADDnJD HSXIHfIGrM+bxG1g30Z3o3ZvFSTNHgk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1731510591; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=L4iJ1l2BTJVeMoB7baqjT7BcG8SgipsbPqwJAjDalYo=; b=jWHHpyRoD248PFt+uzVbGDlRaA7eBxocpi3mTdiXpkc33RJkVX1LZi45KOa2yEYBwpNjKi hoZmZlBAbXdJW0AA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1731510591; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=L4iJ1l2BTJVeMoB7baqjT7BcG8SgipsbPqwJAjDalYo=; b=swqLElMOtmlH28HnWbiSY8pE8puNrD4SI9Ju2ZRfBRrBD5uYgDIbNZE6GehJkVckOvAvka olosQ50gkZlYAPJuIrceQ3AYydYYB5ZWCASfduM/j5TgBGx5ljiIoUjBzixjH7pmADDnJD HSXIHfIGrM+bxG1g30Z3o3ZvFSTNHgk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1731510591; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=L4iJ1l2BTJVeMoB7baqjT7BcG8SgipsbPqwJAjDalYo=; b=jWHHpyRoD248PFt+uzVbGDlRaA7eBxocpi3mTdiXpkc33RJkVX1LZi45KOa2yEYBwpNjKi hoZmZlBAbXdJW0AA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id DFC8813301; Wed, 13 Nov 2024 15:09:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id d8/wNT7BNGcqCgAAD6G6ig (envelope-from ); Wed, 13 Nov 2024 15:09:50 +0000 Message-ID: <23fdd6b6-3922-43e8-9aeb-213534ba3e94@suse.cz> Date: Wed, 13 Nov 2024 16:09:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/5] mm: move per-vma lock into vm_area_struct Content-Language: en-US To: Lorenzo Stoakes Cc: Suren Baghdasaryan , akpm@linux-foundation.org, willy@infradead.org, liam.howlett@oracle.com, mhocko@suse.com, hannes@cmpxchg.org, mjguzik@gmail.com, oliver.sang@intel.com, mgorman@techsingularity.net, david@redhat.com, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, paulmck@kernel.org, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, hughd@google.com, minchan@google.com, jannh@google.com, shakeel.butt@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com References: <20241112194635.444146-1-surenb@google.com> <20241112194635.444146-3-surenb@google.com> <637370b8-3e3e-4457-81d6-5913a3ff1d4e@lucifer.local> <7eea5f41-acf0-4feb-8138-a93b67473ccb@lucifer.local> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <7eea5f41-acf0-4feb-8138-a93b67473ccb@lucifer.local> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 5AFC020022 X-Stat-Signature: gien8xq84tbdwueuiou87hr4gr16x6iy X-Rspam-User: X-HE-Tag: 1731510548-450055 X-HE-Meta: U2FsdGVkX19QuMu8+x+bSVAVnCOC61DL21FCqVXg8ywfnt9NyJEoTkEhCw0X6thcGQIpXljBPEqlrG0vwiEsgq4V9ePFFT870BHut/aWEGFOQKbIX0uc6Z6iqZzDRyh/dH7uvqXbzKPXO8vp0EoD/NfWEqyN/zHEfrfeAueWs38U56kFjRKi38ueSANjg7WBO49bCcvD0wgcwfMEHLcSaJvzlIRRNeDqen1slL4R2PNh898g78ekeXFKkheJ6sTfllO3Vsx6tyo8+o0FG/zsB4Ys5Rbq6rfuIs5brc31c7Pz3/kjgJRt5kY9xjWGoGljg/MVZF31eANzAcBdoqMedehoaL1fjbqzjbpqkBtT+Qq6tax8Pn+fojZHiWLRTavxvewbd75LPwl3z5s8xdaE93KcKVS+pHSu7BEoKxuOfuxDpCMzlX+Fd0mF+luHcS3vKgg+W8dMVnwuKEe0hTLsmcLw4AI3sf28uBgAzC8ggo46BizIOyEeGu1CSo8GZRpM9TmeI6URmGy4Ixxb2bpzJG21Y2g+csPhZh9k75Wu2czoKHsC4/XGjd2/66FmOAA2GKOrKwywaevhsx0IOB4VoFr90rF3LhtJMSQFDiVNds18gwSNQiL5VEwRuvo6cOfIPkyVAeu2+m316uEvr6YA5aZT0b1pbVOuitul1Qz1PN03m4ePkWYlfYbg/N1ltC5orb6/xBStUa4JB24oFQ4YeqPPLcH0xLN5Zg1OKGOfZOIwHqn4IopwTfWfj9ZBvyw10Ws9nTAaWeqjzBPG7ogWcCp5pqkiHGvaGRsMiz9OCPU2cgFS2ZeD8cPMLE9irmOXRbXnNIjXpEEiS6ZseTj7717P/n+oFHIj149sy2fNeFBLYwoDwPGej5eAtpNWqRw3ydwtfQePGpXeESlVb6kV5gdsrP8O2Xu2DCa7LKwXcORU1hpsuwzAlfMs/BNTo5B1ozxnBFhyIk14UylImKZ 2Isf/mWV O7RDzS4ixlrDhgIb8vm3s3N3BW96U3/pA7MowhXEHbGnFBmI9X4ctxzJt/WkdXQUSKAH45Izp7tWlXwW+8KTLl6wgqK9ClU6YTfqx/SDOxVS1/XKZTNWfeMm833fgX6tkrOUN+Fmh4Qz71+5FGbLCQuss9JWRjXvIGtVmOz5CRYi2jfH3B00esGDpnk/d7ZwEAH8aGB28K9mlwchtiXrGnQEee+30Bh2qYhI7eY6n09tFdQ2Fsk+qQGpoPhCVOWN6pJO50JRWGQhTj5e0ckXMnwo4AMtMKD9sOXW+3LB+DFRyvrf7i8gE9x+MgHKGKixMoVVAqZ3tdrUFkrBdan8Xef4eE1qnbngKzwRoL46FRI5Lwq5+jISARqSkuM3+WOzlR7HVd4C5Tt1Wmp1EXDKt9FMVJQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/13/24 15:58, Lorenzo Stoakes wrote: > On Wed, Nov 13, 2024 at 03:45:24PM +0100, Vlastimil Babka wrote: >> On 11/13/24 15:28, Lorenzo Stoakes wrote: >> > On Tue, Nov 12, 2024 at 11:46:32AM -0800, Suren Baghdasaryan wrote: >> >> Back when per-vma locks were introduces, vm_lock was moved out of >> >> vm_area_struct in [1] because of the performance regression caused by >> >> false cacheline sharing. Recent investigation [2] revealed that the >> >> regressions is limited to a rather old Broadwell microarchitecture and >> >> even there it can be mitigated by disabling adjacent cacheline >> >> prefetching, see [3]. >> > >> > I don't see a motivating reason as to why we want to do this? We increase >> > memory usage here which is not good, but later lock optimisation mitigates >> >> I'd say we don't normally split logically single structures into multiple >> structures just because they might pack better in multiple slabs vs single >> slab. Because that means more complicated management, extra pointer >> dereferences etc. And if that split away part is a lock, it even complicates >> things further. So the only motivation for doing that split was that it >> appeared to perform better, but that was found to be misleading. >> >> But sure it can be described better, and include the new >> SLAB_TYPESAFE_BY_RCU conversion part as the motivation - that would be >> likely impossible to do with a split away lock. > > Right, my point is that there is no justification given here at all, and we > should give one. I understand the provenance of why we split the lock, but > there has to be a motivating reason if everything is working fine right > now. > > The SLAB_TYPESAFE_BY_RCU one seems to be the key one, but also something > along the lines of complicated management, concern about ordering of > allocating/freeing things, etc. > > Just needs some extra explanation here. Right. >> >> > it, but why wouldn't we just do the lock optimisations and use less memory >> > overall? >> >> If the lock is made much smaller then the packing benefit by split might >> disappear, as is the case here. >> > > Yeah, but the lock would be smaller so we'd save space still right? If it becomes small enough that it makes the vma including the lock fit in 192 bytes, then we're no longer saving space by keeping it in a separate cache. Yes it would make the motivation even more obvious by shrinking it first and then saying "look, we can even save more space by not having it separate anymore". But there's the downside of nonstandard locking so I think the order of changes that first unsplit the lock and only then consider the pros and cons of shrinking makes more sense. >> >> This patchset moves vm_lock back into vm_area_struct, aligning it at the >> >> cacheline boundary and changing the cache to be cache-aligned as well. >> >> This causes VMA memory consumption to grow from 160 (vm_area_struct) + 40 >> >> (vm_lock) bytes to 256 bytes: >> >> >> >> slabinfo before: >> >> ... : ... >> >> vma_lock ... 40 102 1 : ... >> >> vm_area_struct ... 160 51 2 : ... >> > >> > Pedantry, but it might be worth mentioning how much this can vary by config. >> > >> > For instance, on my machine: >> > >> > vm_area_struct 125238 138820 184 44 >> > >> >> >> >> slabinfo after moving vm_lock: >> >> ... : ... >> >> vm_area_struct ... 256 32 2 : ... >> >> >> >> Aggregate VMA memory consumption per 1000 VMAs grows from 50 to 64 pages, >> >> which is 5.5MB per 100000 VMAs. This memory consumption growth can be >> >> addressed later by optimizing the vm_lock. >> > >> > Yes grabbing this back is of critical importance I'd say! :) >> >> I doubt it's that critical. We'll have to weight that against introducing >> another non-standard locking primitive. > > Avoiding unnecessary VMA overhead is important, and a strong part of the > motivation for the guard pages series for instance, so I don't think we > should be unconcerned about unnecessary extra memory usage. Yeah guard pages eliminate whole VMAs from existence so they are great :) > I'm guessing from what you say you're not in favour of the subsequent > 'non-standard' locking changes... True. >> >> > Functionally it looks ok to me but would like to see a stronger >> > justification in the commit msg! :) >> > >> >> >> >> [1] https://lore.kernel.org/all/20230227173632.3292573-34-surenb@google.com/ >> >> [2] https://lore.kernel.org/all/ZsQyI%2F087V34JoIt@xsang-OptiPlex-9020/ >> >> [3] https://lore.kernel.org/all/CAJuCfpEisU8Lfe96AYJDZ+OM4NoPmnw9bP53cT_kbfP_pR+-2g@mail.gmail.com/ >> >> >> >> Signed-off-by: Suren Baghdasaryan >> >> --- >> >> include/linux/mm.h | 28 +++++++++++++---------- >> >> include/linux/mm_types.h | 6 +++-- >> >> kernel/fork.c | 49 ++++------------------------------------ >> >> 3 files changed, 25 insertions(+), 58 deletions(-) >> >>