From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABD0DC02185 for ; Fri, 17 Jan 2025 16:58:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 413A1280008; Fri, 17 Jan 2025 11:58:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 39DA4280002; Fri, 17 Jan 2025 11:58:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1EFB6280008; Fri, 17 Jan 2025 11:58:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id F030F280002 for ; Fri, 17 Jan 2025 11:58:42 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A761645737 for ; Fri, 17 Jan 2025 16:58:42 +0000 (UTC) X-FDA: 83017552884.25.CC47C1E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 20C4B4000B for ; Fri, 17 Jan 2025 16:58:39 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Tg5Lo23H; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737133120; a=rsa-sha256; cv=none; b=YRVqF/843r6U6bRMYrjPOyVnT8VD3dGSfTLsOhHV6rhpG8K6LsdSnn6Wnmw5GVPIqskZdV d31l701OFHARiGLOzF1yqMkHUw5UBgOUn16eWZEpz/XS6wK1K9bj4G4leD53qOdG/eIYPU L+Z5tBvfE49rlInvcxytlt97EKnoD3M= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Tg5Lo23H; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737133120; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3RDMY+65UFDdSOlQmyBvvEbMu1oS+daUhpKHh3ifXvQ=; b=lMid7eW1nK2tVH4lYyd6jWowwAjKIsyHxant1bvyq2wfA2Sb39lNHMiRNN3yhQIgpoTyJl VgbAvWlF0XUtYLOXde/getSJd4N+SXDpDWpHbQbtc2qWTKkneU41rmqEjeX1ijhipIa/eP KUfJr9NKG0Mggv0Cn82FSGDH+T5BTEk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737133119; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3RDMY+65UFDdSOlQmyBvvEbMu1oS+daUhpKHh3ifXvQ=; b=Tg5Lo23HMG19grR//GkZvTzNFp//YN1xyAEwqlBTW4Af/5XB1MPQrhF97QSTNf21EMHs2K V5Cy8KrG5SWGJo+tHj1rm+HKY/fWQ2F0HlT+6vEAK0xYKoMXNjW/ui52aQkJv4pgXzfEgW gB68igF2o2gckagWfg8xzqPNpbCDsxA= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-34-x2xRa_tbNNG7jv6xb3ElOg-1; Fri, 17 Jan 2025 11:58:38 -0500 X-MC-Unique: x2xRa_tbNNG7jv6xb3ElOg-1 X-Mimecast-MFC-AGG-ID: x2xRa_tbNNG7jv6xb3ElOg Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43631d8d9c7so12054975e9.1 for ; Fri, 17 Jan 2025 08:58:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737133117; x=1737737917; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=3RDMY+65UFDdSOlQmyBvvEbMu1oS+daUhpKHh3ifXvQ=; b=WrntI+Rb82TZsRzuS+DIx8tuVQn/lhF6Jl3pXWeYVSXZhkJ/3zTEgpRWEhbrCwdgBq hCvNvqHcRoFU5GStgxXbFfq6fzS5op1RGBKHNWu2XiL8t2ZaOO8fOANuk+lZRSTe5NTo R/hdvwDSPp6tZmVSQF/fYaSiajftzadA1ZvsvybtArZur72jwyDLoEluQ5tK99hZM2h4 tbjzcmXNJCiJVhJQ3Px/S4wZLc3Ve6kgqq9dPkT/Aiwylg+fdkh8H+lxAsSWCk2NHGKf 3MV8z3n5C5HFfA/ez1CxMDnA8K1B8qtEbu8+C1wMa/Eor7T1JDwlQkNAwNe+7L8fxdlV sSLA== X-Forwarded-Encrypted: i=1; AJvYcCV8b0fxGsGEUnIai3eRk222HOU449oKq7CBnWspDNvLYtLuRKyJUPgFChOswasTFlcY3gNQ/LkS0Q==@kvack.org X-Gm-Message-State: AOJu0YwfkUoBEW+U0XNhp8/V5eVrgeBD1Iu+J03wdB4QZZ1UHqDOoEkt PudBJ0MUNeTrQUS7XeMZNNhSLaOGgQgYdCrHUXay7jZNJ/+uhk5H6hW0OYesfUFyEU2ktDSIZuP OlE1jepGyOnZuzMck5hqoqgax2+Tq2ve7kj/Ni/3S+e24OW2n X-Gm-Gg: ASbGncvfvEY0WUX/4jBWaaChdVwe1oZ0BRf5B90nf8WZiv4zK4qfjkftMgH9XTR53rt AaJstEx3/VjpbIAXrLXGWGlR3eQAFxg79/EkObJA6M1kY1XtjgNbchGsIkqP8+lwegeAiyOZf6R MYre1lNf6lgL1DoHXgQIx/iXBMoDvYuq0loI5EGBSio8cEITQl4efz5O5gA2wHXm6R60oMHZYz1 L43a34KZYcWjkKOdwOePopixFDyMBz0HI/Av/N6zrNSpHFm0T0FexQ= X-Received: by 2002:a05:600c:35cf:b0:434:f1bd:1e40 with SMTP id 5b1f17b1804b1-438918c6162mr28854165e9.6.1737133116874; Fri, 17 Jan 2025 08:58:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IEYIoDtomSYmqLa26VwMFEEd3Bi1NL5xFaYrY1IZ5nECd1ybECqHqqQatedShGbF3GKsjZvQw== X-Received: by 2002:a05:600c:35cf:b0:434:f1bd:1e40 with SMTP id 5b1f17b1804b1-438918c6162mr28853815e9.6.1737133116326; Fri, 17 Jan 2025 08:58:36 -0800 (PST) Received: from [10.10.13.81] ([45.156.240.116]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43890417a76sm38554555e9.16.2025.01.17.08.58.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Jan 2025 08:58:35 -0800 (PST) Message-ID: <23fa05f8-ea30-4261-91d8-b34fc678c4de@redhat.com> Date: Fri, 17 Jan 2025 17:58:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/1] KVM: arm64: Allow cacheable stage 2 mapping using VMA flags To: Jason Gunthorpe , Catalin Marinas Cc: Ankit Agrawal , "maz@kernel.org" , "oliver.upton@linux.dev" , "joey.gouly@arm.com" , "suzuki.poulose@arm.com" , "yuzenghui@huawei.com" , "will@kernel.org" , "ryan.roberts@arm.com" , "shahuang@redhat.com" , "lpieralisi@kernel.org" , Aniket Agashe , Neo Jia , Kirti Wankhede , "Tarun Gupta (SW-GPU)" , Vikram Sethi , Andy Currid , Alistair Popple , John Hubbard , Dan Williams , Zhi Wang , Matt Ochs , Uday Dhoke , Dheeraj Nigam , "alex.williamson@redhat.com" , "sebastianene@google.com" , "coltonlewis@google.com" , "kevin.tian@intel.com" , "yi.l.liu@intel.com" , "ardb@kernel.org" , "akpm@linux-foundation.org" , "gshan@redhat.com" , "linux-mm@kvack.org" , "kvmarm@lists.linux.dev" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" References: <20250106165159.GJ5556@nvidia.com> <20250113162749.GN5556@nvidia.com> <0743193c-80a0-4ef8-9cd7-cb732f3761ab@redhat.com> <20250114133145.GA5556@nvidia.com> <20250115143213.GQ5556@nvidia.com> <20250117140050.GC5556@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250117140050.GC5556@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 53exImVdwoYSkNptrFTGsO3rFwURh6p6dJkHYnPfjoY_1737133117 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 20C4B4000B X-Stat-Signature: 6rnmmqy8shdq44bdtfkci9y6pnz8a51e X-Rspam-User: X-HE-Tag: 1737133119-315852 X-HE-Meta: U2FsdGVkX18Cs3gyEYJD3h4ByNtfoDeMytajEIEiZo94aqgvDEF4AgZxJQy6o0A34aeNobRjJBawimg4Qsu4YvgDYq+iuqxTbe1IZ5DGP/bUwsSNh112CQR52nPhQJXLs9FhmasvLFi2QvU1oChJvFJiciV5p1paYgTuyXvx9ZDyypqx4GITZsh22R6H2WE54IGx7Gg8mbvfv1+wPSxDrqQfE/esqr8g6C4j7WQgCC/3Gt7OeVmkqSiIyfu2biLXuY/AlKsrRMB/ACn/3svGbPky3qDUivkKL9ffhi+1bpl1SJ8myzAJf0oHCcQnY11WjCmTlN9VQhDmLq78uvBiSQ6C+Zv6nVEiZjvPSJibu/jsvEQGTpuzj9Yv7huPHIrb04AyoUQB7T1po1Ruy+NqiIpu+7Hx7gJTULqM5LrmvuSf+iwzF7aGsNsJ07aaPr5/i32aIttmHlzbKQSr7omZtEbt2zAMC4lD01rJiCV9jA8RXVOrga906vZBCKd2TG5ansTPJV9/X+v2o4hMI7m7l1AbHCRTLgxDt2B0tVgYfP8Vkh/sla02HdxCDElOIS2Qjc2cN+9+eAGihQ6W1A0uMQYv+bZiA4+SrxDGgfCDtTW5fhWjSEnYuQr2RJIOrOsu6+rulrjUPtHLbRDkFn+HOKbgboSMwbEQ8ZejrnPd0VpqEUuiLw9b0mns3IgOFt/fiuGRvi7B46kOE3b4yLnIwnsppXBJhHODGIVwXFXNwDZlVkN1BbB9s21NllhBfMkv7N6C8AGAGjmXXaJTXAuOnoc1K/YLQhteFmyU2POZn4AN4sF4dNswCYJDqA+zUKYNEmAx6QUsWIM6xY5JKCymuXurAZbseMeVfKZbqkAFg+Kw8i9torn7hM/UwW6avADtrM7Du4qJBPl2k5dQsWI0OqKaB8BUDttJ+m7TIOPwO9ryxEzZTaoskIVnFPfiBirhCMdIWA/NBRqkhOSvqDj dDiAoCBf d8ZaREZllMqsvljn5pMdP4BeKKeIaWTr2dJS7jQS6pGjXmPDb0AOfiHVJnfTWGDGC6k/mW3cxXlKWWLRGkDLA8OPZNO2uBRvOkmgFCOHbDPdow1qEBuAgRYCl6+WZZ5L5rCy3Vb4qlF037UMr5vMhlukpdnrtVKzRNLwOTT/owqAVOlssi1Op+gi9WjYtvqnwhOM4bTg0sdyDEqP7EY2Q5+KDL6Uy9UtH7ePXOlCaq2i1J8+R2vr+OQT5IaixS6qH50bn3zB+if0xV7O+rEd3nnJEp17G/vQFgCEIg+f1duA2dSMEgW6UjA3Wnjr9pty+7WyKVtvtPSI5w/S3B9fSTrFhXBQWHkPbuqQ6gRHopklY0BI6AvpddLI2g0xySuSjTkuARzyzjMuY6664cd8XTd1Z0S83qqyzfjRbFqQ8H0g5EbSGyS0QTzIfsjVV+LgjaUZd2AS1aAIQ6UbViJtvwJj3w/G+Gsh5RAoM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >> I don't see how VM_PFNMAP alone can tell us anything about the >> access properties supported by a device address range. Either way, >> it's the driver setting vm_page_prot or some VM_* flag. KVM has no >> clue, it's just a memory slot. > > I think David's point about VM_PFNMAP was to avoid some of the > pfn_valid() logic. If we get VM_PFNMAP we just assume it is non-struct > page and follow the VMA's pgprot. Exactly what I meant. If we only expect DEVICE stuff in VM_PFNMAP, then we can limit all the weirdness (and figuring out what todo using pgprot etc) to exactly that. VM_IO without VM_PFNMAP might be interesting; not sure if we even want to support that here. -- Cheers, David / dhildenb