From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6037AC28D13 for ; Fri, 19 Aug 2022 23:58:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B50716B0073; Fri, 19 Aug 2022 19:58:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AFFBF6B0074; Fri, 19 Aug 2022 19:58:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C6BF8D0001; Fri, 19 Aug 2022 19:58:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8CCD26B0073 for ; Fri, 19 Aug 2022 19:58:32 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5C9C6AC88B for ; Fri, 19 Aug 2022 23:58:32 +0000 (UTC) X-FDA: 79818009264.30.8A86B40 Received: from mail-io1-f41.google.com (mail-io1-f41.google.com [209.85.166.41]) by imf24.hostedemail.com (Postfix) with ESMTP id 0D429180029 for ; Fri, 19 Aug 2022 23:58:31 +0000 (UTC) Received: by mail-io1-f41.google.com with SMTP id h78so4418502iof.13 for ; Fri, 19 Aug 2022 16:58:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject:from:to:cc; bh=rDwyn1S5gq2Gin6BY6HLPs0LNmV0efWzRqc/7asC50s=; b=Aqx53FzjxjyJpnn5MqTwd5ZZ4M51eJjvQiQdEQENCELxfdHkekZbjwYZKskVRyxaKy 9lu/9m+TxGhmFLB1ej7ff71j24I1hlX4ms5IuyGy4rHDfkiPxYnUZZ1OIsd4zep+3pxg vGEFtzE/UCGpGVkGsXKI5OIDQLaKgeIjNzI2U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :x-gm-message-state:from:to:cc; bh=rDwyn1S5gq2Gin6BY6HLPs0LNmV0efWzRqc/7asC50s=; b=35ITeRCsBli1w5ebr9Tu1R0AFAF0c81F3p+y/fFvgrR/qUrgnGgvCNVSMiM8nuX51S Jz76Xph7gNOwI4lT6rdGCRijSTWlThUPNS/sQSVOtb3xd8fmR/Di9wneVaBwOKCBxd+f 4DnfmiBdaZeXtOVbB9e9Y4aqdx//CRn1aU9gtojCYTxCUiAd1F1J6f5MGKBs9DNlEv3l znwI8nwqJjAgCyGDO7tz5QCVQdiriiW13Jdh7Y/WxF7gSPubyuOcUNMbrkf0hzDartap zxihQ/oAeNqzotyNvvsRTreLiEnZDhEVSnB/xkr7tNhipSnXvXVA6m9to0/SrqgAi3gY SpKQ== X-Gm-Message-State: ACgBeo370knKdXrBzP7kX7BHbfFK69kK0c2Y8GAxUfkrC0b6K6NYzm0n GLBeNLI2xwjPq3LCTVPCIaeXEg== X-Google-Smtp-Source: AA6agR6B/FI7i33mcGyyvznmIp2uha+oR/mT+5YCLx3tovXF3/1OvsY7aMDJVKFnTGj8eHp16GPriA== X-Received: by 2002:a05:6638:3a1a:b0:343:4ae3:9c0f with SMTP id cn26-20020a0566383a1a00b003434ae39c0fmr4774433jab.271.1660953511132; Fri, 19 Aug 2022 16:58:31 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id f3-20020a056638112300b003484f2ea3edsm1546644jar.153.2022.08.19.16.58.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Aug 2022 16:58:30 -0700 (PDT) Subject: Re: [PATCH v2 1/2] selftests/vm: fix inability to build any vm tests To: Axel Rasmussen , Andrew Morton , Guillaume Tucker , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , John Hubbard , Shuah Khan Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Shuah Khan References: <20220819191929.480108-1-axelrasmussen@google.com> From: Shuah Khan Message-ID: <23f51904-c6b9-2052-e90c-675a3077cad1@linuxfoundation.org> Date: Fri, 19 Aug 2022 17:58:29 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20220819191929.480108-1-axelrasmussen@google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660953512; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rDwyn1S5gq2Gin6BY6HLPs0LNmV0efWzRqc/7asC50s=; b=ApfbeUn5oB+QACRjgOeM1tD5kycXo+daq4WLzC2Hnql+eohepmz03DPMQ1dI8y4GEgRm38 Tc2sxUu6b+eziqMUiAtczzb5KzKwj+gWqLLx0+PABXF+u6jA8le2YVvguwAwZDOW/ecDLu ngT1DcZz56FGmr24LPiHhZViDUrvOrw= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=Aqx53Fzj; spf=pass (imf24.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.41 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660953512; a=rsa-sha256; cv=none; b=zuJXBgTUmxx3WVrWq6aOpxjUOF4TZofOKiJNz3+flrUzG0LJigpg30WCwe346qyfObA5K9 NFIYlG/xH8BfQDwGmFe+ai1eFMZBi9fA/jAiyYFFJDRkNGkVy+Q2RNOJONDyE4x0Ua66nr PshxppbFax0UgkhoS5h1g+sCWaKKltA= X-Stat-Signature: bnqbdgtqo8scj1koyi336n9fkx37yeft X-Rspam-User: Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=Aqx53Fzj; spf=pass (imf24.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.41 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 0D429180029 X-HE-Tag: 1660953511-437277 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/19/22 1:19 PM, Axel Rasmussen wrote: > When we stopped using KSFT_KHDR_INSTALL, a side effect is we also > changed the value of `top_srcdir`. This can be seen by looking at the > code removed by commit 49de12ba06ef > ("selftests: drop KSFT_KHDR_INSTALL make target"). > > (Note though that this commit didn't break this, technically the one > before it did since that's the one that stopped KSFT_KHDR_INSTALL from > being used, even though the code was still there.) > > Previously lib.mk reconfigured `top_srcdir` when KSFT_KHDR_INSTALL was > being used. Now, that's no longer the case. > > As a result, the path to gup_test.h in vm/Makefile was wrong, and > since it's a dependency of all of the vm binaries none of them could > be built. Instead, we'd get an "error" like: > > make[1]: *** No rule to make target > '/[...]/tools/testing/selftests/vm/compaction_test', needed by > 'all'. Stop. > > So, modify lib.mk so it once again sets top_srcdir to the root of the > kernel tree. > > Fixes: f2745dc0ba3d ("selftests: stop using KSFT_KHDR_INSTALL") > Signed-off-by: Axel Rasmussen > --- > tools/testing/selftests/lib.mk | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk > index 947fc72413e9..d44c72b3abe3 100644 > --- a/tools/testing/selftests/lib.mk > +++ b/tools/testing/selftests/lib.mk > @@ -40,6 +40,7 @@ ifeq (0,$(MAKELEVEL)) > endif > endif > selfdir = $(realpath $(dir $(filter %/lib.mk,$(MAKEFILE_LIST)))) > +top_srcdir = $(selfdir)/../../.. > > # The following are built by lib.mk common compile rules. > # TEST_CUSTOM_PROGS should be used by tests that require > Applied to linux-kselftest fixes for the next rc. thanks, -- Shuah