From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E73A6EB64D7 for ; Wed, 21 Jun 2023 14:32:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 897B48D0005; Wed, 21 Jun 2023 10:32:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 86F6F8D0002; Wed, 21 Jun 2023 10:32:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 736158D0005; Wed, 21 Jun 2023 10:32:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 637B98D0002 for ; Wed, 21 Jun 2023 10:32:08 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 17AA980926 for ; Wed, 21 Jun 2023 14:32:08 +0000 (UTC) X-FDA: 80926994736.04.7F22C0F Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by imf30.hostedemail.com (Postfix) with ESMTP id D2AB68001C for ; Wed, 21 Jun 2023 14:31:37 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=O1Rypcsm; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf30.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.20 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687357898; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=okNkA1xadDXsYsHvobISzAxdVIjZ3pdwZ4KLfJHOxkQ=; b=Q2LhWcd05+1XkNTZD3Njm7uhUGBOdygrnbiTwSiL1Gl8RKHdwearYth5IY5/Ekfb8qxC2k B48ypjnnROiLVW/AXUshQTx8Ed7oHsjxBu16Fv2W/7ce2025kTXCLuE9WVGaRS+RNoDIgb LdKFe+JfrNKiTdjLHNhjG/b0rlHl6TE= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=O1Rypcsm; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf30.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.20 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687357898; a=rsa-sha256; cv=none; b=NNtum2XiGvhMza3ufL/G2GAomtlIU7tMHo6EoOcaJz5J+ocEMn8HbtuITd8paDKTuuyTvv wSuABzC0K1G+VT9qf6UreW3xIS7pqxQlNz/Q0LizvP0rWuLwEehz+tMH/rbx7ZMVZeNUh1 3b1TK7NCNOm9EGlXS63S/7iFaZUuk9I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687357897; x=1718893897; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=O64wJ4h2FjMBRHsbamypZL1GWJNUE5Ay/zmz6Kb6Fbw=; b=O1RypcsmWmm1h4br+qlF9DNDEa/YEuMy+IOWATyqT0jZOmYLKXnE/tg1 yyQYFRfnYrZbewhF5wBj3KZlQr3/rsnEwM4c8Pn9oY1/ObdDFzuc+YncN iD6Kb3p1CYtOLt4ei63+3ACCsH8sTWvR+2b6r5sNaijhiSgJaRaPFieU/ qhLRn/yh283UR8ikb8juDHL23x666LnVnlXRNXtt9wGTpa1lERWf/Rxsn 8NeTfK8JElWRqhHnRYYB4qhlkehA60Uijd79grnnxEz0jXU+eEAo5nysn EgN3pK0QH/79wsj/4zpPNwDCpKnF5HPYg4d8Vor64gvGYBtpRjWbzElzn Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10748"; a="349921495" X-IronPort-AV: E=Sophos;i="6.00,260,1681196400"; d="scan'208";a="349921495" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2023 07:31:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10748"; a="714507270" X-IronPort-AV: E=Sophos;i="6.00,260,1681196400"; d="scan'208";a="714507270" Received: from rmathew-mobl2.amr.corp.intel.com (HELO [10.212.134.235]) ([10.212.134.235]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2023 07:31:34 -0700 Message-ID: <23f400bc-9a62-be4a-6a24-0e2149d4491c@intel.com> Date: Wed, 21 Jun 2023 07:31:34 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH RFC v9 07/51] x86/sev: Add the host SEV-SNP initialization support Content-Language: en-US To: Borislav Petkov Cc: Michael Roth , kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, dgilbert@redhat.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, liam.merwick@oracle.com, zhi.a.wang@intel.com, Brijesh Singh References: <20230612042559.375660-1-michael.roth@amd.com> <20230612042559.375660-8-michael.roth@amd.com> <12f95b38-427c-6810-373a-ba2062c43882@intel.com> <20230621091541.GEZJK/veTnfhOnX8ci@fat_crate.local> From: Dave Hansen In-Reply-To: <20230621091541.GEZJK/veTnfhOnX8ci@fat_crate.local> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: D2AB68001C X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 5cfhrijkw66meoex59foz56bh7zenue6 X-HE-Tag: 1687357897-305449 X-HE-Meta: U2FsdGVkX1+etU6t+h49h4bbh10PKp1uCSJb0G+ttrLjZFXTuSuL9TmjZYpVRUPz+tIppCKyFxT8WT3S3DOkmXnjP8Tp/kc/lveqiyIlMggBe2ZEndL8IYcsTeIGgRhImvEmqFtrCQ9T29A4aHiYTvY/ht1WyePjCSoBCd/Ea6eNeCI/fxxJxx1iihz8ELkFmRe3zbO6M7HepOu7yKBJCmmpp1CgNFCB0HYJHubYCMX9Nhgmmq/NYBwYKR7OhCUuwXi479PR/mdK27gtUK2V+J1fqeqiBVRSk1YdeDjTgje8pwiFxk8pSFNljsNo46BjG12+OHpNGvoQXdiqgUco15M/ke3xLODtwaU1Y6zNs8byzH/Y7AOGqNB7/3qPpgP2uWoVDSd9ILHxuthW4GFmvJPtmcUaPzuTzsAMljr9mHbVjFIV72lPMPxI3AoNjpsEEoP6z+gkkEfvI3Xvix6/Zl6QhBeK6GtB8bCyzwVLq4BfRDdT7KswZfQOLdKxIwakSkcO0a/T3W5npyoxiDR9dkEOSrfxjYZprCy0NNYvAJrTZJGQGRjL5dCwSJ27YC/JR2Y8btg0+8dqSV5Wa5iFOgB2tlIMSBdMRmXh09iBpFFw2W5BJJupAEW6z+yGBRe8tvO6cOhIG21SfwgZq6QwNYQxkHE2QdlKWIIAfk5xbuZqlGLTRzJAVWOyUhi0dIACsThJiTK5Sn2MnEmEnghQPCwm1/7wiZF6pXAFb85jCjHpHmT5hCQuyJKlQFNRu9Q60TBDtu9zm27BZX6jit8P0j9qOBwXzoGhkj6yXyNOnkfTzKjBx+qB0BWyHy6fU8D5PewYStOKGvwgQxD1AA3PoqzxANghxnMxIZomHQcbH0TGsPPyKIN5cjUVgfMsgVcXPyM0afo/1uKIPxH+BKsYpVh/EigkLXlMzbglv5o/suYjiSaNofWMVoRwzgBsiGZYZUVEaiuh2Q6E0SRdaeO FkRcYt93 E4obg3ViXYafO+PLTujWAcCDlqXlkNBUQn8E65sirnkNaQ3aiLCcA0DPdYh9d1fk4e+K6remHRwFesmVH+FiHwUXdWSUXzsWRxLjgsc85vJrQTRef6DwUvRpVcIhr97DTPwEK5t7bmV2VMNaWtoTzqpb4lw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/21/23 02:15, Borislav Petkov wrote: > On Mon, Jun 12, 2023 at 08:34:02AM -0700, Dave Hansen wrote: >> On 6/11/23 21:25, Michael Roth wrote: >>> + /* >>> + * Calculate the amount the memory that must be reserved by the BIOS to >>> + * address the whole RAM, including the bookkeeping area. The RMP itself >>> + * must also be covered. >>> + */ >>> + max_rmp_pfn = max_pfn; >>> + if (PHYS_PFN(rmp_end) > max_pfn) >>> + max_rmp_pfn = PHYS_PFN(rmp_end); >> Could you say a little here about how this deals with memory hotplug? > Does SNP hw even support memory hotplug? > > I think in order to support that, you'd need some special dance because > of the RMP table etc... Yep, there's the hardware side and then there are fun nuggets like using mem= and then doing a software-only hot-add later after boot. Also, if the hardware doesn't support any kind of hotplug, it would be great to point to the place in the spec where it says that.