From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 215A3C04AB5 for ; Mon, 3 Jun 2019 18:38:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BCC0026A54 for ; Mon, 3 Jun 2019 18:38:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BCC0026A54 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 44A1D6B026B; Mon, 3 Jun 2019 14:38:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D34D6B026C; Mon, 3 Jun 2019 14:38:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 24CA66B026E; Mon, 3 Jun 2019 14:38:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-oi1-f198.google.com (mail-oi1-f198.google.com [209.85.167.198]) by kanga.kvack.org (Postfix) with ESMTP id E272C6B026B for ; Mon, 3 Jun 2019 14:38:08 -0400 (EDT) Received: by mail-oi1-f198.google.com with SMTP id w5so5546768oig.18 for ; Mon, 03 Jun 2019 11:38:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:subject:to:cc :references:from:openpgp:autocrypt:organization:message-id:date :user-agent:mime-version:in-reply-to; bh=fAARWzc8mzBk3DX6jJGiHREgdP4DZhOZ+37b+5YORC0=; b=lO9cWh/qTg2h/FKTKFpPVlZMnOR6NUGukenak9b6YiXtPY9gFUu9lQl2XB5R2VoYpY 4iklDp2E3fxRy7jB99uxNqQrnR0aWP5pOR78x8CqHtlUmvgbrg6DpMEVkfhbJuu2xCa4 o1+HTsnL4sRMuJCdojU+5FWBSoLe1t87TvTbnVez36h85mrR3ZlJaV+2bkuAEqKS8IKp lIKorFfZoW7pVYx+WW0TaK0KNz8amyKBc0ORJL0vGgbhGkziMWETgdZVhVXVn9f6wUyQ CLFEK8e1AqRhn5HTkGKKqXJHhHgNn6qATDP/s59XIPz3RJ2vQKDewxIpFkoPBSenTd7R 8qSQ== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of nitesh@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=nitesh@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com X-Gm-Message-State: APjAAAWxIs9cRkr9WZeg75PqPAcDszL1GpLlr0SrrpWXVuKrWtZtxMOk FqGg5QI9pabbCwVBhqmAWyjL7N4rAU6oYFRJg3qodY3+xRxW4wHmG56nt9HzTymfWxxiLgHg9um tREvxtT7bVdQptxq2P2C6UupaVJDGu/+xiSupCPJyt7Ls7B8rPqYQ487pjG7fabPz9A== X-Received: by 2002:aca:4708:: with SMTP id u8mr1905328oia.166.1559587088544; Mon, 03 Jun 2019 11:38:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqywD4jSZ8vPWDHOSWaXuhr6VVaCxxOEYUNaoos/zypTUDxKcquuFxLAZCetfA4U+F1WnQ0z X-Received: by 2002:aca:4708:: with SMTP id u8mr1905287oia.166.1559587087557; Mon, 03 Jun 2019 11:38:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559587087; cv=none; d=google.com; s=arc-20160816; b=DnKYm3wdgckUhrO0hrmGXVEayYiTa07Ee5QITILFDMmqmqcNJiVHnBpbtLoWrK4S+r nca9AckHzF2zo3BFT0ZINl6opOqQvXwu5m7IJIS4L+R82NQGVdn0u+GQ5dL5rovICGjl SavNdG7O+4z+WkoKU5DWXFcyW251bAQ3hIthxV8VxoHP56RYOSEY7equiQSs4XWChqiH 1fhLVX/J5/QUPJKIkfUIQlql+6ZWgSkUdvsSwwn7pSnTS23BRzmR3Hp1Q4x5C5uKyMLr ptb2XoznvUfZUZSsZCGyWtpbxmYGast/hS5wA2JL2UKnUu52gWN+djIOeoSMXM6F4Yjo Zc6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:mime-version:user-agent:date:message-id:organization :autocrypt:openpgp:from:references:cc:to:subject; bh=fAARWzc8mzBk3DX6jJGiHREgdP4DZhOZ+37b+5YORC0=; b=nhFdQpBGgt4/RXt7A2tqrgGo0tTzSlrSvRtZlVpT1Pm/DNhFXKY2COzesAgZa/9JPT +wE2H5z3yT4ZIDF+hWprO5Yxa3PVwKh1+rpDky0L25jMaJZ1WnjuXZVnmB+oGjkeZ+cq PIzF5YzK5hQtj/Yo+b1aXJJVz/G/OvpP5xmrRKmeGhUzaRUcYCHClYwaSpcd2k5uMSR0 jhhb/CAEQUfOVq5joSbLVTUjhYiDHamw4p2XHy3jiISxZdChteybSFby1f8e0m4x+9lX NM3Ng8NDwOh0Eo3aj2DGx/fUtDzAObGdHwc4/k2mtk2SFMszDm4sZs9XP179RkaH5iGV G4gA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of nitesh@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=nitesh@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id m15si7134915otq.213.2019.06.03.11.38.07 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Jun 2019 11:38:07 -0700 (PDT) Received-SPF: pass (google.com: domain of nitesh@redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; Authentication-Results: mx.google.com; spf=pass (google.com: domain of nitesh@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=nitesh@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CEADD308794D; Mon, 3 Jun 2019 18:37:56 +0000 (UTC) Received: from [10.40.205.157] (unknown [10.40.205.157]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2FF4A60BFB; Mon, 3 Jun 2019 18:37:20 +0000 (UTC) Subject: Re: [QEMU PATCH] KVM: Support for page hinting To: Alexander Duyck Cc: kvm list , LKML , linux-mm , Paolo Bonzini , lcapitulino@redhat.com, pagupta@redhat.com, wei.w.wang@intel.com, Yang Zhang , Rik van Riel , David Hildenbrand , "Michael S. Tsirkin" , dodgen@google.com, Konrad Rzeszutek Wilk , dhildenb@redhat.com, Andrea Arcangeli References: <20190603170306.49099-1-nitesh@redhat.com> <20190603170432.1195-1-nitesh@redhat.com> From: Nitesh Narayan Lal Openpgp: preference=signencrypt Autocrypt: addr=nitesh@redhat.com; prefer-encrypt=mutual; keydata= mQINBFl4pQoBEADT/nXR2JOfsCjDgYmE2qonSGjkM1g8S6p9UWD+bf7YEAYYYzZsLtbilFTe z4nL4AV6VJmC7dBIlTi3Mj2eymD/2dkKP6UXlliWkq67feVg1KG+4UIp89lFW7v5Y8Muw3Fm uQbFvxyhN8n3tmhRe+ScWsndSBDxYOZgkbCSIfNPdZrHcnOLfA7xMJZeRCjqUpwhIjxQdFA7 n0s0KZ2cHIsemtBM8b2WXSQG9CjqAJHVkDhrBWKThDRF7k80oiJdEQlTEiVhaEDURXq+2XmG jpCnvRQDb28EJSsQlNEAzwzHMeplddfB0vCg9fRk/kOBMDBtGsTvNT9OYUZD+7jaf0gvBvBB lbKmmMMX7uJB+ejY7bnw6ePNrVPErWyfHzR5WYrIFUtgoR3LigKnw5apzc7UIV9G8uiIcZEn C+QJCK43jgnkPcSmwVPztcrkbC84g1K5v2Dxh9amXKLBA1/i+CAY8JWMTepsFohIFMXNLj+B RJoOcR4HGYXZ6CAJa3Glu3mCmYqHTOKwezJTAvmsCLd3W7WxOGF8BbBjVaPjcZfavOvkin0u DaFvhAmrzN6lL0msY17JCZo046z8oAqkyvEflFbC0S1R/POzehKrzQ1RFRD3/YzzlhmIowkM BpTqNBeHEzQAlIhQuyu1ugmQtfsYYq6FPmWMRfFPes/4JUU/PQARAQABtCVOaXRlc2ggTmFy YXlhbiBMYWwgPG5pbGFsQHJlZGhhdC5jb20+iQI9BBMBCAAnBQJZeKUKAhsjBQkJZgGABQsJ CAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEKOGQNwGMqM56lEP/A2KMs/pu0URcVk/kqVwcBhU SnvB8DP3lDWDnmVrAkFEOnPX7GTbactQ41wF/xwjwmEmTzLrMRZpkqz2y9mV0hWHjqoXbOCS 6RwK3ri5e2ThIPoGxFLt6TrMHgCRwm8YuOSJ97o+uohCTN8pmQ86KMUrDNwMqRkeTRW9wWIQ EdDqW44VwelnyPwcmWHBNNb1Kd8j3xKlHtnS45vc6WuoKxYRBTQOwI/5uFpDZtZ1a5kq9Ak/ MOPDDZpd84rqd+IvgMw5z4a5QlkvOTpScD21G3gjmtTEtyfahltyDK/5i8IaQC3YiXJCrqxE r7/4JMZeOYiKpE9iZMtS90t4wBgbVTqAGH1nE/ifZVAUcCtycD0f3egX9CHe45Ad4fsF3edQ ESa5tZAogiA4Hc/yQpnnf43a3aQ67XPOJXxS0Qptzu4vfF9h7kTKYWSrVesOU3QKYbjEAf95 NewF9FhAlYqYrwIwnuAZ8TdXVDYt7Z3z506//sf6zoRwYIDA8RDqFGRuPMXUsoUnf/KKPrtR ceLcSUP/JCNiYbf1/QtW8S6Ca/4qJFXQHp0knqJPGmwuFHsarSdpvZQ9qpxD3FnuPyo64S2N Dfq8TAeifNp2pAmPY2PAHQ3nOmKgMG8Gn5QiORvMUGzSz8Lo31LW58NdBKbh6bci5+t/HE0H pnyVf5xhNC/FuQINBFl4pQoBEACr+MgxWHUP76oNNYjRiNDhaIVtnPRqxiZ9v4H5FPxJy9UD Bqr54rifr1E+K+yYNPt/Po43vVL2cAyfyI/LVLlhiY4yH6T1n+Di/hSkkviCaf13gczuvgz4 KVYLwojU8+naJUsiCJw01MjO3pg9GQ+47HgsnRjCdNmmHiUQqksMIfd8k3reO9SUNlEmDDNB XuSzkHjE5y/R/6p8uXaVpiKPfHoULjNRWaFc3d2JGmxJpBdpYnajoz61m7XJlgwl/B5Ql/6B dHGaX3VHxOZsfRfugwYF9CkrPbyO5PK7yJ5vaiWre7aQ9bmCtXAomvF1q3/qRwZp77k6i9R3 tWfXjZDOQokw0u6d6DYJ0Vkfcwheg2i/Mf/epQl7Pf846G3PgSnyVK6cRwerBl5a68w7xqVU 4KgAh0DePjtDcbcXsKRT9D63cfyfrNE+ea4i0SVik6+N4nAj1HbzWHTk2KIxTsJXypibOKFX 2VykltxutR1sUfZBYMkfU4PogE7NjVEU7KtuCOSAkYzIWrZNEQrxYkxHLJsWruhSYNRsqVBy KvY6JAsq/i5yhVd5JKKU8wIOgSwC9P6mXYRgwPyfg15GZpnw+Fpey4bCDkT5fMOaCcS+vSU1 UaFmC4Ogzpe2BW2DOaPU5Ik99zUFNn6cRmOOXArrryjFlLT5oSOe4IposgWzdwARAQABiQIl BBgBCAAPBQJZeKUKAhsMBQkJZgGAAAoJEKOGQNwGMqM5ELoP/jj9d9gF1Al4+9bngUlYohYu 0sxyZo9IZ7Yb7cHuJzOMqfgoP4tydP4QCuyd9Q2OHHL5AL4VFNb8SvqAxxYSPuDJTI3JZwI7 d8JTPKwpulMSUaJE8ZH9n8A/+sdC3CAD4QafVBcCcbFe1jifHmQRdDrvHV9Es14QVAOTZhnJ vweENyHEIxkpLsyUUDuVypIo6y/Cws+EBCWt27BJi9GH/EOTB0wb+2ghCs/i3h8a+bi+bS7L FCCm/AxIqxRurh2UySn0P/2+2eZvneJ1/uTgfxnjeSlwQJ1BWzMAdAHQO1/lnbyZgEZEtUZJ x9d9ASekTtJjBMKJXAw7GbB2dAA/QmbA+Q+Xuamzm/1imigz6L6sOt2n/X/SSc33w8RJUyor SvAIoG/zU2Y76pKTgbpQqMDmkmNYFMLcAukpvC4ki3Sf086TdMgkjqtnpTkEElMSFJC8npXv 3QnGGOIfFug/qs8z03DLPBz9VYS26jiiN7QIJVpeeEdN/LKnaz5LO+h5kNAyj44qdF2T2AiF HxnZnxO5JNP5uISQH3FjxxGxJkdJ8jKzZV7aT37sC+Rp0o3KNc+GXTR+GSVq87Xfuhx0LRST NK9ZhT0+qkiN7npFLtNtbzwqaqceq3XhafmCiw8xrtzCnlB/C4SiBr/93Ip4kihXJ0EuHSLn VujM7c/b4pps Organization: Red Hat Inc, Message-ID: <23dd50ab-be28-8275-c22d-fed28b71e81c@redhat.com> Date: Mon, 3 Jun 2019 14:37:17 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="MjcLktThbye9adVKcn4wvy9DEXe7JShNr" X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Mon, 03 Jun 2019 18:38:06 +0000 (UTC) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --MjcLktThbye9adVKcn4wvy9DEXe7JShNr Content-Type: multipart/mixed; boundary="sDwkWg2EGTObLlfNhJ6WvksPoVWdNMirB"; protected-headers="v1" From: Nitesh Narayan Lal To: Alexander Duyck Cc: kvm list , LKML , linux-mm , Paolo Bonzini , lcapitulino@redhat.com, pagupta@redhat.com, wei.w.wang@intel.com, Yang Zhang , Rik van Riel , David Hildenbrand , "Michael S. Tsirkin" , dodgen@google.com, Konrad Rzeszutek Wilk , dhildenb@redhat.com, Andrea Arcangeli Message-ID: <23dd50ab-be28-8275-c22d-fed28b71e81c@redhat.com> Subject: Re: [QEMU PATCH] KVM: Support for page hinting References: <20190603170306.49099-1-nitesh@redhat.com> <20190603170432.1195-1-nitesh@redhat.com> In-Reply-To: --sDwkWg2EGTObLlfNhJ6WvksPoVWdNMirB Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-US On 6/3/19 2:34 PM, Alexander Duyck wrote: > On Mon, Jun 3, 2019 at 10:04 AM Nitesh Narayan Lal = wrote: >> Enables QEMU to call madvise on the pages which are reported >> by the guest kernel. >> >> Signed-off-by: Nitesh Narayan Lal > What commit-id is this meant to apply on top of? I can't apply this to > the latest development version of QEMU. I am not at the latest commit with this. My top of the commit is: f3b4d5ca67f2e933c93457b701883c307b99c15c > >> --- >> hw/virtio/trace-events | 1 + >> hw/virtio/virtio-balloon.c | 85 ++++++++++++++++++= + >> include/hw/virtio/virtio-balloon.h | 2 +- >> include/qemu/osdep.h | 7 ++ >> .../standard-headers/linux/virtio_balloon.h | 1 + >> 5 files changed, 95 insertions(+), 1 deletion(-) >> >> diff --git a/hw/virtio/trace-events b/hw/virtio/trace-events >> index 07bcbe9e85..015565785c 100644 >> --- a/hw/virtio/trace-events >> +++ b/hw/virtio/trace-events >> @@ -46,3 +46,4 @@ virtio_balloon_handle_output(const char *name, uint6= 4_t gpa) "section name: %s g >> virtio_balloon_get_config(uint32_t num_pages, uint32_t actual) "num_p= ages: %d actual: %d" >> virtio_balloon_set_config(uint32_t actual, uint32_t oldactual) "actua= l: %d oldactual: %d" >> virtio_balloon_to_target(uint64_t target, uint32_t num_pages) "balloo= n target: 0x%"PRIx64" num_pages: %d" >> +virtio_balloon_hinting_request(unsigned long pfn, unsigned int num_pa= ges) "Guest page hinting request: %lu size: %d" >> diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c >> index a12677d4d5..cbb630279c 100644 >> --- a/hw/virtio/virtio-balloon.c >> +++ b/hw/virtio/virtio-balloon.c >> @@ -33,6 +33,13 @@ >> >> #define BALLOON_PAGE_SIZE (1 << VIRTIO_BALLOON_PFN_SHIFT) >> >> +struct guest_pages { >> + uint64_t phys_addr; >> + uint32_t len; >> +}; >> + > Any reason for matching up 64b addr w/ 32b size? The way I see it you > would be be better off going with either 64b for both or 32b for both. > I opted for the 32b approach in my case since there was already code > in place for doing the PFN shift anyway in the standard virtio_balloon > code path. > >> +void page_hinting_request(uint64_t addr, uint32_t len); >> + >> static void balloon_page(void *addr, int deflate) >> { >> if (!qemu_balloon_is_inhibited()) { >> @@ -207,6 +214,80 @@ static void balloon_stats_set_poll_interval(Objec= t *obj, Visitor *v, >> balloon_stats_change_timer(s, 0); >> } >> >> +static void *gpa2hva(MemoryRegion **p_mr, hwaddr addr, Error **errp) >> +{ >> + MemoryRegionSection mrs =3D memory_region_find(get_system_memory(= ), >> + addr, 1); >> + >> + if (!mrs.mr) { >> + error_setg(errp, "No memory is mapped at address 0x%" HWADDR_= PRIx, addr); >> + return NULL; >> + } >> + >> + if (!memory_region_is_ram(mrs.mr) && !memory_region_is_romd(mrs.m= r)) { >> + error_setg(errp, "Memory at address 0x%" HWADDR_PRIx "is not = RAM", addr); >> + memory_region_unref(mrs.mr); >> + return NULL; >> + } >> + >> + *p_mr =3D mrs.mr; >> + return qemu_map_ram_ptr(mrs.mr->ram_block, mrs.offset_within_regi= on); >> +} >> + >> +void page_hinting_request(uint64_t addr, uint32_t len) >> +{ >> + Error *local_err =3D NULL; >> + MemoryRegion *mr =3D NULL; >> + int ret =3D 0; >> + struct guest_pages *guest_obj; >> + int i =3D 0; >> + void *hvaddr_to_free; >> + uint64_t gpaddr_to_free; >> + void * temp_addr =3D gpa2hva(&mr, addr, &local_err); >> + >> + if (local_err) { >> + error_report_err(local_err); >> + return; >> + } >> + guest_obj =3D temp_addr; >> + while (i < len) { >> + gpaddr_to_free =3D guest_obj[i].phys_addr; >> + trace_virtio_balloon_hinting_request(gpaddr_to_free,guest_obj[= i].len); >> + hvaddr_to_free =3D gpa2hva(&mr, gpaddr_to_free, &local_err); >> + if (local_err) { >> + error_report_err(local_err); >> + return; >> + } >> + ret =3D qemu_madvise((void *)hvaddr_to_free, guest_obj[i].len,= QEMU_MADV_FREE); >> + if (ret =3D=3D -1) >> + printf("\n%d:%s Error: Madvise failed with error:%d\n", __= LINE__, __func__, ret); >> + i++; >> + } >> +} >> + > Have we made any determination yet on the MADV_FREE vs MADV_DONT_NEED? > My preference would be to have this code just reuse the existing > balloon code as I did in my patch set. Then we can avoid the need to > have multiple types in use. We could just have the balloon use the > same as the hint. > >> +static void virtio_balloon_page_hinting(VirtIODevice *vdev, VirtQueue= *vq) >> +{ >> + VirtQueueElement *elem =3D NULL; >> + uint64_t temp_addr; >> + uint32_t temp_len; >> + size_t size, t_size =3D 0; >> + >> + elem =3D virtqueue_pop(vq, sizeof(VirtQueueElement)); >> + if (!elem) { >> + printf("\npop error\n"); >> + return; >> + } >> + size =3D iov_to_buf(elem->out_sg, elem->out_num, 0, &temp_addr, s= izeof(temp_addr)); >> + t_size +=3D size; >> + size =3D iov_to_buf(elem->out_sg, elem->out_num, 8, &temp_len, si= zeof(temp_len)); >> + t_size +=3D size; >> + if (!qemu_balloon_is_inhibited()) >> + page_hinting_request(temp_addr, temp_len); >> + virtqueue_push(vq, elem, t_size); >> + virtio_notify(vdev, vq); >> + g_free(elem); >> +} >> + > If you are doing a u64 addr, and a u32 len, does that mean you are > having to use a packed array between the guest and the host? This > would be another good reason to have both settle on either u64 or u32. > >> static void virtio_balloon_handle_output(VirtIODevice *vdev, VirtQueu= e *vq) >> { >> VirtIOBalloon *s =3D VIRTIO_BALLOON(vdev); >> @@ -376,6 +457,7 @@ static uint64_t virtio_balloon_get_features(VirtIO= Device *vdev, uint64_t f, >> VirtIOBalloon *dev =3D VIRTIO_BALLOON(vdev); >> f |=3D dev->host_features; >> virtio_add_feature(&f, VIRTIO_BALLOON_F_STATS_VQ); >> + virtio_add_feature(&f, VIRTIO_BALLOON_F_HINTING); >> return f; >> } >> >> @@ -445,6 +527,7 @@ static void virtio_balloon_device_realize(DeviceSt= ate *dev, Error **errp) >> s->ivq =3D virtio_add_queue(vdev, 128, virtio_balloon_handle_outp= ut); >> s->dvq =3D virtio_add_queue(vdev, 128, virtio_balloon_handle_outp= ut); >> s->svq =3D virtio_add_queue(vdev, 128, virtio_balloon_receive_sta= ts); >> + s->hvq =3D virtio_add_queue(vdev, 128, virtio_balloon_page_hintin= g); >> >> reset_stats(s); >> } >> @@ -488,6 +571,8 @@ static void virtio_balloon_instance_init(Object *o= bj) >> >> object_property_add(obj, "guest-stats", "guest statistics", >> balloon_stats_get_all, NULL, NULL, s, NULL); >> + object_property_add(obj, "guest-page-hinting", "guest page hintin= g", >> + NULL, NULL, NULL, s, NULL); >> >> object_property_add(obj, "guest-stats-polling-interval", "int", >> balloon_stats_get_poll_interval, >> diff --git a/include/hw/virtio/virtio-balloon.h b/include/hw/virtio/vi= rtio-balloon.h >> index e0df3528c8..774498a6ca 100644 >> --- a/include/hw/virtio/virtio-balloon.h >> +++ b/include/hw/virtio/virtio-balloon.h >> @@ -32,7 +32,7 @@ typedef struct virtio_balloon_stat_modern { >> >> typedef struct VirtIOBalloon { >> VirtIODevice parent_obj; >> - VirtQueue *ivq, *dvq, *svq; >> + VirtQueue *ivq, *dvq, *svq, *hvq; >> uint32_t num_pages; >> uint32_t actual; >> uint64_t stats[VIRTIO_BALLOON_S_NR]; >> diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h >> index 840af09cb0..4d632933a9 100644 >> --- a/include/qemu/osdep.h >> +++ b/include/qemu/osdep.h >> @@ -360,6 +360,11 @@ void qemu_anon_ram_free(void *ptr, size_t size); >> #else >> #define QEMU_MADV_REMOVE QEMU_MADV_INVALID >> #endif >> +#ifdef MADV_FREE >> +#define QEMU_MADV_FREE MADV_FREE >> +#else >> +#define QEMU_MADV_FREE QEMU_MADV_INVALID >> +#endif >> >> #elif defined(CONFIG_POSIX_MADVISE) >> >> @@ -373,6 +378,7 @@ void qemu_anon_ram_free(void *ptr, size_t size); >> #define QEMU_MADV_HUGEPAGE QEMU_MADV_INVALID >> #define QEMU_MADV_NOHUGEPAGE QEMU_MADV_INVALID >> #define QEMU_MADV_REMOVE QEMU_MADV_INVALID >> +#define QEMU_MADV_FREE QEMU_MADV_INVALID >> >> #else /* no-op */ >> >> @@ -386,6 +392,7 @@ void qemu_anon_ram_free(void *ptr, size_t size); >> #define QEMU_MADV_HUGEPAGE QEMU_MADV_INVALID >> #define QEMU_MADV_NOHUGEPAGE QEMU_MADV_INVALID >> #define QEMU_MADV_REMOVE QEMU_MADV_INVALID >> +#define QEMU_MADV_FREE QEMU_MADV_INVALID >> >> #endif >> >> diff --git a/include/standard-headers/linux/virtio_balloon.h b/include= /standard-headers/linux/virtio_balloon.h >> index 4dbb7dc6c0..f50c0d95ea 100644 >> --- a/include/standard-headers/linux/virtio_balloon.h >> +++ b/include/standard-headers/linux/virtio_balloon.h >> @@ -34,6 +34,7 @@ >> #define VIRTIO_BALLOON_F_MUST_TELL_HOST 0 /* Tell before recla= iming pages */ >> #define VIRTIO_BALLOON_F_STATS_VQ 1 /* Memory Stats virtqueue */= >> #define VIRTIO_BALLOON_F_DEFLATE_ON_OOM 2 /* Deflate balloon o= n OOM */ >> +#define VIRTIO_BALLOON_F_HINTING 5 /* Page hinting virtqueue */= > So this is obviously built against an old version of QEMU, the latest > values for this include: > #define VIRTIO_BALLOON_F_FREE_PAGE_HINT 3 /* VQ to report free pages */= > #define VIRTIO_BALLOON_F_PAGE_POISON 4 /* Guest is using page poison= ing */ > > I wonder if we shouldn't look for a term other than "HINT" since there > is already the code around providing hints to migration. --=20 Regards Nitesh --sDwkWg2EGTObLlfNhJ6WvksPoVWdNMirB-- --MjcLktThbye9adVKcn4wvy9DEXe7JShNr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkXcoRVGaqvbHPuAGo4ZA3AYyozkFAlz1aN0ACgkQo4ZA3AYy ozlpOBAAz4eUjOEuN8jIYI09rtC7PFA8/gWdY5N/nvXlmSOwk3pL8UQQSoLBvkFT nlnQSx9h5KmlJxqPUUAj5bY15NaPcaRLWB6EszYgILgR0KGvdYNfbFh3cQyfHGji SfCKsAc6fKHkULXSnJ9f7tdktbhvDNG4xWMPqz9pgVdcSYV3hRTn3+hIkhoO7toj X7C6t8J1IJ2F606wjm+yhwkWFr0TgVFJ5eaelV+wLorPMXno3WGFFL138G5odaB1 zWzMiy7tlZgn6CGrspfRZFmYaTYR84RE3PzuLJNtZU+hgFdIwcJFbJ8qSUhazgTP yBw1ue0p06SbKHEzPtyg+eOwB67KHv5PwTafvC1M4fV45Pc6o0ifO0p0lcGyhV3w dyLydmVtujJv3zuBzB534yxEwu9M1iVi9kQVZe278ONZlX1VPFmKWTsKNATgB5Zo 9Bzqofn9YcUyGLJqlC09Zg1Yl7AnBuHWVbZVlQgeidDoEjgqbgEyx8fspod4KtwR tXobWD9YfaxAPvGwlJv2h67MoEtT0gy6+6PPYo41NGC6UBUy2wO1CoIr2hzXlq3T sBHTTDXgXhheYyRf+bOZ+Y6JcWDI1Vrp5rGJlxfbaLEbg6OzEh9V1ma0ltGutKxO gPX8YmPiw8IBGk5tVFxndVNGWY1V5InoNmFbEHGi5BrGUHphAtk= =Tm/s -----END PGP SIGNATURE----- --MjcLktThbye9adVKcn4wvy9DEXe7JShNr--