From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9E8AC4707C for ; Wed, 10 Jan 2024 16:16:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 66CA76B00A5; Wed, 10 Jan 2024 11:16:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F5516B00A6; Wed, 10 Jan 2024 11:16:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 420896B00A7; Wed, 10 Jan 2024 11:16:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2D61C6B00A5 for ; Wed, 10 Jan 2024 11:16:19 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E629016050A for ; Wed, 10 Jan 2024 16:16:18 +0000 (UTC) X-FDA: 81663903636.15.29FBBAA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id B3EAD160065 for ; Wed, 10 Jan 2024 16:15:49 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HyrmuLHF; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704903349; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JQxzPoBqUkjJKXWCpI4QIxSuMVYFE8rWv0kuA2EoYm0=; b=pFGWO+Nbgas2Ao/9saoDajaAd+jLDdd4NumvxKRhtzxcscnZAAQZPrXnCWc3zBBmY7W0I1 wM0PWOA/jWk6k0BJ9jSuggARckZro/VOOas4qmAYcb1wtdM0jAeGVHvo1IaTJamUSLjI3V HWtddQMErnuvh+9oELO3vAuly9PkxhU= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HyrmuLHF; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704903349; a=rsa-sha256; cv=none; b=VoG0+ltZS/9MfdysUJbpwD5TDGCKh6j3uWNlZpLhi/OoL3hiJYDThXBO87U336OlW7w7vf cX9O7QoAnmvSuuTO3TerJy134hJVlW408ObpWIkdafADF/uBFuznmAqo1o5d+ynlv43bcJ WikeGkNGkGkJNJkIgAweZaTbV0vqDNg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704903349; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JQxzPoBqUkjJKXWCpI4QIxSuMVYFE8rWv0kuA2EoYm0=; b=HyrmuLHFxYi/m8Ry6RqVlmAPYUxeeXe4isPdVgQNqY5cW25Q5Z4sZIztXRiOgSdSdH2MtY 7jAh2ttE1/dGsoQ+qDttDZ0g4z0NFPogmRysk85hiMQIXwNj7jLsqJR0/zB8n+4suxN6Hn VPiUrvPw0RJZWqFoMXm685knzqRKA24= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-693-oWSHhlXfN0GX_JnAxALTEw-1; Wed, 10 Jan 2024 11:15:41 -0500 X-MC-Unique: oWSHhlXfN0GX_JnAxALTEw-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-40e5317c7a5so8766635e9.0 for ; Wed, 10 Jan 2024 08:15:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704903340; x=1705508140; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JQxzPoBqUkjJKXWCpI4QIxSuMVYFE8rWv0kuA2EoYm0=; b=av3A2hZbm4emuIZJ2OLxSkkdvtFoETDIGtqyFGH6X77Dpf+mz98HVFzBPf2FMRstem K0orJ31UdN19wPI8a40PdcIJlJJdMV1JEKys8AsfzTwTnO/Fgbf+tjzFHed09aJAreGy kiLQTGeU3UnjtCO/4QiHoR3wToqi9+0UtNq7D1ZIMngFqAnzX4FlEBBdNZm9dadKGvK3 kQ7ULEtH5pmkv2TRveNoPyAkczccH7CRaRecfBjxDPP9BE92P+hRZz6JpQ6LCrp6I7Xt AXWF/XWbBlUSVTnu7XMYNmUPyQpVepaniBNB9BPDO8hvGqa7t2cOo9ud3VnQDDPK5VUH FxLQ== X-Gm-Message-State: AOJu0YwUgKBdkgRTxCWP9Gje/gW3jrW/eEGVjtZGbMpdi0qF/dYwys40 B3cSRt7WmZpQMWQo9Vecm1LCKnvlhZLKOrR/15iD5jP2vnznsz6IcQFrVGrCkfp320j9JcmEkeM 6jKU+7c5UB01Lk3iR7bU= X-Received: by 2002:a05:600c:3510:b0:40e:4e48:513b with SMTP id h16-20020a05600c351000b0040e4e48513bmr720158wmq.12.1704903340598; Wed, 10 Jan 2024 08:15:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IHDdldLwwCSeXTFyJAvZ2n3LbY4rJaPZI27i6HIK+nCTWMLKPz0evEsDOQ0W3aAHG8r6+AbnA== X-Received: by 2002:a05:600c:3510:b0:40e:4e48:513b with SMTP id h16-20020a05600c351000b0040e4e48513bmr720145wmq.12.1704903340170; Wed, 10 Jan 2024 08:15:40 -0800 (PST) Received: from ?IPV6:2003:cb:c73d:de00:7cf7:9482:e5dc:6ad0? (p200300cbc73dde007cf79482e5dc6ad0.dip0.t-ipconnect.de. [2003:cb:c73d:de00:7cf7:9482:e5dc:6ad0]) by smtp.gmail.com with ESMTPSA id g9-20020a05600c000900b0040b3d8907fesm2583491wmc.29.2024.01.10.08.15.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Jan 2024 08:15:39 -0800 (PST) Message-ID: <23bfe8cc-cffe-4832-a1fb-322f30f98f20@redhat.com> Date: Wed, 10 Jan 2024 17:15:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/memory_hotplug: fix memmap_on_memory sysfs value retrieval To: Sumanth Korikkar , linux-mm , Andrew Morton , "Aneesh Kumar K.V" Cc: Oscar Salvador , Michal Hocko , Gerald Schaefer , Alexander Gordeev , Heiko Carstens , Vasily Gorbik , linux-s390 , LKML References: <20240110140127.241451-1-sumanthk@linux.ibm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240110140127.241451-1-sumanthk@linux.ibm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: B3EAD160065 X-Stat-Signature: k6p4ihudwsqji8xhwpu5drcjkuruf8rj X-HE-Tag: 1704903349-100349 X-HE-Meta: U2FsdGVkX18LT3HWBKFtFk+WurcFoyACybdYVB/TyCBLhi7KgalZ8m9E9BZjRpFL19Mf61CJsQPXkAaDLzbTiNGyM2s2QF4CJHaCIiEQlM/WA/sxx1pmVxgrFXoAXm8aRkOaqR8a/idYnPzTN173oVopuaqC1vbExe5Noe7OAKCie4kNpz3aWRzWIXYFHc519VwxvT8xCU8ytWh3uB4XZj7nSM+5Dj3tGCSZfhafopUq7fBPmLfIRoembreQHSviXdrjMFFwBygBIw5kURZQc/vlKSLrYjCRARXgGxPeg4Agg6vjTtDowh3u3S25RcdIgCpPtZDFkbhPq8/7fVCdKJR3wN5Zl6yRaibsyY6BRNTn6OlUhbO67xpzIDy+vnmKuZCCkQ1RuE04mNluK82sGLA7cbpVtdVco2h6rTjCXB90bowbl/rEXzdLVzCSyI9cAfcPYODNI7iMWY4irHmpoUu0+3MKnMFScAtSAqKusluDHDmszwapl93VZ/QcgOr7ElGsHoIu//sQPPOemYOGSuBdZhVlx678jZYvKSqbKKJZbzLMaDvAs1ow+37pZsxAKxLQYcQW391Qtuyx20Em5yZ0zhhADptDO2UMRY1SIx6c/Nrx7qdlTN35FnrK7Bm+g418wQWdxRfQigxX5hnN5OxrgxVYVesYB6daa+QYcOOCx16waQMnHFvKsGcbYxVz98VfjE6w1Kss4H/I+hMZ4cp9psu7p2at0jXvpBeZTkzplTT1Trv6rWWeqr87QmJsW7D+Fav2aFKJ1J/aVBdGsnTHBhxnqj7dNEzgTn5KWBnE2xtOhHRrczy7sCgGiTnHCIEWhA2qQRYrUCbmOEAXHsrZm7XF0N8XxuUx+hObhYx4rvPtdavCknxrLpvH0ss+Pwnameh1vTUMOwEIXup7R7K7aiU55iN9+0WGYlJSFULfzm/ZxUE9p1gMznRkLw4KGTfFJv8vsF3sGrUhbo6 8G+rnbhY W9e+3H36A4UNVGBlBEJy37iCw10u6htl4N6K1OOye47E7pl+BheByDLBPplx7LYZ7oOoy0+TaHCcGGbcVEG7k1cL4SWTRztKg/WhvKQj2JJUYah0pp/ff+6xtsq2ph0s92TeQmEPb/E9hymZWHyq1FfOab0rflvfGSUSHou6pS4doyqo4HB5NxFPX7sRXFFSoi9MB9WSrynEQUtvg+wk1PGqtWHJWblCamup8NiJvvRbIJCMcFGooSfKFg8I3wvTzHTePjh7Gt3Ic7YoqcC/vWyYyTEsbf3qNithLivI/hC38tfsgJIH7ogoiZ5si0t7CoInSkLzdaYXKZH1PniUWTuTkmvUVlf3EXtVM18ZOtoIZgmfkTwzuaE5EQWg8TGah6U7IHf2LKAJQvPA4SrWnXSlduJmGBZeU2g2S+lgHPeKXDOD5F9ea9aUj3idOyxD2BsygWvSBK0Sw5/WXYr44GOeKLqVb6qvGcQPRU7sPmvvh3UWjYRc1XPi70nLkY9oQAdyjwCUSze8VGIELlaxUr8Y2OCJc782ip/03mihKGS67wgOBJYQFE4GMXzToeZnL9wYr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10.01.24 15:01, Sumanth Korikkar wrote: > The set_memmap_mode() function stores the kernel parameter memmap mode > as an integer. However, the get_memmap_mode() function utilizes > param_get_bool() to fetch the value as a boolean, leading to potential > endianness issue. On Big-endian architectures, the memmap_on_memory is > consistently displayed as 'N' regardless of its actual status. > > To address this endianness problem, the solution involves obtaining the > mode as an integer. This adjustment ensures the proper display of the > memmap_on_memory parameter, presenting it as one of the following > options: Force, Y, or N. > > Fixes: 2d1f649c7c08 ("mm/memory_hotplug: support memmap_on_memory when memmap is not aligned to pageblocks") > Suggested-by: Gerald Schaefer > Cc: # v6.6+ > Signed-off-by: Sumanth Korikkar > --- > mm/memory_hotplug.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index b944e8bf1911..707027f69150 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -101,9 +101,11 @@ static int set_memmap_mode(const char *val, const struct kernel_param *kp) > > static int get_memmap_mode(char *buffer, const struct kernel_param *kp) > { > - if (*((int *)kp->arg) == MEMMAP_ON_MEMORY_FORCE) > - return sprintf(buffer, "force\n"); > - return param_get_bool(buffer, kp); > + int mode = *((int *)kp->arg); > + > + if (mode == MEMMAP_ON_MEMORY_FORCE) > + return sprintf(buffer, "force\n"); > + return sprintf(buffer, "%c\n", mode ? 'Y' : 'N'); > } I was wondering if we want to return "Y" instead of "force". But using force seems more consistent. Acked-by: David Hildenbrand -- Cheers, David / dhildenb