From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 484E9C4332F for ; Fri, 30 Sep 2022 08:35:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C569C8D0002; Fri, 30 Sep 2022 04:35:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C06138D0001; Fri, 30 Sep 2022 04:35:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ACEB78D0002; Fri, 30 Sep 2022 04:35:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9DCFF8D0001 for ; Fri, 30 Sep 2022 04:35:08 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 75977814D6 for ; Fri, 30 Sep 2022 08:35:08 +0000 (UTC) X-FDA: 79968091896.20.D98464B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 1BB63140011 for ; Fri, 30 Sep 2022 08:35:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664526907; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XSPa4FtzDmD4JTH1460N7eSs7BBD1Xd0E/VxTc3dU50=; b=REq3xY0wSSLBrNEsHsdHfabA1x40n7efoXsQpHa+nR9hyVj3wfpViCM8LkST+4YcJXK+vX 0KoOyy9Dy/qXA2oAD7vm2YJrMV/8bnFDPJ0WVMAWEYtNrv6cbocAEtfcqDN0tHtoQfqGPZ NB7EvXWjaAUbglfUnYn1hwQyjCnSfCA= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-648-FF5PuOHIPbGPCeGKfuPEag-1; Fri, 30 Sep 2022 04:35:06 -0400 X-MC-Unique: FF5PuOHIPbGPCeGKfuPEag-1 Received: by mail-wm1-f71.google.com with SMTP id b5-20020a05600c4e0500b003b499f99aceso4139695wmq.1 for ; Fri, 30 Sep 2022 01:35:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date; bh=XSPa4FtzDmD4JTH1460N7eSs7BBD1Xd0E/VxTc3dU50=; b=SVGQnTG52uciWr6N7jFFoDIiHUbwCeKuCE+WcZdBLeUg96fOlh7jx+mtRURESsd69T a3mHJA2DVrSLSCuI8DvBiVhaEmi9k3i1BU6a65eOqXm/xU0pEIYpaCXT1uERt/m2nEpt KbO/dmQko0jQd6D5wlcuT7WdPUJFTxHlsma+wNUidfFs1W2u8HD5HVP+29SxvudMEWnN cYeqOBrz021FeBeHYx/cdxuNTPUJbKA05WxLB5ND0w859C/Wx91VcwS19wPwbWgexuqc UstkZBYHJoEU9pcPfoggtT1P7nG6d7lZq2ZeEwXSEcDbkn9vjgbmVe1CIZkR/IVg64qG 634Q== X-Gm-Message-State: ACrzQf17yo8rsncE3RP9JKHl5hJIOoeS9Ty7OJvSdcJw0YVGhHzeCnTd GKai4fq1FzyzyRBM5f2cjT6i8CB+kfhxuH7TBWK1aNDm0nvEhWv/N3tj84sT7NYc/W+qwfzYEB/ dGC4kLZvdL5s= X-Received: by 2002:a5d:457b:0:b0:22b:24d6:1a9f with SMTP id a27-20020a5d457b000000b0022b24d61a9fmr4791901wrc.201.1664526905292; Fri, 30 Sep 2022 01:35:05 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7qbKFNb2m2Iu07r8/LxpIsS0EuY6Hrbu/kOEB16WwNHE5p0FYk3g9x2L3Nsyb/SpVgiNef4Q== X-Received: by 2002:a5d:457b:0:b0:22b:24d6:1a9f with SMTP id a27-20020a5d457b000000b0022b24d61a9fmr4791882wrc.201.1664526905044; Fri, 30 Sep 2022 01:35:05 -0700 (PDT) Received: from ?IPV6:2003:cb:c70c:c00:48b:b68a:f9e0:ebce? (p200300cbc70c0c00048bb68af9e0ebce.dip0.t-ipconnect.de. [2003:cb:c70c:c00:48b:b68a:f9e0:ebce]) by smtp.gmail.com with ESMTPSA id h5-20020a5d4fc5000000b0022ccc22ca95sm1452643wrw.13.2022.09.30.01.35.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Sep 2022 01:35:04 -0700 (PDT) Message-ID: <23acdcfa-efd5-755d-6cd5-0631fd3a721c@redhat.com> Date: Fri, 30 Sep 2022 10:35:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH -next v5 3/4] selftests/memory-hotplug: Adjust log info for maintainability To: Zhao Gongyi , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Cc: akinobu.mita@gmail.com, corbet@lwn.net, osalvador@suse.de, shuah@kernel.org References: <20220930063527.108389-1-zhaogongyi@huawei.com> <20220930063527.108389-4-zhaogongyi@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220930063527.108389-4-zhaogongyi@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=REq3xY0w; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664526908; a=rsa-sha256; cv=none; b=mdCitBlMAtXx43foZt7if6NzMLR8SJFd0W6nz6xin30mNy2VbNyZ84YBIVWKiW+77eWnbG Tl1GowqZJmUU0c1GRq71lHbZOMhHMrm9+1z4mU/SKL+Ige30belZTaXcAXW1RaZuvdknbC in2EjUB2WndgiYYojS44B8EaRHaJVx4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664526908; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XSPa4FtzDmD4JTH1460N7eSs7BBD1Xd0E/VxTc3dU50=; b=gEjGBogq3ljz7FwQgYfDVMQiaECec81nA2cOqKhMFcSLVSGZvrT214GSvoHVPqHBSafbgJ WyYpStMS31U0EWJ2vePR/PapkUSiEJyA/GvvnfJc3snIIxRq1rC0bauB3apzxYo8BzDUeR t8HyFO56ySn2VzFbfS5ACT/JnGnqrDo= X-Rspam-User: Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=REq3xY0w; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam10 X-Stat-Signature: cb7z5s3ybezz5owj8jqqazm7tcxi7qt3 X-Rspamd-Queue-Id: 1BB63140011 X-HE-Tag: 1664526907-976054 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 30.09.22 08:35, Zhao Gongyi wrote: > Redirect misleading error message to /dev/null for > offline_memory_expect_success(), And, add an output > for online->offline test. > > Signed-off-by: Zhao Gongyi > --- > tools/testing/selftests/memory-hotplug/mem-on-off-test.sh | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh b/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh > index 91a7457616bb..74ee5067a8ce 100755 > --- a/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh > +++ b/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh > @@ -207,8 +207,11 @@ echo -e "\t trying to offline $target out of $hotpluggable_num memory block(s):" > for memory in `hotpluggable_online_memory`; do > if [ "$target" -gt 0 ]; then > echo "online->offline memory$memory" > - if offline_memory_expect_success $memory; then > + if offline_memory_expect_success $memory &>/dev/null; then > target=$(($target - 1)) > + echo "-> Success" > + else > + echo "-> Failure" > fi > fi > done > @@ -267,7 +270,7 @@ prerequisite_extra > echo 0 > $NOTIFIER_ERR_INJECT_DIR/actions/MEM_GOING_OFFLINE/error > for memory in `hotpluggable_online_memory`; do > if [ $((RANDOM % 100)) -lt $ratio ]; then > - offline_memory_expect_success $memory > + offline_memory_expect_success $memory &>/dev/null Acked-by: David Hildenbrand -- Thanks, David / dhildenb