From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2823DCE79AC for ; Wed, 20 Sep 2023 08:08:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BAC646B012D; Wed, 20 Sep 2023 04:08:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B67D86B012E; Wed, 20 Sep 2023 04:08:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A4A506B012F; Wed, 20 Sep 2023 04:08:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 957816B012D for ; Wed, 20 Sep 2023 04:08:11 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 31F22810DE for ; Wed, 20 Sep 2023 08:08:11 +0000 (UTC) X-FDA: 81256247982.03.755FCC9 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf26.hostedemail.com (Postfix) with ESMTP id 7440014001E for ; Wed, 20 Sep 2023 08:08:07 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf26.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695197289; a=rsa-sha256; cv=none; b=gHPfAYGMVKGa9QiFI1cQTpwwobhhzAYeTB0BuJ9WFv0K50I+FKAIOemS608UGIRJQ3Qk2c a9dy8Fm0PYbOoTHgo73ur9yGgsjG7idppM+iVG2lletpjPHf51s/i3AOepp9ZKs2Ow+N5a W8JTtjCnaf9HUkx/v3XiKBADpfOCC6c= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf26.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695197289; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o4iJFySXedwKerw9Fd+ihHdSkFlghk0l18BfQHGJCFc=; b=Q3snnf04PEuIaA8RliSPrTDfQX0DGb7Kx5P5IQA8qaqctlUVwD9imL2WD8eFKCM3YkNhWh 4VcM9ycS52MwYRLY0XhdeJ6ENjoSGkDoaYEEHxua6iJg/y1IMoj/TtiQrEBnOCSZV+x8ZV O9WOVXQzSf+G4QfjJN4++YfT27jN1gE= Received: from dggpemm100001.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Rr9ym5zlKzNmPB; Wed, 20 Sep 2023 16:03:44 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Wed, 20 Sep 2023 16:07:30 +0800 Message-ID: <23abf32a-3f34-426f-a918-2af37b409329@huawei.com> Date: Wed, 20 Sep 2023 16:07:30 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/6] mm: memory: add vm_normal_pmd_folio() Content-Language: en-US To: "Huang, Ying" CC: Andrew Morton , , , , , Zi Yan , Mike Kravetz , References: <20230918103213.4166210-1-wangkefeng.wang@huawei.com> <20230918103213.4166210-6-wangkefeng.wang@huawei.com> <87pm2dwna0.fsf@yhuang6-desk2.ccr.corp.intel.com> From: Kefeng Wang In-Reply-To: <87pm2dwna0.fsf@yhuang6-desk2.ccr.corp.intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm100001.china.huawei.com (7.185.36.93) X-CFilter-Loop: Reflected X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 7440014001E X-Stat-Signature: wzesf6jp5zj9yc4i4muz8bqfpewjrxj8 X-Rspam-User: X-HE-Tag: 1695197287-10827 X-HE-Meta: U2FsdGVkX19PVocssBZNYXcxvsu5QV2ntJIsK+/+6msG1tq83Ue79Um8/aax3pEmzGBW695Ixd65virC8Q1HU8u/PidcquuBTsIHsIytuU35gDdt9DIL3L9inra+Np6RmwwHs0wZR5+z5+lyAVTlaBDlxN8zDLlh/pET7zRbPPCNXJGSBw/YvWenySyCUicDdVxzD/TWj+5OZ2T5l3Tu8jLPcMwf47aTfB/vxsh0XmC/ghzrkir9vc6fTEYAC9p9zJpcDZJ6TNeTBRGYuPzg68JBjnnlwC8aw9HeABifsxE6dpnNwE/8nsUOT1pGjMzIKIb8DXRkGeeOunWUHaLxKdn8piC1PvykPapiquod+2I7Q4J40McnTAT+TtrcW4GoVMyXeQdPyWIWhRIuH+4Kps0fs3vNXPuw2qlHAKij9A1qNltUBI4iC5YOyi6+x6igF9HJQDVQcGags0LHp4ok0/o1L7XUTRwTY/Vcejvu1YnJsEBlSNRfyo8eAn3XyK7IS2uEPIU9iaHGle68X/1ayyiL8hSbsvhZzccoQ8x79g0F+vVDToUHOSlOlCFsRNwRlrWpO8tGU5EO9UypfiBnI4r8Q0jR5Ev77Vt1+yVPfkS5zG+H3q+yepKKdbADlY7ha7DN9how97T+swQLywvwqVMhph078F3asv2uSaQR6j+Xzk6BK7NdveckLvINoxHWiLdNJ1lb0nexgvENSvBXpfV7jjkmMIghEmwr46r4pgvazXJoXqQoGz0J/RCNUoLa1WxwakJ83wuWfbseR46L0h9LvhqOuZ0Rw937BkaSEtLcl7wKuIBcfSQJQXAURWrBdZjGIMbj0YeAiZs1uC0H+quAuqfgHepFMQmi68Bf9Jz+UnL0bC8ghS/9G/W0+xCXlmqwI/c4ayYgyAeswOJS/ayfwolzxwTp05UeJml47jc4bF8407KI6EbX41iqn8cxgJ0BT2VCLAFvIVogG+l h4FhFdEN MxKR0ygC48J7SvTFIbLoxKFUuJkoXSQ6r0xblOHVDDVCf3Ldg1ncckRMj42R1qM6aU1CwjoD2CHCXiVUS0eTjC8kmmQWtUMHWJ5Hcnjow8mnxb0vfDNFFsUbAqBJnJIdKsAtgHpvymGgKeyVGa6whOS1EG/ZSvQbulk+4RkrcmbnCYwiQO/wDWSPIdoV/oFmH8JZagjn7YBDDHM+4AcsNQm5NKKYjWXVG+rUacxG9UQVQbxVdk2JE8nxiOQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/9/20 11:12, Huang, Ying wrote: > Kefeng Wang writes: > >> The new vm_normal_pmd_folio() wrapper is similar to vm_normal_folio(), >> which allow them to completely replace the struct page variables with >> struct folio variables. >> >> Signed-off-by: Kefeng Wang >> --- >> include/linux/mm.h | 2 ++ >> mm/memory.c | 10 ++++++++++ >> 2 files changed, 12 insertions(+) >> >> diff --git a/include/linux/mm.h b/include/linux/mm.h >> index 12335de50140..7d05ec047186 100644 >> --- a/include/linux/mm.h >> +++ b/include/linux/mm.h >> @@ -2327,6 +2327,8 @@ struct folio *vm_normal_folio(struct vm_area_struct *vma, unsigned long addr, >> pte_t pte); >> struct page *vm_normal_page(struct vm_area_struct *vma, unsigned long addr, >> pte_t pte); >> +struct folio *vm_normal_pmd_folio(struct vm_area_struct *vma, unsigned long addr, >> + pmd_t pmd); >> struct page *vm_normal_page_pmd(struct vm_area_struct *vma, unsigned long addr, >> pmd_t pmd); > > Why do not follow the counterpart of page (vm_normal_page_pmd()) to be > vm_normal_folio_pmd()? Personally, X_pmd_folio seems to get folio from a pmd, but X_folio_pmd looks like "return the PMD of a folio", I could use vm_normal_folio_pmd() for consistency, thanks.