From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6ACD4CE7AA3 for ; Fri, 6 Sep 2024 11:35:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EDE236B0089; Fri, 6 Sep 2024 07:35:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E8D746B008A; Fri, 6 Sep 2024 07:35:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D7C546B008C; Fri, 6 Sep 2024 07:35:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id BA7036B0089 for ; Fri, 6 Sep 2024 07:35:31 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 67C25C137C for ; Fri, 6 Sep 2024 11:35:31 +0000 (UTC) X-FDA: 82534108062.09.BC5726E Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf18.hostedemail.com (Postfix) with ESMTP id A09A91C0004 for ; Fri, 6 Sep 2024 11:35:29 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf18.hostedemail.com: domain of vincenzo.frascino@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=vincenzo.frascino@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725622457; a=rsa-sha256; cv=none; b=vU73eGP4ac1EXdivC00zsBY1J6AApKJo5DR7A+uwslp9FO83ZnIvHDwbV/ySl6u7h4yJFV FCHDvx/Fyvou1tb5HVWyIE3btE4NsPxSohHU3/jRZvdwTmvTgDybjTjwtLI3wRbJmdPPjJ 4Y7sdmV2V262A9hDfRi6JHlCCV0taNs= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf18.hostedemail.com: domain of vincenzo.frascino@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=vincenzo.frascino@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725622457; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+aiqs+wkHw7/6M+QbNzcsEB45+qxDpLbonSNUA1JNwk=; b=ImP/zm0ysjBORlUKciUOsdeiQ8IzhqcUz8CsLHX8IntMy3MZ+57HZNReFs5myGedo5uB5G U33S0h7R2kTftiZXi6hBYf9+65gu4KfeqdqgcYqTiKVH8IqQdlecCzz5A1n542kJG26xzj 1IEGb8iRiZ9gs806zHD5MSSsZObniUk= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 033B7FEC; Fri, 6 Sep 2024 04:35:56 -0700 (PDT) Received: from [10.1.196.72] (e119884-lin.cambridge.arm.com [10.1.196.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 25FE53F73B; Fri, 6 Sep 2024 04:35:25 -0700 (PDT) Message-ID: <23a1c751-d957-4785-b54d-7e0b03b9117f@arm.com> Date: Fri, 6 Sep 2024 12:35:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/9] vdso: Introduce vdso/page.h To: Christophe Leroy , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org Cc: Andy Lutomirski , Thomas Gleixner , "Jason A . Donenfeld" , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Ingo Molnar , Borislav Petkov , Dave Hansen , "H . Peter Anvin" , Theodore Ts'o , Arnd Bergmann , Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers References: <20240903151437.1002990-1-vincenzo.frascino@arm.com> <20240903151437.1002990-5-vincenzo.frascino@arm.com> <18bcf426-b0a8-486b-b9f7-8418d401bb70@csgroup.eu> Content-Language: en-US From: Vincenzo Frascino In-Reply-To: <18bcf426-b0a8-486b-b9f7-8418d401bb70@csgroup.eu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: A09A91C0004 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: h4tgrqo7j9wptoexpb6qdxhka6j4qxn9 X-HE-Tag: 1725622529-269338 X-HE-Meta: U2FsdGVkX186E3dfVX0VionF+0EBNhnuaRtdZwFh4Ny3pF6b8X83GAYbkpjzhPzxOTdG8LDD+ckCqSugWFJpPf/GkcPdWMuiT3ukIyAkyb8oYV63CA3UCKu68Ds2JtcwWSMPQPVo0PwclLSPVZdgYRfpbUOHCxgTwYzm7tfOXv+OPRyEb4SWFFGjI1wMYT+jNuHbnN75ihFD6LCiPqsepcAuL/ZaYCIgZ6Rrq1g74uzUfJw+tXdlsweeoFWufDSEuJUtHYbd3yPevgtsGFMZZ+Vzhh7q2YUN9/pPiOoIIdknJGneQ6SBmqDLGEgbkcdyBuyt+JIvXXo53Dlh4COBS1xjdAMDaQSm+f0KvWzYXQI/F1zJNeztbuLWN05rC88ck2ZAVFTdfkDXVzHMiCii8/yig6hibhNvHcFu42DSkXdehNdMT54chSyoR5wsk2AP+JfRHHkv4cFql9LXQNd4Rs2Xa8UnEdvXpLwl0Q/XQ75Mel7e5J7gsdEQ28mYnHA2Z4YYz3JX3Y8cQqS6L378QC70/AOSQrvZZctGFOqMrwO7cxc/raD5uZsd9lZlGmJoLitVqb2BJ5dig6NkACfciyy6b6XNgBGEo3HtS2T5vDkanuF5CRScSS74stKl1MdsYSoPxR/326FU6Z1ZHcTEhVHbu0hN3/3o8xLD304FbRQ3ihn7ivwhTdhYdxofOkzvdx9OHBkWTz/w7IVchoV27a684VD3SwermTneiMi3rPGGUYcT5bqdHBBe7hfl/dZbVKyEyRp76ZwKIWImRTxsDWMGM2sqmktPRbomX5OiyyCG5F6tbWkel9hnBswS7uXx1ZMzcD82Ze8IPG3+MIdMecf+NjX+mGGjHiULgaWPcT/ePHX7QAFQiDSgvLcTimlwx4ZGi8HeM+Oj7G3HPhDV+MPzQUD3XiVyyCJpWr0LH9m7fz0m1e92pa/gfMBIJQotn+E3L73hbuSgc4roVQH MN8CYDCZ rTKtBRAxp1IeQU4PfBUZjJPEFpnXdgTBI0GAAe+elMtplku/aIG/9sJ8NMt9CS6ENHAtw1IdBFV5GtxSLQF737Ng7TSrHQwHd1lNfiwa12QoyWHId8mtB+sH/lhJMbnB1vUz/W9IlAybL8EhJr3jDX6GWifVCqGoD+65a3dd8wp/PRjrEQ2QjZPltJurMT3F47JflR1xKpiXKPp7OtFXDLiiZ+bbT0u7JJXW/c5NGND96kA2AKWaFANgo59ym8GYuriYyxceVQeETW/ohsAlMnu7yDIcZQYGAlHhlYTZlw+SasVLEkBZ7298x6Bg5CfEhnyY1Y7PmprF11VXVX8RHops+oGWPoz1Gf26i X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Christophe, On 04/09/2024 18:16, Christophe Leroy wrote: > > > Le 03/09/2024 à 17:14, Vincenzo Frascino a écrit : >> The VDSO implementation includes headers from outside of the >> vdso/ namespace. >> >> Introduce vdso/page.h to make sure that the generic library >> uses only the allowed namespace. >> >> Cc: Andy Lutomirski >> Cc: Thomas Gleixner >> Cc: Jason A. Donenfeld >> Signed-off-by: Vincenzo Frascino >> --- >>   include/vdso/page.h | 7 +++++++ >>   1 file changed, 7 insertions(+) >>   create mode 100644 include/vdso/page.h >> >> diff --git a/include/vdso/page.h b/include/vdso/page.h >> new file mode 100644 >> index 000000000000..f18e304941cb >> --- /dev/null >> +++ b/include/vdso/page.h >> @@ -0,0 +1,7 @@ >> +/* SPDX-License-Identifier: GPL-2.0 */ >> +#ifndef __VDSO_PAGE_H >> +#define __VDSO_PAGE_H >> + >> +#include > > I can't see the benefit of that, the generic library can directly include > asm/vdso/page.h > I think you agree that any discussion we can have on this point will be made obsolete by the fact that we will end up defining PAGE_SIZE/PAGE_MASK in vdso/page.h. >> + >> +#endif    /* __VDSO_PAGE_H */ -- Regards, Vincenzo