From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A06FCC3ABBC for ; Fri, 9 May 2025 14:58:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 51416280041; Fri, 9 May 2025 10:58:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C2AE280031; Fri, 9 May 2025 10:58:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 36479280041; Fri, 9 May 2025 10:58:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 16ED4280031 for ; Fri, 9 May 2025 10:58:30 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6822A1401F1 for ; Fri, 9 May 2025 14:58:31 +0000 (UTC) X-FDA: 83423675622.15.7AF5415 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id F18DD1C0002 for ; Fri, 9 May 2025 14:58:28 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Qr+CPI3y; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746802709; a=rsa-sha256; cv=none; b=uFRpEnGmKAWB6hrifgF3UuC5NGC80Y+QTp6Be7QeeoP92aUVzOhTgGQXmDdmMjvHpt+/6X OvbafSa6yroe2LNLxniSbi0ob7pCuGJBJqDH8rZnZNbf+HmIT0GYsnKjIEo5bn0Axtt57y 3VHQlIvRJ/6ooH2m7kT8nY8M6SSIjig= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746802709; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0TIOKEOXFEdBeMFSYSpw/lLdLicglZ7MeqiXtplqHbE=; b=YohgR73mG2FRk8whNwX50FRsLfHm1FZB85r3bTg/w28WKtPfWBRC+tctf+nhJDjBM3N809 uEy6neu7Fe6FmvBSaTpzcgTLPxhORQUeBJKNfWIe9j1ZjJ08ZHpH7+pceQCHx0f3jCiygr N1abqNb3SJsJQjmFvSQRyShpq28SwoU= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Qr+CPI3y; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746802708; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=0TIOKEOXFEdBeMFSYSpw/lLdLicglZ7MeqiXtplqHbE=; b=Qr+CPI3yeSUGUhBsuT6+kfNJY55eYfAUmdeYlUSbjqbmiEU9zFlkGwxVtt4j/XB1OqcaEk 0AEK3oSGctidj9ZI3j1gD9ByNje/Kdjc4to7AtagO9hJbkmhkYVkXd60g/qsiVHJz2TCKO /QZFSq3m9iRMA3XQlenqCHCxShmdlV8= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-527-h0UsdvgJM2SKdvysGbXvqQ-1; Fri, 09 May 2025 10:58:27 -0400 X-MC-Unique: h0UsdvgJM2SKdvysGbXvqQ-1 X-Mimecast-MFC-AGG-ID: h0UsdvgJM2SKdvysGbXvqQ_1746802706 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3a0b589a2c6so948927f8f.0 for ; Fri, 09 May 2025 07:58:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746802706; x=1747407506; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=0TIOKEOXFEdBeMFSYSpw/lLdLicglZ7MeqiXtplqHbE=; b=kp0B7ZsvrzyR28ZpCnImZmpCEIaQ4yilngyEcdtEb5izT2DLxuK2kpw8iaoxW+4maL vl+6Jnq/E00GNjJAqYqmNulhJlMPptgL3P3414d+yEvh/Ynzceea++pX7dqgMfYQ8xoY mlV4f+sk6pKUqyLroErx2VVf2R/94EeJFVszdhb/LTf0u3uSp8EnOI83K+7P49iqeVR5 xkKcf9ElqKYRYKpMmfrpUxdrGn41ImtoOpsexYS/qDSaWY3Axcoe4nBrRG7bxGLiH/3b MamAA2x/O01dLQc5crQOjayMC2//f9eXYQRffzNfv0yOkxSpMD3XZZjXRgiDsHJts3oW T8Ww== X-Forwarded-Encrypted: i=1; AJvYcCWy8lrLovGDMhkOBsyRPxAHIxAXlX2+bMeetkoFhhR8XKUg0VUYYYFNFhdoUIKSizxuEoasYHCNbQ==@kvack.org X-Gm-Message-State: AOJu0Yw0XWO4DAl5/6Cio9pkimmj92b5+GDDZ43cTm/e6bOCvU70cegW MhyuMUwUrhJ/bsPi1aKvD9XWllbr+aj/lXvI8wntg6u9rJ1dkcnm9/FEKTsQDlXBU7snYkVlFUw c0YNU+Nyq1IOga/HTV8HOrFDQRaQ47NIGKwWrwYtvO0Fg3RT7 X-Gm-Gg: ASbGnctJDWitQO7Gm+0mgV0PMHzZ9X9nmGnGVbbFxPgowcPH72jbnRnvsy5mdU1F550 ttXXyVpP0VqgUycKkxJt3BP1QtqJQsz5mgVO16K3Wyuu9S55/z7bCDujByypTAUhJ3bJ1lM6mCg Qy2rL+uJiyNDJ0RiwdqBtEr4MGuuOyB0Lz2ZF6/uEsJkmIou5MQ5f59Fdebyz5n7irrAyUvb0Kl TyHMLADwrx3YHm7upfBCchukJURb4WOOWTPuuCjTEpuDW3Q8sqSqpN87UfgMZfbkXLc2U6uTpcn xRFJjaquaDb3g1v9eqJrA848kN5C3jfwqyE9hvyHqiRXHc2n33zNAzxIPj9DcHEtQGtP4EfaT4J KSb3m6CaSpUEaBS5ljB2vK+mpNmf71yRNmCYjncw= X-Received: by 2002:a05:6000:2506:b0:3a0:a0e5:d28b with SMTP id ffacd0b85a97d-3a1f6421ecemr3169216f8f.3.1746802705970; Fri, 09 May 2025 07:58:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE4EkgKSa0Fw3sSGWFnxTkwSyIT42PNLGghxyEMA9R5N53xefutA8VnoC5Gw5yOM4hfwiqTqw== X-Received: by 2002:a05:6000:2506:b0:3a0:a0e5:d28b with SMTP id ffacd0b85a97d-3a1f6421ecemr3169199f8f.3.1746802705607; Fri, 09 May 2025 07:58:25 -0700 (PDT) Received: from ?IPV6:2003:d8:2f45:5500:8267:647f:4209:dedd? (p200300d82f4555008267647f4209dedd.dip0.t-ipconnect.de. [2003:d8:2f45:5500:8267:647f:4209:dedd]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a1f57ddfd6sm3445854f8f.4.2025.05.09.07.58.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 May 2025 07:58:25 -0700 (PDT) Message-ID: <239471b5-12fe-4bad-a6e1-e9f0ad195ab5@redhat.com> Date: Fri, 9 May 2025 16:58:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] mm: khugepaged: convert set_huge_pmd() to take a folio To: Baolin Wang , akpm@linux-foundation.org, willy@infradead.org Cc: hannes@cmpxchg.org, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, ziy@nvidia.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: DeXKIqc27QculSiN8j4s0Pz0CdmHPIMxzd6orGSXcXw_1746802706 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: F18DD1C0002 X-Stat-Signature: y87g8pp3urxrou69i39t53sreyet6nqw X-Rspam-User: X-HE-Tag: 1746802708-558020 X-HE-Meta: U2FsdGVkX1/Eu834e29I/fTz+7E8v/bzTEUFuUhwmXh7foAKq6+NSuGzJYGHMpkexVPn1qRISyGqClrWz/gyDD5l656SoiJnU2H0iVUGGgMfrdMm1yzmKVBRju7n7c53o3BSSJOiw4VfDw3K8RMgpRPUSy7Dva3zTQtzdAWPGGTZtV7ipA/eFphozidVBMNc6q8TEpINzHdR1N5tDT/E02pYshE3R2OIynj5v1UzdGMnv5lDQXFwi4YTX/i4q4yY9Pm0oaLM+YSvzv/zWfT8+uXh/nLEwpoLVTLMwFgCQQtekhd6A4wrNKDKlsMi1nMEweF8+l1gxB0YXx11A+nsCnRrHLS47fapvZP/T/IfDDQEGaQHDEP14+weIqjeLaQDITHr1Qt7LHURvooY3FaAkP76d/Q32kNwHFHhd39f2Co95JyQhLuHLEMlidmfvLgBnch5zhnrNGzT4lFhbx3kDZsjxvOdnvPZMMtZyNUpNHbwhCi2/29f2cwwcR8euNpikRfQ7KLFMbjAUBRJmjZTOHVQtPraCq7VgJMBxhd0BkJKMSRrT1Aqe/dqHT6PJhhMescogsz8yqdsLV3cV8/6q4T45s5ul3aq97K2qrfLIP9BWah6KWmTV/cIXvoISwyHOfAUi5skMLles4sLGVJXKfjWrfV8+hr8Gac+/lz42uSfqn595+ofUYm5MHFw2OSx59X9F+QBSgAkQu7j8UkANB4dYvOXsbcePvTq7yvw+SOSS5RtCP7RxYthwYY3h9tqettf89VaGqrlaT6qmBgoEgrzcFe5W387h2MnB/ui2oNMGIdmMCIVvjG7sW6fQi7sUu3Q+t2ph1Q45BWAXqwHPnS6ynhuyH61erqbq5rhMSZSpTl6lUYvy6t0wEwnD9TPaaMWWMHkU5kYAqarb+Oo/6NlSZcwmboXzHVXg3Vex3Y77bOmZxSazZEJSIGV5zbBdLRxQEmrq1uev8/i1Mr ZSU78K/A /P6wS3saSG74jDjOQc9IOSQDGS1sl+EflB25LWboJZECkn03xuPvReq8gm0u1VpGTcl1JPEt4ruUEB9C0tHZr1/klzceBGVSAI79lRFMYx9/P8HuA5zGIM9wWGk9yq1JBCMeWOHi0vBv6fLJ7uYZLPB/qqcKnh+fNGsB2eSjfbjdzhuGbARGmKuATjYdxURj1HzVvBxw4zABn0kaltPQKD5+7XCINuMd7WsHsOsqepP7LWZgUVhirdDOcbJ72HOzP4n2hr7rdfJg/jDSuV/SVFI7/6TDvWdvyDjqg4K+at4ScnyksqVSDC08ImMqSGeSDh/KlsHHOn1LQ1z5Ot660VRysRJrMt0TyOQN7hDnLLTVue09eErn0GZkGmCpBrlwXp/LfWBR2H9uBwaz17Zqx9mDub1r+bmx4vxSxDB098+U+teboHtlJ/CG5SSJHPBDoF70RoQRFP4eX0Jvg0Z3Nq2AeDZeB7RSZBcYu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > index b04b6a770afe..aca66e7f4fd9 100644 > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -1467,7 +1467,7 @@ static void collect_mm_slot(struct khugepaged_mm_slot *mm_slot) > #ifdef CONFIG_SHMEM > /* hpage must be locked, and mmap_lock must be held */ ^ that comment probably needs some love. > static int set_huge_pmd(struct vm_area_struct *vma, unsigned long addr, > - pmd_t *pmdp, struct page *hpage) > + pmd_t *pmdp, struct folio *folio) > { > struct vm_fault vmf = { > .vma = vma, > @@ -1476,13 +1476,12 @@ static int set_huge_pmd(struct vm_area_struct *vma, unsigned long addr, > .pmd = pmdp, > }; > > - VM_BUG_ON(!PageTransHuge(hpage)); > mmap_assert_locked(vma->vm_mm); > > - if (do_set_pmd(&vmf, hpage)) > + if (do_set_pmd(&vmf, &folio->page)) > return SCAN_FAIL; > > - get_page(hpage); > + folio_get(folio); > return SCAN_SUCCEED; > } > > @@ -1689,7 +1688,7 @@ int collapse_pte_mapped_thp(struct mm_struct *mm, unsigned long addr, > maybe_install_pmd: > /* step 5: install pmd entry */ > result = install_pmd > - ? set_huge_pmd(vma, haddr, pmd, &folio->page) > + ? set_huge_pmd(vma, haddr, pmd, folio) Wondering why we are not passing in the folio+page pair in here as well. I assume in the foreseeable future this code will not be able to work with folios large than PMDs? Apart from that LGTM. Acked-by: David Hildenbrand -- Cheers, David / dhildenb